From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4564743892; Thu, 11 Jan 2024 13:03:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C270140266; Thu, 11 Jan 2024 13:03:15 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2040.outbound.protection.outlook.com [40.107.102.40]) by mails.dpdk.org (Postfix) with ESMTP id 7F7424025E for ; Thu, 11 Jan 2024 13:03:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AK3l+kK1YVhfadingvM3yxzw5fv/EJdk3FTmdIre7OnLdYgXrEXkKY45zfys3iRZFDWg1FtSGOrUw+hKSmQxzvA7D7GEVpRShUjxgyIhKXqSeM6EM/8vYbyySdKMrj7qrGPlWZhF+pPt5qcjo9kyHYBEMoVBQ9+/H96+rEVMw+vZHtgebi+UI0lm7CBu4NJP31pvOwJBiUTio9OXrr5oSdGlV6DmZ5nyN18WA2f05iJBVIhvBpi2v9GnYGpje7qyntF+gNY51W3XujXr+75ZvdQgD6Nlzu4RJrj/6GEDWDkspZDgncRgIgrUVHdjbp+YlkimjoGdbwpKM5D2y72s0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=831ERRcX7JtkpN1SZWm4PJVS/vT2zWdX/Qzo3V9Kvkk=; b=AMz9QU/dONQXYdcFuQ7QSEZV5x1ZWKPCPfWsUy/qik17WyMjxYkmriQcJy0u64FRjN5M2mAbn+YN0JNJyJoP28RbaWpGWkX2ZSW/5bmFZVBkkV+QNpBZtrxckT4J07bl+j277ssEcSKimQxFSRAvMSS/zBwFz2S/RpSveJDOobqHYONH8+/fjrIj1TRVhTXcen8uFaZKwO94bQ/nhqPhw9Fg9DMYpHNvaPasABdCOW4f8IKsqRizjDi4yvh8PPc/ccdzlq369xb4UFBD75HmkGY+jHIMoWNm6GsII7G4OdfQO92nXn1OxR0T1thTD1bc2+z+al9TBFarBfxrm20Aeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=831ERRcX7JtkpN1SZWm4PJVS/vT2zWdX/Qzo3V9Kvkk=; b=tPB9qo2SpfiFds9jf0U7D9Locx1lS/PHXH3dP6OPJ3o0EgqKIxdPl1H/iEXyfbdf1eYuBsGF+4x/O//SOxzrYSquhqH0SI9PXfTkUbfzHtekyGWKvDVqATjIPDeW4jJO69MVhbY6OAa3ygqApcVcgGtoJw6E6q60KSjZmTFHC7k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7591.namprd12.prod.outlook.com (2603:10b6:208:429::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Thu, 11 Jan 2024 12:03:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7181.018; Thu, 11 Jan 2024 12:03:11 +0000 Message-ID: <264c4296-e705-46b4-80dc-e7b5c7567ecd@amd.com> Date: Thu, 11 Jan 2024 12:03:06 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Content-Language: en-US To: Lewis Donzis , Bruce Richardson Cc: dev , Jochen Behrens , Yong Wang References: <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> <20240109142343.163814-1-bruce.richardson@intel.com> <529916588.1295809.1704816025297.JavaMail.zimbra@donzis.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <529916588.1295809.1704816025297.JavaMail.zimbra@donzis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0094.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7591:EE_ X-MS-Office365-Filtering-Correlation-Id: 26d57f5d-37be-4332-2c70-08dc129d4872 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pqd/5uj7QBUH3BU3Bfw4fCi2FrM4WFYhVN4wa58227f9Xx3t/IxnlHDIUrVcOD/A7djYGsxT+za/VvrCzrMmxgYRpkK3yrTZ/VPbEcIwFnaLCRCNyDYu6Hs7ceh5vxy8Z9zBKgT0WaEncvYGimSbOKtBpQSEC8KYvu+j+5l+CRfcH/ETZwtiX8xyfAoFs1iELZVOZ43KFQQkub/X2jDDFsIbpESVUY7pR40+qernkl4+eYBHomSu45YXUxZHm+PWAHKWh4vrdTpI6cvG9hcXw5aClhdQd8do0xnR5ljbfIs38nUa/Xwcv3n0HcdtWXaVG8NzGFp/ifz4oWBeWDiw35m6oZ6TfZdi7+ZEiz9Kz7d9P2SkKZOMRu16FDZsGl5wWZQKjxqUhcmK4DIjHH48BAdygkdWHz4U1dYDpcytoVBj//T+JGw+MgF0Zd8aUUoTLTrrY9jhRTj8P8XPNMp4eWHTKlBpww0eZv70Gb58GCQDnZPnocw90h4wTZT9Bt0YMWaIjjyon1ZQJ1vt9Ea70nNCfqQfxrCn04g6QFOJHP9EOMEMrYczQLKw1wdaj+MNChps6onqxhCYMzzApCz5m66uOWt7PRErljscvIXwnGfRf6Dawr3D92gOdX0Zfon3adFSh5yYAhf0/f9af0a2nA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(376002)(136003)(346002)(396003)(39860400002)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(53546011)(8936002)(6486002)(4326008)(316002)(44832011)(8676002)(5660300002)(478600001)(66556008)(6512007)(54906003)(66946007)(31696002)(36756003)(4744005)(2906002)(86362001)(38100700002)(110136005)(66476007)(6506007)(2616005)(26005)(6666004)(41300700001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUc5V2RTQ2lqbEJ2Q0dnMmp1blJMejlCaDlFL1dYNjRDZEtuZFZtQ3hXWURP?= =?utf-8?B?U25aYXNCNE1jc2VYVFJmSU95RVZVNkNlWC9DOUVzZzk4QnE2QmhBQnZ5VzJZ?= =?utf-8?B?M3BuZVN3ck5WU2dVUVBzT3ZyS1F0Y1hrMjJMRjdGVGlNU0NzaTBOSG94VThx?= =?utf-8?B?TjZMWm9senhQeE4xRVloNGZFS0xNckdya2pvN0JjMzdTU1ZIWWk1MWxnVGxR?= =?utf-8?B?bDFaTS91L0JTSGJ5ZlFyakIxVi9jKzRTdE4xZ2c5WWwvclZaZTVLeWp1OTVY?= =?utf-8?B?UGVsYWJuTEYyNHZTSnpydFhETmg0VFg5bnI0NUR3b2xRWkVBa014anJmSFA5?= =?utf-8?B?MEFHRHBReW1mbU12SFd6ZGtSSlphaWFHK1hma3FEeHE4dUxMVGVxbmxhcnAz?= =?utf-8?B?Wm05eXVOb1JKVEIrUFdDenhFRTIyOWJDdWdaQzNsS2RhaHo1Y3VIalJRcUZZ?= =?utf-8?B?YzNqYWkxZTdVWEJKTUdrSnZFU1ZjRnM4K01SRi9nMFFxTHNDMTBOL0xickVp?= =?utf-8?B?TXpVMDJSNXNlSTlMU3hUZTdWZHVFaWFzL2plSkdCci9zQlhWU21ma3p4eHV2?= =?utf-8?B?cm9MSjhnOW9HekZpU1pWNDV3cVVKVzNzLzNzbldPYjcrd3E2QnN0S21TbVIr?= =?utf-8?B?d2M4MEljZUIvZnBlOWpxS0R6bkM0ZjhMQ1E2OVkvWFUzajhvc0xoRUhsa1o0?= =?utf-8?B?cllMQ0p2VEVWZlhyR21hUXRYbHpuLzNRaytpTk93S2tEUHE5Uk1uTitzK3g4?= =?utf-8?B?UXh1MjA4VHlTYTNNZTR2bHZyZ1FlU0JHRmtLdEpBeHMvM1crMCs0U1BJT1ho?= =?utf-8?B?eFJwS2lJcFFiZXZha3hLc3VwOWs2bnZvK29GZDRDM2pvSmgzMnBBYzVsUTJh?= =?utf-8?B?Yy9pZkg4MEdQa3FpQlRQVlpQVFA5Y3pXZ0puLy8zb3VSR3cwMzRQVWc0UmNT?= =?utf-8?B?QVNCVElpemJKTk5YaHEwR0RGcHM2a2hVdWRSRjF2ZmlLTjNVRHYvaEg3YkRr?= =?utf-8?B?TGIvYjZzaXZ3OWlnc2thckNEWWZhNGZrQVl4OE1IS0JMSXhTNWs5eUlpR2Zm?= =?utf-8?B?MEtIeTRFc0U5cDludUZ5U3I0OEdmYUsyekFXT0xwVTZ0cU8xRmo1T0xwekMx?= =?utf-8?B?TjVxaUlaeUFCNWxMeFNFOE1kaWZNcEx5WHBOQlp3NEFIdHIwZ1Z0TXl2d3Z4?= =?utf-8?B?RTI4Z3FmUUxRRlRCTkhjMSs3N1J6UnlmSzdjbHYwUXF2a3NBWUtzYU5kbXRw?= =?utf-8?B?V1FaRm5RR0ZLaXZSREZpdzYxemJPWmJDQ1JncCtVMU9VUFE2ak84bklRRGxq?= =?utf-8?B?UGFvaFpHUW01N1F0L0ttTHBwanQ4SEdMaVJrN0hwc3kwVmthZ3FRenZuNTRB?= =?utf-8?B?a2hRTVVreWxxb1N3NkV6L05WZ29YRU1OK20yTjVwdGFmRXNSdis2QnJmMWlo?= =?utf-8?B?OElpVmR3V09QTSs4YlB1NXY5QlVTaEVSZjY5T00vc0QzOXJ3cFVYdDd4cmY0?= =?utf-8?B?SFZMWmJjOXVRbnZLYTVKVmdqQlQ5UGdFYWJ5TjFkdDBYZjdrVWZNMjJTdFhN?= =?utf-8?B?SlcrZHpqbkZmMzJ0OTZLOFZBdEh3ZDAyS1dKY1BLbllOdnBDcytDOTNxRUFq?= =?utf-8?B?WDkxYUpqZ2pGYjZ3aDRJbk1ndzRFZzBFcDdsRkJYR2ZXWkRCemZJQjNjanJQ?= =?utf-8?B?SEI3VUtjc1kvUmhkM1R3bURPZndQYU5zVEh2eTM0cEJpcG1lK0JJdlFrRUpy?= =?utf-8?B?dDNER084SElVa3lwQTlmL3AyM3JIRmxSNXl1SEova2RnQTFoSUR3V0NVTHM4?= =?utf-8?B?b3J0bUNCUFhnalgybnd6dWFiRHNSdkQyN1RnYlU3NUdaQ3JCa1RGOEZPTkds?= =?utf-8?B?L01KSXdaVjZmTHNjeUpmY2d4aCtaeE5vdHJHT00zMVJ5SG1qOXMyYXV2QnEw?= =?utf-8?B?cG0xaHRQSjNGSmJKQmxEQzdqZnI3Rll5SVpJNWxLOXlrMEF5ZEY5VVRvN2V0?= =?utf-8?B?MVYrMjNrSzk4YmU1ZWtwRzQyOWZpbm91SGR3d3JjRXFadEs1YUd1VWV1cVVY?= =?utf-8?B?cW5tTXNHTTZoVVdTVzJpb0xEajZpajJGNktFY0hFY1VMSWJVRThndkp3T3dY?= =?utf-8?Q?ZwQOZoPRdhY0M57pVnaIpoFVc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26d57f5d-37be-4332-2c70-08dc129d4872 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2024 12:03:11.6814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SX/XcnpdQfhtSji4Q+hPq30CWR0ZXdFbc1/M/LS/oEJBiOsvPsbHtsoP2u+mvLt9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7591 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/9/2024 4:00 PM, Lewis Donzis wrote: > > > ----- On Jan 9, 2024, at 8:23 AM, Bruce Richardson bruce.richardson@intel.com wrote: > >> DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver >> returns error when enabling interrupts as it initializes. We can fix >> this by #ifdef'ing out the interrupt calls when building for FreeBSD, >> allowing the driver to initialize correctly. >> >> Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") >> >> Reported-by: Lewis Donzis >> Signed-off-by: Bruce Richardson >> > > Tested-by: Lewis Donzis > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.