From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8E1514C7C for ; Wed, 28 Mar 2018 12:57:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 03:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,371,1517904000"; d="scan'208";a="38802262" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.112]) ([10.237.220.112]) by orsmga003.jf.intel.com with ESMTP; 28 Mar 2018 03:57:21 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, jianfeng.tan@intel.com, konstantin.ananyev@intel.com References: <338e432277f98a206df87e7808ec799de28535ce.1521895541.git.anatoly.burakov@intel.com> <2165690.q5cnMgZWhB@xps> <2dc81fb9-5926-f595-27fc-1eee07d6e21b@intel.com> <2360089.qufSKTD6lu@xps> From: "Burakov, Anatoly" Message-ID: <26512ff4-e6d4-e0c7-8fc2-2b4519a83f68@intel.com> Date: Wed, 28 Mar 2018 11:57:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2360089.qufSKTD6lu@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/2] eal: rename IPC sync request to pending request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 10:57:23 -0000 On 28-Mar-18 11:08 AM, Thomas Monjalon wrote: > 28/03/2018 11:15, Burakov, Anatoly: >> On 27-Mar-18 5:27 PM, Thomas Monjalon wrote: >>> 27/03/2018 15:59, Anatoly Burakov: >>>> Signed-off-by: Anatoly Burakov >>>> Suggested-by: Jianfeng Tan >>>> Acked-by: Jianfeng Tan >>> >>> You probably have a good explanation for this change. >>> Please explain in the commit message. >>> >>> Generally speaking, every commits should have an explanation, >>> it is a basic quality rule. >>> Thanks >>> >> >> This is just to reduce noise in the following patch. > > No Anatoly, you should explain why a rename is needed. > I know :) I'm going to be submitting a v7 with function renames anyway, so i'll fix this as well. -- Thanks, Anatoly