* [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
@ 2018-01-29 17:13 Olivier Matz
2018-01-30 6:06 ` Andrew Rybchenko
0 siblings, 1 reply; 6+ messages in thread
From: Olivier Matz @ 2018-01-29 17:13 UTC (permalink / raw)
To: dev, Neil Horman, John McNamara, Marko Kovacevic
Cc: Ferruh Yigit, Thomas Monjalon
Announce internal PMD API change in the function to set the default MAC
address. The objective is to be able to notify errors occurring in the
PMD.
Link: https://dpdk.org/dev/patchwork/patch/32284/
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 43a39d827..8ad4407c2 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -76,3 +76,11 @@ Deprecation Notices
* mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
names will be removed in v18.08.
+
+* ethdev: The prototype and the behavior of
+ ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
+ will be added to notify the caller if an error occurred in the PMD. In
+ ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
+ will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
+ succesfull. This modification will only impact the PMDs, not the
+ applications.
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
2018-01-29 17:13 [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC Olivier Matz
@ 2018-01-30 6:06 ` Andrew Rybchenko
2018-01-31 19:11 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2018-01-30 6:06 UTC (permalink / raw)
To: Olivier Matz, dev, Neil Horman, John McNamara, Marko Kovacevic
Cc: Ferruh Yigit, Thomas Monjalon
On 01/29/2018 08:13 PM, Olivier Matz wrote:
> Announce internal PMD API change in the function to set the default MAC
> address. The objective is to be able to notify errors occurring in the
> PMD.
>
> Link: https://dpdk.org/dev/patchwork/patch/32284/
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 43a39d827..8ad4407c2 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -76,3 +76,11 @@ Deprecation Notices
> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
> names will be removed in v18.08.
> +
> +* ethdev: The prototype and the behavior of
> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
> + will be added to notify the caller if an error occurred in the PMD. In
> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
> + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
> + succesfull. This modification will only impact the PMDs, not the
> + applications.
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
2018-01-30 6:06 ` Andrew Rybchenko
@ 2018-01-31 19:11 ` Ferruh Yigit
2018-02-13 12:42 ` Shahaf Shuler
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2018-01-31 19:11 UTC (permalink / raw)
To: Andrew Rybchenko, Olivier Matz, dev, Neil Horman, John McNamara,
Marko Kovacevic
Cc: Thomas Monjalon
On 1/30/2018 6:06 AM, Andrew Rybchenko wrote:
> On 01/29/2018 08:13 PM, Olivier Matz wrote:
>> Announce internal PMD API change in the function to set the default MAC
>> address. The objective is to be able to notify errors occurring in the
>> PMD.
>>
>> Link: https://dpdk.org/dev/patchwork/patch/32284/
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index 43a39d827..8ad4407c2 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -76,3 +76,11 @@ Deprecation Notices
>> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are
>> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old
>> names will be removed in v18.08.
>> +
>> +* ethdev: The prototype and the behavior of
>> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code
>> + will be added to notify the caller if an error occurred in the PMD. In
>> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address
>> + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is
>> + succesfull. This modification will only impact the PMDs, not the
>> + applications.
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
2018-01-31 19:11 ` Ferruh Yigit
@ 2018-02-13 12:42 ` Shahaf Shuler
2018-02-14 0:00 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Shahaf Shuler @ 2018-02-13 12:42 UTC (permalink / raw)
To: Ferruh Yigit, Andrew Rybchenko, Olivier Matz, dev, Neil Horman,
John McNamara, Marko Kovacevic
Cc: Thomas Monjalon
Wednesday, January 31, 2018 9:12 PM, Ferruh Yigit:
> On 1/30/2018 6:06 AM, Andrew Rybchenko wrote:
> > On 01/29/2018 08:13 PM, Olivier Matz wrote:
> >> Announce internal PMD API change in the function to set the default
> >> MAC address. The objective is to be able to notify errors occurring
> >> in the PMD.
> >>
> >> Link:
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp
> >>
> dk.org%2Fdev%2Fpatchwork%2Fpatch%2F32284%2F&data=02%7C01%7Csha
> hafs%40
> >>
> mellanox.com%7C5a25d2b43a32440d2e5c08d568de7559%7Ca652971c7d2e4d
> 9ba6a
> >>
> 4d149256f461b%7C0%7C0%7C636530227046083042&sdata=uMIQfiMB7pEFwi
> ELWH4Z
> >> gvHBpq%2FXuYDYr7B6ICB34kE%3D&reserved=0
> >>
> >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >> ---
> >> doc/guides/rel_notes/deprecation.rst | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/deprecation.rst
> >> b/doc/guides/rel_notes/deprecation.rst
> >> index 43a39d827..8ad4407c2 100644
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> @@ -76,3 +76,11 @@ Deprecation Notices
> >> * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT``
> are
> >> respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The
> old
> >> names will be removed in v18.08.
> >> +
> >> +* ethdev: The prototype and the behavior of
> >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return
> >> +code
> >> + will be added to notify the caller if an error occurred in the
> >> +PMD. In
> >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC
> >> +address
> >> + will be copied in ``dev->data->mac_addrs[0]`` only if the
> >> +operation is
> >> + succesfull. This modification will only impact the PMDs, not the
> >> + applications.
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
2018-02-13 12:42 ` Shahaf Shuler
@ 2018-02-14 0:00 ` Thomas Monjalon
2018-02-14 17:05 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-02-14 0:00 UTC (permalink / raw)
To: Olivier Matz
Cc: dev, Shahaf Shuler, Ferruh Yigit, Andrew Rybchenko, Neil Horman,
John McNamara, Marko Kovacevic
> > >> +* ethdev: The prototype and the behavior of
> > >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return
> > >> +code
> > >> + will be added to notify the caller if an error occurred in the
> > >> +PMD. In
> > >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC
> > >> +address
> > >> + will be copied in ``dev->data->mac_addrs[0]`` only if the
> > >> +operation is
> > >> + succesfull. This modification will only impact the PMDs, not the
> > >> + applications.
> > >
> > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC
2018-02-14 0:00 ` Thomas Monjalon
@ 2018-02-14 17:05 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-02-14 17:05 UTC (permalink / raw)
To: Olivier Matz
Cc: dev, Shahaf Shuler, Ferruh Yigit, Andrew Rybchenko, Neil Horman,
John McNamara, Marko Kovacevic
14/02/2018 01:00, Thomas Monjalon:
> > > >> +* ethdev: The prototype and the behavior of
> > > >> + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return
> > > >> +code
> > > >> + will be added to notify the caller if an error occurred in the
> > > >> +PMD. In
> > > >> + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC
> > > >> +address
> > > >> + will be copied in ``dev->data->mac_addrs[0]`` only if the
> > > >> +operation is
> > > >> + succesfull. This modification will only impact the PMDs, not the
> > > >> + applications.
> > > >
> > > > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > >
> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-14 17:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 17:13 [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC Olivier Matz
2018-01-30 6:06 ` Andrew Rybchenko
2018-01-31 19:11 ` Ferruh Yigit
2018-02-13 12:42 ` Shahaf Shuler
2018-02-14 0:00 ` Thomas Monjalon
2018-02-14 17:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).