From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 915ED271 for ; Thu, 30 Mar 2017 22:42:05 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id w11so76451310wrc.3 for ; Thu, 30 Mar 2017 13:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=BBTJlhtZwoKImgrJjeTiUED3dCIL2a43Ngse+sixnoE=; b=Co4j3nBzt10pWsc9boIBP3C12177t3pgL5bKu7MHU1Whd57BHQl00rT6eXN6OrRwjW fpyZUG64KY5DCMDJ9jC9aEGqyixTPRivHIpaZdvIPm57dV2EpNVIl0PproPw57K9+VYO rKMDK/ghGkSBpBhicSkHUvMjU1Gd+x4HPTobj7Wlc2Qj+ycShDr81nFfTTJAS6RMmcRH YZblu4YZxwzunA7Wg0cPo1axzy9mdYl2kAJN0h3P1ChVw+yM/YPPJpIpB+ViUfTxrdR8 FbETTAqD1/eyzCBb0zL0akDK2fEP5OIze1CpM1rkDc/OJHqeOs9MWRzc6Q3cXIVNNsXO xmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BBTJlhtZwoKImgrJjeTiUED3dCIL2a43Ngse+sixnoE=; b=ZBSI+BLYYnQmSfXODH4olAMTDU8j7NWkuqid1jddtpmGbP+RDtVSA7YpRyyxRy8TU2 UILbYwYSJn3VPowrbIV+8EXvyMNE3CiI+YHUHexQjWhBHjTbve5d9kJdsVgJPgW590ox BabP1QlgnZr1gAbgoYAUp0a1gSAhdZL6DITMFI0vDXGEee6f91RH9SIlkShs5qfYYShL gUyaHDmi5+Amxrfai44phIFXurX79sTxSZ5G/qtUioqgprjVMK+VtyqFegGB0HqY+N9c Q/AXWWOsc05pgUsaQPnJEPtdlyGdMhh1beECrRUxaHUJ7AN2jWwLiMwZkTfVEf0bHNOQ QJWQ== X-Gm-Message-State: AFeK/H28Z6HD7JSFWwO/DgDsHVvlNBkDW+yVWcV9AtaVI2DXgb+6sauO5/tdNG0C8CVZCDu/ X-Received: by 10.28.178.84 with SMTP id b81mr86518wmf.83.1490906525316; Thu, 30 Mar 2017 13:42:05 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l132sm255226wmd.10.2017.03.30.13.42.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 13:42:04 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson , ferruh.yigit@intel.com Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Date: Thu, 30 Mar 2017 22:42:03 +0200 Message-ID: <2656152.ADfflcFtbm@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com> References: <20170329140419.27149-1-bruce.richardson@intel.com> <1851186.Q5rVaVkRzi@xps13> <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 20:42:05 -0000 For info, Ferruh did a similar patch: http://dpdk.org/patch/22443 Ferruh, OK to keep Bruce one? 2017-03-30 16:33, Bruce Richardson: > On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote: > > 2017-03-29 17:38, Bruce Richardson: > > > Since the test app is no longer being build by default as part of a build, > > > we need to update the testbuild script to take account of this. > > [...] > > > --- a/devtools/test-build.sh > > > +++ b/devtools/test-build.sh > > > @@ -229,6 +229,9 @@ for conf in $configs ; do > > > echo "================== Build $dir" > > > make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ > > > EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir > > > + echo "================== Build tests for $dir" > > > + make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \ > > > + EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir > > > ! $short || break > > > echo "================== Build examples for $dir" > > > export RTE_SDK=$(pwd) > > > > It should be added after the "short break". > > > You have no idea how many times in preparing the patchset I moved the > addition above the break, and then back below it, and above it again! > You pick what you think is best. :-) > > > The test-build target rebuild all. > It rebuilds the libs, but not the apps, which is why we can't just > use test-build target, or we will skip testpmd. > > > I think it should be standard apps like the examples > > and not re-link the libs before building. > > The other way is to merge it with the above command (default build). > > I tried merging the two into a single command, i.e. "make all > test-build" but that failed with parallel builds because the two jobs > try and build some things at the same time and interfere with each > other. [The kernel drivers seemed to be the main problem] > > /Bruce