Re: [dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for armada drivers

[Thomas Monjalon <thomas@monjalon.net>]

11/01/2021 17:08, Liron Himi:
> From: Thomas Monjalon <thomas@monjalon.net> 
> Sent: Monday, 11 January 2021 18:05
> To: Liron Himi <lironh@marvell.com>
> Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Liron Himi <lironh@marvell.com>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers
> 
> 11/01/2021 16:29, Liron Himi:
> > Hi Thomas,
> > 
> > When did you take this MUSDK version?
> > Is this your head "pkg-config: expose dma-add-size"?
> 
> I'm using musdk-SDK-10.3.5.0-PR2 as recommended in the doc.
> 
> > If not, this explain the mvneta issue.
> > I already noticed that and pushed a fixed to the github.
> 
> I see. So it may need a doc update.
> [L.H.] why need to update the doc? It is still the same release branch, I just added a fix patch to it.

Yes, my bad: I used the tag musdk-SDK-10.3.5.0-PR2
instead of the branch musdk-release-SDK-10.3.5.0-PR2.

> > As for the prefix issue,
> > The prefix is being set in the 'configure' phase by using the '--prefix' variable. Have you tried that?
> 
> No I didn't try that, and I'm using DESTDIR variable when installing.
> Whould it be possible to update the prefix with DESTDIR when installing?
> [L.H.] need to explore this option. But for now use 'prefix', as this is what supported by MUSDK

OK


> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, 11 January 2021 13:28
> > To: Liron Himi <lironh@marvell.com>
> > Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran 
> > <jerinj@marvell.com>
> > Subject: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for 
> > armada drivers
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > 16/12/2020 22:36, lironh@marvell.com:
> > > From: Liron Himi <lironh@marvell.com>
> > > 
> > > With pkg-config support available within musdk library (from
> > > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' 
> > > can be removed.
> > > PKG_CONFIG_PATH environment variable should be set appropriately to 
> > > use the musdk library.
> > 
> > Sorry, it does not work.
> > 
> > First, when installing MUSDK, the .pc file is not updated with the correct prefix path:
> > 	make install DESTDIR=$(readlink -f install) In install/mv/lib/pkgconfig/libmusdk.pc:
> > 	prefix=/mv
> > instead of:
> > 	prefix=/musdk_path/install/mv
> > 
> > Second, after manually fixing the prefix path and compiling DPDK:
> > 
> > In file included from musdk/install/mv/include/mv_std.h:101,
> >                  from musdk/install/mv/include/drivers/mv_neta.h:100,
> >                  from dpdk/drivers/net/mvneta/mvneta_ethdev.h:24,
> >                  from dpdk/drivers/net/mvneta/mvneta_rxtx.h:10,
> >                  from dpdk/drivers/net/mvneta/mvneta_rxtx.c:7:
> > musdk/install/mv/include/env/mv_autogen_build_assert.h:43:5: error:
> > "MVCONF_DMA_PHYS_ADDR_T_SIZE" is not defined, evaluates to 0 
> > [-Werror=undef]
> > musdk/install/mv/include/env/mv_autogen_build_assert.h:44:2: error:
> > #error "MVCONF_DMA_PHYS_ADDR_T_SIZE must match size used during musdk_lib compilation."
> > 
> > The CFLAGS may be incomplete:
> > 	Cflags: -I${includedir} -DMVCONF_TYPES_PUBLIC -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC I fixed it by adding:
> > 	-DMVCONF_DMA_PHYS_ADDR_T_SIZE=64
> > 
> > Please could you fix MUSDK quickly?
> > 
> > I think I will pull next-net as is, but I consider it is broken.
> > 
> > 
> > 
> 
> 
> 
> 
> 
>