[dpdk-dev] [PATCH 1/2] event/octeontx: fix build with icc

[dpdk-dev] [PATCH 1/2] event/octeontx: fix build with icc

[Ferruh Yigit]

build error:
.../drivers/event/octeontx/ssovf_worker.c(212):
error #592: variable "get_work0" is used before its value is set
        RTE_SET_USED(get_work0);
        ^

.../drivers/event/octeontx/ssovf_worker.c(213):
error #592: variable "get_work1" is used before its value is set
        RTE_SET_USED(get_work1);
        ^
For x86 these variables set but not used, move macros below
where values assigned.

Fixes: f61808eaa9ad ("event/octeontx: add start function")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/event/octeontx/ssovf_worker.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c
index 6a99df0..ad3fe68 100644
--- a/drivers/event/octeontx/ssovf_worker.c
+++ b/drivers/event/octeontx/ssovf_worker.c
@@ -209,9 +209,6 @@ ssows_flush_events(struct ssows *ws, uint8_t queue_id)
 	uint64_t enable, get_work0, get_work1;
 	uint8_t *base = octeontx_ssovf_bar(OCTEONTX_SSO_GROUP, queue_id, 0);
 
-	RTE_SET_USED(get_work0);
-	RTE_SET_USED(get_work1);
-
 	enable = ssovf_read64(base + SSO_VHGRP_QCTL);
 	if (!enable)
 		return;
@@ -227,6 +224,9 @@ ssows_flush_events(struct ssows *ws, uint8_t queue_id)
 		cq_ds_cnt &= 0x1FFF1FFF0000;
 		ssovf_load_pair(get_work0, get_work1, ws->base + reg_off);
 	}
+
+	RTE_SET_USED(get_work0);
+	RTE_SET_USED(get_work1);
 }
 
 void
-- 
2.9.3

[dpdk-dev] [PATCH 2/2] event/sw: fix build with icc

[Ferruh Yigit]

build error:
.../drivers/event/sw/sw_evdev_scheduler.c(379):
error #300: const variable "dummy_rob" requires an initializer
        static const struct reorder_buffer_entry dummy_rob;
                                                          ^

Variable "dummy_rob" defined as const but already cast to another
pointer and its content updated. Remove const qualifier from variable.

Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/event/sw/sw_evdev_scheduler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c
index c0fe6a3..77a16d7 100644
--- a/drivers/event/sw/sw_evdev_scheduler.c
+++ b/drivers/event/sw/sw_evdev_scheduler.c
@@ -376,7 +376,7 @@ sw_refill_pp_buf(struct sw_evdev *sw, struct sw_port *port)
 static inline uint32_t __attribute__((always_inline))
 __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder)
 {
-	static const struct reorder_buffer_entry dummy_rob;
+	static struct reorder_buffer_entry dummy_rob;
 	uint32_t pkts_iter = 0;
 	struct sw_port *port = &sw->ports[port_id];
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH 2/2] event/sw: fix build with icc

[Thomas Monjalon]

2017-04-05 16:32, Ferruh Yigit:
> build error:
> .../drivers/event/sw/sw_evdev_scheduler.c(379):
> error #300: const variable "dummy_rob" requires an initializer
>         static const struct reorder_buffer_entry dummy_rob;
>                                                           ^
> 
> Variable "dummy_rob" defined as const but already cast to another
> pointer and its content updated. Remove const qualifier from variable.
> 
> Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Series applied, thanks