From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4B6FA00BE; Mon, 28 Oct 2019 18:09:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1E4E71BF8E; Mon, 28 Oct 2019 18:09:34 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 1B94C1BF88 for ; Mon, 28 Oct 2019 18:09:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 21C8E21583; Mon, 28 Oct 2019 13:09:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 13:09:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FUepUeIlVX5+vfDE97AYxbkmFMygvEf6B34oYHG1ZHQ=; b=I6WdIlRMFoHZ 8BcFKRagkk2X3klGGk+5viZ6zUcjQ+DFeSvuQdrKjaoeSk4hrbWRwAxJjYwFX4T6 3NI1nIBLn4hEVdYRI4eX3FVovvoQNZ22zyLYzFUOBIC+HcOP7TNadwMVbn4VDffp XIxStkh3qtU2w49F6lWR3XDxAadX5/E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FUepUeIlVX5+vfDE97AYxbkmFMygvEf6B34oYHG1Z HQ=; b=mVgvgfY5viuY84bcF0klAdRgBNd5aujCVAmBQBImJUyx1+g0rFtqFWocA QUlt6X1PWO1vWp3sGXbSgsN+cNPCQ9Sq6w/kmV57QSdA6EYhe0JVYK0P7i6NJap1 5Vp2rybKSqRke+ioM80WADkkRjBmuV5+8pFUJCDcXqWdov0b41pqVq6d5ruD7Auk don9AtK+qaB/AaGm3h66nZ4jAxnUmZsrtb7BTa1tK9BiMPEj2PfZt8oiD0pAVRI/ kmZFU7+/abSFPyz9N9e69POtyLIHbRA5cEg6Cd0Bst0GaqxK7nGtbRNV/mphfd3z LVhM0PzCZ5bfO6TLmY93GDxFfQDSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgdeljecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CB97580060; Mon, 28 Oct 2019 13:09:30 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Bhagavatula Cc: Phanendra Vukkisala , "dev@dpdk.org" , Jerin Jacob Kollanukkaran Date: Mon, 28 Oct 2019 18:09:29 +0100 Message-ID: <26649674.DGTEfl1OhS@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 15:50, Pavan Nikhilesh Bhagavatula: > >21/09/2019 20:16, pbhagavatula@marvell.com: > >> From: Pavan Nikhilesh > >> > >> Some kernel modules have '-' in their name when populated in > >> '/sys/bus/pci/drivers/' where as the kernel always populates > >> '/sys/modules/' with '_'. > >> Replace '-' in module name with '_' to avoid script complaining > >> that module not loaded. > > > >Sorry it does not look obvious to me. > >Please, could you describe what is wrong and what is the real cause? > > > > dpdk-devbind.py can also be used to bind devices to kernel modules. > Some kernel modules are registered with '-' in their name and are populated > with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_' Sorry, still not clear. What do you mean by "registered"? > This confuses the current script making it unable to bind to such modules. The patch > addresses it by always replacing '-' with '_' when looking in /sys/modules/ Yes this sentence is clear (except it is /sys/module/). Please send a v2 with a clear explanation.