From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
pbhagavatula@caviumnetworks.com, nipun.gupta@nxp.com,
jerin.jacob@caviumnetworks.com,
santosh.shukla@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API
Date: Tue, 06 Feb 2018 01:05:19 +0100 [thread overview]
Message-ID: <26657316.2WP0XlBasG@xps> (raw)
In-Reply-To: <20180202134007.qvip4jkiv2gksxoj@platinum>
02/02/2018 14:40, Olivier Matz:
> On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote:
> > From: Nipun Gupta <nipun.gupta@nxp.com>
> >
> > The existing rte_eal_mbuf_default mempool ops can return the compile time
> > default ops name if the user has not provided command line inputs for
> > mempool ops name. It will break the logic of best mempool ops as it will
> > never return platform hw mempool ops.
> >
> > This patch introduces a new API to just return the user mempool ops only.
> >
> > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name")
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
>
> This option is fine for me. I think we may also consider deprecating
> rte_eal_mbuf_default_mempool_ops(), as it is done in option 2.
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
next prev parent reply other threads:[~2018-02-06 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 19:47 [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Hemant Agrawal
2018-02-01 19:47 ` [dpdk-dev] [PATCH 2/2] test: use the best mempool ops API to get mbuf pool Hemant Agrawal
2018-02-01 19:56 ` [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Hemant Agrawal
2018-02-01 20:40 ` Pavan Nikhilesh
2018-02-02 5:43 ` Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-2 1/2] eal: use named memzone to store user mempool ops name Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Hemant Agrawal
2018-02-02 13:40 ` Olivier Matz
2018-02-02 13:47 ` Hemant Agrawal
2018-02-06 0:05 ` Thomas Monjalon [this message]
[not found] ` <BY1PR0701MB1895B37B913A223180EED6D3EAFF0@BY1PR0701MB1895.namprd07.prod.outlook.com>
2018-02-04 6:34 ` [dpdk-dev] Fw: " santosh
2018-02-04 10:27 ` [dpdk-dev] " Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-2 2/2] mbuf: fix user mempool ops get to use only named memzone Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH] doc: remove eal API for default mempool ops name Hemant Agrawal
2018-02-02 8:31 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2018-02-02 14:01 ` Olivier Matz
2018-02-13 11:28 ` Ferruh Yigit
2018-02-14 14:58 ` Thomas Monjalon
2018-02-03 13:28 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26657316.2WP0XlBasG@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).