From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by dpdk.org (Postfix) with ESMTP id 46ED1C168 for ; Wed, 15 Jun 2016 17:20:35 +0200 (CEST) Received: by mail-lb0-f177.google.com with SMTP id xp5so3534535lbb.0 for ; Wed, 15 Jun 2016 08:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=V/gFtcXEtObT/4axeSG4OLzGKe09k7QBiAswFzP36Bw=; b=fOQjP+Tq5kJVBnnY+H7QpQppXMRYBtj0aG/GaeEuSNYSx83RKQKedewStx10jwS6Sj Fi44W3eCYUQ02B/CGTe9rQE+HGr8VD+I1MrZUY967jqB9fw26JMkD/dHvtZUKXWAdIhR SsYEOmxUQSqXP4rpdEGMszpE1Roz3qVcZ9HAsmQIsAQCJyqaaVADpLplwm2v+ZKU9Pgv MgB8t/Po2NIWjE8sx/y8sL4ZdxDYeyupug47QyYToSHyp7KxEfPRk81lSv0a5aaQnbR5 u4MtMgaqSMG+uQuBVUVNYJcrSuDQcm7qC07fIEXom4HCTgbBCRViXHjpbDOzbMPXnAhn gK7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=V/gFtcXEtObT/4axeSG4OLzGKe09k7QBiAswFzP36Bw=; b=mCFPyN0zlxcipfNWEFKZNmcDA69qjD/9imI95orqsl7/vjAQnyXOfm39ndEF9nXHGN m+J/4uEahktTBt1K8KQsnJok5LYZhoEKc16qlL4jWLgROMcxQjZ6CWJtNDn+zhIm9Au4 IopVeMNgltqhw1DmUwC4Qe5qPzTfL3AenQHpU2Vmep5eJulvasjcm6uDJVUbnmcFXJ9F J0nBwZosTU7OJKB6+Tv79VaWmVJUZha65tkrF79vKdMcU1ne5k+2LyQD5WsnkRZliTow uDnQ8kwvN1k+fCZLOaw4z+on+nqBiinaaF5d2yexSv7IIpMKMZqMD9KwDfnJW+T3X3kx vGrg== X-Gm-Message-State: ALyK8tJH0jy4LuTbLOUoE63E7nkw1BSC8u9V4cHbkLNXhJqI377lTwPc8qWYn7fZmpAF4DdY X-Received: by 10.28.24.82 with SMTP id 79mr11165701wmy.42.1466004034895; Wed, 15 Jun 2016 08:20:34 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b77sm3083501wme.0.2016.06.15.08.20.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 08:20:34 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, "Ananyev, Konstantin" , "johndale@cisco.com" , "Zhang, Helin" , "adrien.mazarguil@6wind.com" , "rahul.lakkireddy@chelsio.com" , "alejandro.lucero@netronome.com" , "sony.chacko@qlogic.com" Date: Wed, 15 Jun 2016 17:20:33 +0200 Message-ID: <26681669.pKzqhz6yqQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com> References: <1464359593-3534-1-git-send-email-olivier.matz@6wind.com> <1465991287-28262-1-git-send-email-olivier.matz@6wind.com> <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mbuf: new flag when Vlan is stripped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 15:20:35 -0000 2016-06-15 12:33, Ananyev, Konstantin: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in > > PMDs not advertising the same flags in similar conditions. > > > > Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED > > and PKT_RX_QINQ_STRIPPED that are better defined: > > > > PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its > > tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping > > is enabled in the RX configuration of the PMD. > > > > For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated. > > It should be removed from applications and PMDs in a future revision. [...] > > For PKT_RX_QINQ_PKT, it was only supported on i40e, and the behavior was > > already correct, so we can reuse the same bit value for > > PKT_RX_QINQ_STRIPPED. > > > > [1] http://dpdk.org/ml/archives/dev/2016-April/037837.html, > > > > Signed-off-by: Olivier Matz > > Acked-by: Konstantin Ananyev Applied, thanks