From: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Subject: [dpdk-dev] [PATCH v2] net/bonding: support bifurcated driver in eal cli using --vdev
Date: Tue, 4 Jul 2017 17:27:40 +0530 [thread overview]
Message-ID: <266cd54d289bfd6e9535a173c9607f0234f8b1b7.1499167396.git.gowrishankar.m@linux.vnet.ibm.com> (raw)
In-Reply-To: <f48d6def9336149378e332b91d15d07c12c63182.1497437314.git.gowrishankar.m@linux.vnet.ibm.com>
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
At present, creating bonding devices using --vdev is broken for PMD like
mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown
to find_port_id_by_pci_addr(), as below.
testpmd <EAL args> --vdev 'net_bonding0,mode=1,slave=<PCI>,socket_id=0'
PMD: bond_ethdev_parse_slave_port_kvarg(150) - Invalid slave port value
(<PCI ID>) specified
EAL: Failed to parse slave ports for bonded device net_bonding0
This patch fixes parsing PCI ID from bonding device params by verifying
it in RTE PCI bus, rather than checking dev->kdrv.
Changes:
v2 - revisit fix by iterating rte_pci_bus
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
drivers/net/bonding/rte_eth_bond_args.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c
index c718e61..180586c 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -40,6 +40,8 @@
#include "rte_eth_bond.h"
#include "rte_eth_bond_private.h"
+extern struct rte_pci_bus rte_pci_bus;
+
const char *pmd_bond_init_valid_arguments[] = {
PMD_BOND_SLAVE_PORT_KVARG,
PMD_BOND_PRIMARY_SLAVE_KVARG,
@@ -59,16 +61,6 @@
unsigned i;
for (i = 0; i < rte_eth_dev_count(); i++) {
-
- /* Currently populated by rte_eth_copy_pci_info().
- *
- * TODO: Once the PCI bus has arrived we should have a better
- * way to test for being a PCI device or not.
- */
- if (rte_eth_devices[i].data->kdrv == RTE_KDRV_UNKNOWN ||
- rte_eth_devices[i].data->kdrv == RTE_KDRV_NONE)
- continue;
-
pci_dev = RTE_ETH_DEV_TO_PCI(&rte_eth_devices[i]);
eth_pci_addr = &pci_dev->addr;
@@ -103,12 +95,18 @@
static inline int
parse_port_id(const char *port_str)
{
+ struct rte_pci_device *dev;
struct rte_pci_addr dev_addr;
- int port_id;
+ int port_id = -1;
/* try parsing as pci address, physical devices */
if (eal_parse_pci_DomBDF(port_str, &dev_addr) == 0) {
- port_id = find_port_id_by_pci_addr(&dev_addr);
+ FOREACH_DEVICE_ON_PCIBUS(dev) {
+ if (rte_eal_compare_pci_addr(&dev->addr, &dev_addr))
+ continue;
+
+ port_id = find_port_id_by_pci_addr(&dev_addr);
+ }
if (port_id < 0)
return -1;
} else {
--
1.9.1
next prev parent reply other threads:[~2017-07-04 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:49 [dpdk-dev] [PATCH] " Gowrishankar
2017-06-15 13:54 ` Ferruh Yigit
2017-06-16 14:34 ` Thomas Monjalon
2017-07-04 11:57 ` Gowrishankar [this message]
2017-07-07 15:38 ` [dpdk-dev] [PATCH v2] " Declan Doherty
2017-07-10 6:32 ` gowrishankar muthukrishnan
2017-07-31 14:34 ` Gaëtan Rivet
2017-09-05 9:13 ` Thomas Monjalon
2017-09-06 8:59 ` gowrishankar muthukrishnan
2017-10-02 8:41 ` [dpdk-dev] [Suspected-Phishing]Re: " Raslan Darawsheh
2017-10-02 8:44 ` gowrishankar muthukrishnan
2017-10-03 8:38 ` [dpdk-dev] [Suspected-Phishing]Re: " Raslan Darawsheh
2017-09-20 18:04 ` [dpdk-dev] [PATCH v3] " Gowrishankar
2017-10-02 11:06 ` Doherty, Declan
2017-10-02 23:32 ` Ferruh Yigit
2017-10-02 12:09 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=266cd54d289bfd6e9535a173c9607f0234f8b1b7.1499167396.git.gowrishankar.m@linux.vnet.ibm.com \
--to=gowrishankar.m@linux.vnet.ibm.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).