From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 422AD43212; Fri, 27 Oct 2023 08:28:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1574A402AA; Fri, 27 Oct 2023 08:28:00 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 0E1C84029A for ; Fri, 27 Oct 2023 08:27:58 +0200 (CEST) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SGt0930QdzMl5s; Fri, 27 Oct 2023 14:23:37 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 27 Oct 2023 14:27:52 +0800 Subject: Re: [PATCH v2 1/3] ethdev: introduce maximum Rx buffer size To: Huisong Li , CC: , , , References: <20230808040234.12947-1-lihuisong@huawei.com> <20231027041523.14518-1-lihuisong@huawei.com> <20231027041523.14518-2-lihuisong@huawei.com> From: fengchengwen Message-ID: <266f47b2-a47f-91f8-e3e9-d63d2c010e55@huawei.com> Date: Fri, 27 Oct 2023 14:27:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231027041523.14518-2-lihuisong@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Chengwen Feng On 2023/10/27 12:15, Huisong Li wrote: > The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum > Rx buffer size supported by hardware. Actually, some engines also have > the maximum Rx buffer specification, like, hns3. If mbuf data room size > in mempool is greater then the maximum Rx buffer size supported by HW, > the data size application used in each mbuf is just as much as the maximum > Rx buffer size supported by HW instead of the whole data room size. > > So introduce maximum Rx buffer size which is not enforced just to > report user to avoid memory waste. In addition, fix the comment for > the "min_rx_bufsize" to make it be more specific. > > Signed-off-by: Huisong Li ...