From: Thomas Monjalon <thomas@monjalon.net>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: stephen@networkplumber.org, liuyonglong@huawei.com, dev@dpdk.org
Subject: Re: [PATCH v1 2/2] ethdev: fix some APIs can be used in the new event
Date: Thu, 16 Jan 2025 10:09:40 +0100 [thread overview]
Message-ID: <2673930.7s5MMGUR32@thomas> (raw)
In-Reply-To: <4080a156-3031-fbb6-e7b9-fc511c398a87@huawei.com>
16/01/2025 07:14, lihuisong (C):
> 在 2025/1/15 19:36, Thomas Monjalon 写道:
> > 15/01/2025 04:41, Huisong Li:
> >> The rte_eth_dev_socket_id() and rte_eth_dev_owner_*() can be used after
> >> allocating an ethdev. So this patch relaxes the conditions for using them.
> > You should be more explicit:
> > "during probing, before it becomes generally available and considered as valid".
> "During probing, before the port becomes generally available, its socket
> id and owner id can be considered as valid."
> How about say it like this?
I prefer when you give the function names, it is more explicit.
next prev parent reply other threads:[~2025-01-16 9:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 3:41 [PATCH v1 0/2] ethdev: clarify something about " Huisong Li
2025-01-15 3:41 ` [PATCH v1 1/2] ethdev: clarify do not something in the " Huisong Li
2025-01-15 11:31 ` Thomas Monjalon
2025-01-16 6:16 ` lihuisong (C)
2025-01-16 9:15 ` Thomas Monjalon
2025-01-16 9:35 ` lihuisong (C)
2025-01-15 3:41 ` [PATCH v1 2/2] ethdev: fix some APIs can be used " Huisong Li
2025-01-15 11:36 ` Thomas Monjalon
2025-01-16 6:14 ` lihuisong (C)
2025-01-16 9:09 ` Thomas Monjalon [this message]
2025-01-16 9:35 ` lihuisong (C)
2025-01-16 11:40 ` [PATCH v2 0/2] ethdev: clarify something about " Huisong Li
2025-01-16 11:40 ` [PATCH v2 1/2] ethdev: clarify something about the " Huisong Li
2025-01-16 11:40 ` [PATCH v2 2/2] ethdev: fix some functions are available in " Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2673930.7s5MMGUR32@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).