From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8124042C05; Thu, 1 Jun 2023 17:48:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1714440EF0; Thu, 1 Jun 2023 17:48:27 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id 9A75640DDC for ; Thu, 1 Jun 2023 17:48:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLlCSBQiTotpEz1MV846/pAKcmLv3bfN/wWUbH8u3c1nYS40v5CZsH1tejWDBsHJqWg5GPMdBCZ+cHhx9pstwPdOFckEw+olLgWa6mQ5wBrcX8J821+2PwxWuTikWa8W+1vLIYcJhck8Qc83OVsc2gkYI6idJ9TNu49NxDRoOEnShTHfjbjkKz/j7lui0+ySjIoOEfzypImfacVN4ZlLOmIi2hlvKrhVAPvUMLemL+LyiJfLd5Cd8MRetfk1czVVGpmaM1iP6arLw8Cdw5qzBdvJMJ4Fkex6zwOcGBkGyU9gfgyiE1GAUqDumkXGfLDclB/5UMi6D338LljYacJEvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7evFo5eGXRIUvC2Dn9oskNhp7YOvaOn1TqFqbzPKm1A=; b=lMlDE04gIDqP4EChCe2Nq/DFMvDwip2d235mZKzkYh0HN+UzpppC07Z9+VAXCxuUSFnaik5I7lw/aHnrl7UDDH7G6d4sDPjwQ4Unl1BXrGdtomQCqGzO2ZSUBcFy7GqBWV1LVo6r/rSIJN1CWodhMrj41MTf/M9MrDrODVvXSbLT6BltdO3wlU9mam9T7SBwTVsX9C893g7V+BpzyzWfN6HDfI0CJL0aSNQo6AV6i/4d4MOyB9nY5HxDOvaRs6jwcV9A6SlmzVmLrsJQ93QcCUi31vaSdj0TJN2og53IZRLjqiByXMsLjKmzPAvcMIxfmZ3lyjlkOauMmY6UOakuSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7evFo5eGXRIUvC2Dn9oskNhp7YOvaOn1TqFqbzPKm1A=; b=O1bCCxP8WypEskV35YTe+S4kx2aYHHk45kLJgvBORW0YVHdXVol/Fhel/UAaewb8QMl1ac4X+vTC5l/mmFCuyYPWqDZwQrKV5p60It2uXpqJUgjE2GqeQslQuLAlXnIptmH7bcyOOHGImK/BhLlJyuFAS/Lg1KDb+tRFeUhcPOA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BY5PR12MB4323.namprd12.prod.outlook.com (2603:10b6:a03:211::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22; Thu, 1 Jun 2023 15:48:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6433.022; Thu, 1 Jun 2023 15:48:20 +0000 Message-ID: <26777cc1-ae67-7193-2e0e-b2146d3afb62@amd.com> Date: Thu, 1 Jun 2023 16:48:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2] common/sfc_efx/base: set return code in case of the error Content-Language: en-US To: Artemii Morozov , dev@dpdk.org Cc: Andy Moreton , Andrew Rybchenko References: <20230531070810.93131-1-artemii.morozov@arknetworks.am> <20230601063042.11253-1-artemii.morozov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230601063042.11253-1-artemii.morozov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BY5PR12MB4323:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ab70b68-09c2-4c51-e55f-08db62b79fb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CNQHDES6CW2pftUwFty6f7Lfm3x3E4PBU1MC+6vyLJopqz0LZdeUBrrkEX09KKqtNp/esasw6ijWdwgaV4Fv6mz4/LvV01k25XV3kp5gGWi5ul+Ttxauihx/Ukx4MByW9lYX0XR+ioeSNfQt8pWuHWtzb2aRwbAwlKjaa8IyoM6rm3H38cp6+Os8qcWqIBqUWcieQZxBPcgdy50fNa0zJAuzUpvIvEXC8SShdQCTSQjhJ92HBl1v88hfYPdFG6NWU4W6KqNTyGup8KPlQj6U79gu9+WAeY64ks+svnWjHOJtKK1oUfLMTQzGE0a3nnfZAQZyfY6/1hpS2yvoJy9rE27RlQZ+HMVF6Auk8Okr2Q2QnTQcEfaYOyx7BuAIwDRg0B/kUE3l7IvYFeo6pBu20Oq/TOYiuwdzPvF8Hs1noQYXm4EeMsdhJZEgEGCy1OtLEs7XLg+kLWDUrJ4cpm6eB0DZqde8MgksSiItSkuG4AsFZy03j0HEsLI52IV9O8e3Z+T6KugSzrOEe4M4sew/L5+AlrsKpUNcAp7mAAz69xRVL0mdf/J/QDr9NWkllkHg0egFwsufvnCy26uXDMKv984nRph9qQi2XbOHPwC/vWJ0XIi3BYjRZZlpnnokhLVgal46+1OPoX/vAcjV07Z7QQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199021)(66946007)(66476007)(31696002)(66556008)(6666004)(2616005)(4326008)(316002)(86362001)(31686004)(2906002)(44832011)(26005)(83380400001)(6506007)(6512007)(54906003)(6486002)(53546011)(41300700001)(5660300002)(38100700002)(8676002)(8936002)(478600001)(36756003)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S01mN2NEZHZGdnNTYXpIZEIzN0Y3QmI3SGxIcU5RY1NtU0E5bnA5R2pHWnRs?= =?utf-8?B?RnRQNmI3VU53bE05VUtXRzFRU1B0N0UvOGh2ZUFFRzRNcFY2RUVodWZqSFd1?= =?utf-8?B?Lzh4cDNaRHJBc095bWpyTThYNnE5SkRPbm1MbVBmejdRZ3NzQk1FVDhWSW1E?= =?utf-8?B?eVRaL1FIRGt4ME5SbFUzc09LWk9ZN0xkNWJLdE0yUWRUeWwvc2FJeXU1N1Va?= =?utf-8?B?RVpva0ZYQlZvY2NNNVh1NE1LUnNHbDM3T00rWDVjUWk3dUFHOW5wWEVIdVhv?= =?utf-8?B?RE52b2xUK2twTlJXSTYvNmIrQWdlNDJ0bE42UkMxYlEvVWlKd3J0aEhRMGxO?= =?utf-8?B?azlYVXl3RFRBcFlNb0pvSklRQk9JM0tjbnlZV3pJNG0wZ1NYY2wwbTBBRFBl?= =?utf-8?B?MmRhUUNEWnM3OG9GUmVWdktpUkVkVFFMaWFpc3dnTjQwN255bHJtMEl4QmJx?= =?utf-8?B?NkpmZGs2RlBhTG10akthNTFZMVVwZUJodnlvVE1IODdQTk1RSWRYblMwUW4r?= =?utf-8?B?WTNxUUFkbjRQQnVKVWZSYTFjY2JOZkl3SjI2cnIwYTNKWm5TeWgrMGpOMnB5?= =?utf-8?B?TXQ4R0dxTEo3Y0laVUhHQmxEUkRVZzRuOHdqMXUrckxaVnJpRVBZTkdqNmZN?= =?utf-8?B?Wm5YUmhjZSsvWWhZTnM2dm5hQnFhUW1KR3l1NGpqODFSdnFycDg3ZTRKWTRt?= =?utf-8?B?MDR6NVBmUk9NTHhSTXpjdzBrK2dwRklGWjNHN3RKRmdWcGw5K1dpNTZmZzBT?= =?utf-8?B?TW5neFBaQjdHa29PMldzZzh3bzFwZE13Q3Z3Y2ovK0hVdFdFRG9oRWNLUGN4?= =?utf-8?B?b0ZuOG9YYitqbFAwLzBaQVBqM3p2VWJld2J6MTB0TkNlVGNOMkV0MGc5M1hO?= =?utf-8?B?eWo4dHRGbG1wZ2cvVUJWS0tuSU5rbW0zUi9aOWZJdEhjOTRwTDF5ZU9DSDBz?= =?utf-8?B?SitMYTM0cXU0bUU1RmxKOHVSMzdWUEVQc1JFNWdPZmx2bTRYQUJQWlVDVHE2?= =?utf-8?B?ZjJENHNFRVNaeVEvNFQ3VnljWk8yMFptM1N1OE11eVd1bW1ZbjFMdFhWWkMr?= =?utf-8?B?ZDViclNmeTUyYnRkK3orVGQ3akZnS3d5dFdWODZ3OHoySnFOTWxsbXBna3g0?= =?utf-8?B?bytLQU52ZkhOaWVXTk4vaUFMcFJvS01ibWhhMXAydW16QUZ3djJ6MmpUcVh4?= =?utf-8?B?Rm9yWGtsMnlvV2hTc0ZjdGFMK243enBKN256WHZ0UWQ1M3l2bDIyQ0RldlVB?= =?utf-8?B?NGJ0cm1lMk5aSVRiVnE2N3Zzd2QwN3ZETlBma2tiLzZHZDBLVVhCWWJWeERT?= =?utf-8?B?anJ6d3Q5M2h4K2RWdXJaWGxjRU54VTczU3lWakZYWEdqWHpTZHV2QlhLbks3?= =?utf-8?B?ZXZ6Ym1WQTBzVDZTWXRvM3ZRVnFTQWl6ZmdjVnprUU8yaGtXQzJiM2ZBb0M1?= =?utf-8?B?ME9WMEJvZVBDT3pTYngwa25raXlZOVF5eTdvRVZrUk1FOVFhbG9ON3M1MHF4?= =?utf-8?B?V1J2dFNNbW9FamczS1kwRDU2dUpSR3ljc05ZWlFtMkllYTljNVdDdDNrWEJq?= =?utf-8?B?WnhLUkVzVjgydGh4WloyN1RnaVZobXU3QlRoSE9mdms4SmtXY0xERDVSdHFN?= =?utf-8?B?OWdYeS8xTThwL3ZBS1lUM3NXYk1Oakpyd3daTVhKRFgvYnltSkZSNG0zK25O?= =?utf-8?B?VVhidFhFL0VreUlrRmw3NHQzaDU5ZzQvWkJkY0NvL0ZBajNnMlc4Z0IrS3Mz?= =?utf-8?B?K2FDeDVnOGNxMWwzRDN4UW12YUIxRTI0MnEyMzgrS1RnSUx3RjkyeDFMdytO?= =?utf-8?B?L2hRWW5LUkdNeVpWQ0NHbGJBQUpXNkhCamwwMUYyK2EzNSsyZE5FdzJ0ZGgw?= =?utf-8?B?L0hNdzZzNVNMSEd2Uk1WNGFISHdGSzNuSkhLNkdPMkliTGNYTno3RStxeHMr?= =?utf-8?B?THhuTlVVT0U4eWlzUU1WeHJ0UEJiSGkyOTZrY2o1OFcxdlU1dkVkSWlxckxr?= =?utf-8?B?d29Va2lpM0dtdGtpQlBZY01ZOEFEczdmMFZrYmNTVXM0U3AxOTczTFpZaXR5?= =?utf-8?B?MUhZdmxGM0h4c1lEem0rdjQwZ1RENjM5eGVmZDYyenBUMUhST3hYcU5Nb2cw?= =?utf-8?Q?dWANh27zfVMyM5ijQMU/yEas9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ab70b68-09c2-4c51-e55f-08db62b79fb9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 15:48:20.6385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mvlQabKHql2sGOzM2h7A51+Mtw5Yy6l4ogUTNd1yJMRFJhA8qPGB+tZ6Y6Gy9OC2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4323 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/2023 7:30 AM, Artemii Morozov wrote: > If the prefix for the rss hash was not chosen the > ENOTSUP error should be returned. > > Signed-off-by: Artemii Morozov > Reviewed-by: Andy Moreton > --- > v2: don't use capital letters in email > > drivers/common/sfc_efx/base/efx_rx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c > index 68f42f5cac..61726a9f0b 100644 > --- a/drivers/common/sfc_efx/base/efx_rx.c > +++ b/drivers/common/sfc_efx/base/efx_rx.c > @@ -937,8 +937,10 @@ efx_rx_qcreate_internal( > > rss_hash_field = > &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; > - if (rss_hash_field->erpfi_width_bits == 0) > + if (rss_hash_field->erpfi_width_bits == 0) { > + rc = ENOTSUP; > goto fail5; > + } > } > > enp->en_rx_qcount++; This is fixing return code of the function, right? Before update success was returned at this point event it failed. If so, can you please update commit log as fix commit and add proper fixes tags?