From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 054EDA0A0A; Thu, 20 May 2021 12:18:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72C1940143; Thu, 20 May 2021 12:18:37 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id D158340041 for ; Thu, 20 May 2021 12:18:35 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 608095C01C9; Thu, 20 May 2021 06:18:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 20 May 2021 06:18:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= ZqEXAZwPbNNXyd9H5p/UZcdFWXKt8aNrQMb509b8KVQ=; b=lhgJGCF0Cq5VAu/X e5PcvyU16w+6yB4mCSXtqfSxgqH01oaDLfHmYWQZhaM+7hI3gtBGSC9QRwGtbQ1X lpIyf9+JCrs14SwjJUWQz9Vtz7AZD6skQO2I0ujt0zc1VoL/A+BlR13iRoW2pdrd zTxH1B4TcOoWx/k+JZWSPE1lNWRFyDGDyTxT9WKlzpJPhWWNF3P6mbOhZaNUbi/l pmtIvI28+sJoaWCEUGexScwldWV4OEQLT1lneK5XLEjM73+SsqtDOlH6HDD1N42E 0q1VxPcw6wiAHtRysxgcQrCAmdgQqBMBan6J9XmG+xfB6+X+2pAAFO7qyEtNLuz9 TRHdHw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZqEXAZwPbNNXyd9H5p/UZcdFWXKt8aNrQMb509b8K VQ=; b=cxWgGpVL/SOmysORZahWezVhAOrhOC9+t+ToD/sx7GCm7+IA6xnmDK8BG 8SRKW+wZus2V4uwIFjdEPEBNXmezivCyejbtYcC7pQ77KGrDiJFB3+YNV0VkN86o CjXjerr4rcv3b3uv57kjwd77aZbfxbfRN2IC4Osf5wj0UW96FiJpe8n4IFWMbMDW C3kIBt7p5WQqt7jFFZRGqygLN6upiEAyP87PFrzu8Mvz4yAyDQSrhtgBMWnCBDIE gKODVbqvzzliFQRDc+R0S5kpkv530ME8hvE45iauELtC1EKpuzF4QtcIkjnVq3SU 4kXuicUYpxfwj+ozUjhEI8j9K4nTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejuddgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 20 May 2021 06:18:34 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , "Yigit, Ferruh" Date: Thu, 20 May 2021 12:18:33 +0200 Message-ID: <2678038.gk5r4CYnPT@thomas> In-Reply-To: References: <20210520075837.30954-1-david.marchand@redhat.com> <7723733.VEPnZyPds5@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: warn about release notes updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/05/2021 11:59, David Marchand: > On Thu, May 20, 2021 at 11:47 AM Thomas Monjalon wrote: > > 20/05/2021 09:58, David Marchand: > > > + current_rn=${rel_notes_prefix}${major_version}_${minor_version}.rst > > > + > > > + ! grep -e '^--- a/'$rel_notes_prefix -e '^+++ b/'$rel_notes_prefix $1 | > > > > Only the +++ part should matters. > > It won't catch accidental removals. Ah yes > Besides, something that is not handled with my patch is renames. I think we don't care about renames. > But if we think those cases would be caught by reviewers, I can > simplify this part in v2. Catching any change (including removal) in old release notes look fine.