From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 91C9B9396 for ; Mon, 7 Dec 2015 00:08:41 +0100 (CET) Received: by wmvv187 with SMTP id v187so142970090wmv.1 for ; Sun, 06 Dec 2015 15:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=vmzqF7pbiWvX58IQ8w/qniE14SkzsoNakYDzLterEaw=; b=njO1OedGXStu3oqNlbWySrOh6AVhN7JHQ4NvjEI84GySl4CCTrEbGrVVJSiQvDjSML 0/hJr62JRN6iWMfWtraEVYSIRFAnLFep/Z6rttZUVfCxXaf+XtDmN8KzYkc+L2WTgZ6C ch7QVhzeqoJd+1HaxwKFKXTAANMy55LoBCZDQOt6TUw6Yw3AMGU1r7j9n3mmRN3x+XrX kWW/g3aPvY3ezSCiPzXyi71Ajobbtd6hLmxZxIoFoyClwPSO8ckvaJ9BONxB2hCy0WtG 1JchbCBohZDE+aszNh/usTFOdwuKq8fFI9q1oSBeqv8yl6QGV8oWmikpKd4zt5eAqp4S lv9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vmzqF7pbiWvX58IQ8w/qniE14SkzsoNakYDzLterEaw=; b=LX3NwzKmuf1Vus4gJLB38hGe3NWjAqdamjyQA1M/dLsBTiCcSPM8jPcfSRmGYRUFbW CEiUoujPHnERvQYzDfbeL7x9t1ACyITR5IG+jjmF23rGNacU5BHfGq7sGZVfKPFi4YQk ScqRwm56rtE15JoFSdAEJ0DV/3t/mklZyFtk/z8zI/Ffh1f27AYGGzfL/KpWgJyZfnrV 3qqQgD6H48c/QlVo1xVrwhZoJJSYy6IjMWsVul422dllmOXogeAFgTW74AY0jzAlpcHo Vot0GkFcVMw/WKnN4FwA7Gf4XutSoVwAvm95lsGXixgOBlHQMvyfXOJoqj+7OaAJreyy cHwA== X-Gm-Message-State: ALoCoQl94wU9/cyerzCvM0RslWsti7N6/dhyADmhX/oQXMiPRMFKrD09dHQAuOtidAqRz6HbB7vwNEMUHjX/bEWzVFurQicevg== X-Received: by 10.28.89.137 with SMTP id n131mr18395128wmb.9.1449443321472; Sun, 06 Dec 2015 15:08:41 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id t2sm16341869wmt.1.2015.12.06.15.08.40 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 06 Dec 2015 15:08:40 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen , Yuanhan Liu Date: Mon, 07 Dec 2015 00:07:28 +0100 Message-ID: <2679675.c6cKM9bBsr@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <565EF7E9.6080400@redhat.com> References: <1449027793-30975-1-git-send-email-yuanhan.liu@linux.intel.com> <1449027793-30975-2-git-send-email-yuanhan.liu@linux.intel.com> <565EF7E9.6080400@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2015 23:08:41 -0000 2015-12-02 15:53, Panu Matilainen: > This (and other changes in patch 2 breaks the librte_vhost ABI again, so > you'd need to at least add a deprecation note to 2.2 to be able to do it > in 2.3 at all according to the ABI policy. > > Perhaps a better option would be adding some padding to the structs now > for 2.2 since the vhost ABI is broken there anyway. That would at least > give a chance to keep it compatible from 2.2 to 2.3. Please could you point where the vhost ABI is broken in 2.2?