DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Lingyu Liu <lingyu.liu@intel.com>,
	dev@dpdk.org, qi.z.zhang@intel.com, beilei.xing@intel.com
Cc: "Cao, Yahui" <yahui.cao@intel.com>
Subject: Re: [PATCH v4] doc: add iavf live migration guide
Date: Tue, 11 Jul 2023 21:54:18 +0200	[thread overview]
Message-ID: <2681155.PIDvDuAF1L@thomas> (raw)
In-Reply-To: <88200a75-fe01-2d31-1d20-bacaa030468f@intel.com>

Hello,

I don't pull this patch in -rc3 because I feel some improvements should be done.


> On 7/7/2023 2:08 PM, Lingyu Liu wrote:
> > +        echo 2 > /sys/bus/pci/devices/0000:ca:00.1/sriov_numvfs
> > +        echo "8086 1889" > /sys/bus/pci/drivers/ice-vfio-pci/new_id
> > +        echo 0000:ca:11.0 > /sys/bus/pci/devices/0000:ca:11.0/driver/unbind
> > +        echo 0000:ca:11.0 > /sys/bus/pci/drivers/ice-vfio-pci/bind
> > +        echo 0000:ca:11.1 > /sys/bus/pci/devices/0000:ca:11.1/driver/unbind
> > +        echo 0000:ca:11.1 > /sys/bus/pci/drivers/ice-vfio-pci/bind

Why not using dpdk-devbind.py?

> > +
> > +    .. note::
> > +
> > +        The command above creates two vfs for device 0000:ca:00.1:

vfs should be VFs

> > +
> > +    .. code-block:: console
> > +
> > +        0000:ca:11.0 'Ethernet Adaptive Virtual Function 1889' if= drv=ice-vfio-pci unused=iavf
> > +        0000:ca:11.1 'Ethernet Adaptive Virtual Function 1889' if= drv=ice-vfio-pci unused=iavf
> > +
> > +#.  Now, start the migration source Virtual Machine by running the following command:
> > +
> > +    .. code-block:: console
> > +
> > +        qemu/build/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -cpu host -m 4G -smp 1 -device vfio-pci,host=0000:ca:11.0,x-enable-migration=true,x-pre-copy-dirty-page-tracking=off -drive file=ubuntu-2004.qcow2 -nic user,hostfwd=tcp::5555-:22 -monitor stdio

No need the full qemu command with your local details here.


> > --- a/doc/guides/rel_notes/release_23_07.rst
> > +++ b/doc/guides/rel_notes/release_23_07.rst
> > @@ -200,6 +200,9 @@ New Features
> >   
> >     Enhanced the GRO library to support TCP packets over IPv6 network.
> >   
> > +* **Updated Intel iavf driver.**
> > +
> > +  Added the document for iavf driver live migration based on KVM vfio migration.

Not sure about the importance of this note.



  parent reply	other threads:[~2023-07-11 19:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03  5:14 [PATCH] doc: add ice VF " Lingyu Liu
2023-07-04  2:27 ` [PATCH V2] doc: add iavf " Lingyu Liu
2023-07-04  5:01   ` Cao, Yahui
2023-07-06  7:24   ` [PATCH v3] " Lingyu Liu
2023-07-07  6:08     ` [PATCH v4] " Lingyu Liu
2023-07-07  6:21       ` Cao, Yahui
2023-07-07  6:41         ` Zhang, Qi Z
2023-07-11 19:54         ` Thomas Monjalon [this message]
2023-07-27  8:34           ` Liu, Lingyu
2023-07-27 10:42             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2681155.PIDvDuAF1L@thomas \
    --to=thomas@monjalon.net \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=lingyu.liu@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=yahui.cao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).