From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C6D7E91BF for ; Mon, 20 Jun 2016 10:50:39 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id v199so59546441wmv.0 for ; Mon, 20 Jun 2016 01:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=9mKtFx06Tl5fAZ5n5Z4idRUUC59PcgCFOG+qc8Ae6BE=; b=JiprZGLHNaDdR2LJkHCD1p1jXzOU4q/DFZFJ7GNt+pDoKRta/xiRWH4iR2roL7Nj43 empXDTjqnRk7sINTp0dYg+trUrBKsjXJ1zDpS6EEozSvSAL53N+tg8fAzzE7ZfAXG34g Y4O/0O1aDiwE9h8kn4+bCo+BKYbSEmyB0u0n3qiQbQct7Qc5rHXNkmu7WuKPWXdrEHfU oF8x32BkQLpqvhTdRTS2o08fEhNCLuU4TeybO+7u1L+WdNXjXl1UrQT4WyAURFSuexZ/ 31pN4wCn42QbF7cenZ8tApy81D2cRSf0hFS4+LArVlUo9UOuL2Onb1dxNkd/2Kn+81Zv uZ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=9mKtFx06Tl5fAZ5n5Z4idRUUC59PcgCFOG+qc8Ae6BE=; b=ZHxBDYRXmjI2pybgRZyVT9agcBAvhxe9QT6KvQ3bj6x2ZvVHnL/NnX58IfDqBJS3xO DO0EmX9bF1FEEPDhhjqozk+XsZUd/JTTc68fU0cVWTkJfFWj1C3fW1CcKplGuMaRBdZI aNdsDp+rtyh33LFmgjP7kTp6Z/Tl1pw9Y1ogNFuASCsHUfMXaDvOJC4vV3HSNM++Hgi8 TFDviymnADKY8zi2wUixz5xRaXkMl6ZD0mLSeQn0WCjP4h1mGUml6i9yD+9p6XP/rmfQ gVfSfajfKDdtO7gepF/uUF+/GL4sBOfuYVvRxiIf4Fnr7edMnZR1vuoEUECWE0rJHHMs r3CA== X-Gm-Message-State: ALyK8tKUOk8PnlBVhgy5VO/zGY/YgQEnqX9WYoQfNL0caEOzqNEiqarRfaWe5Uodh8cOUEL3 X-Received: by 10.28.27.212 with SMTP id b203mr9895735wmb.19.1466412634706; Mon, 20 Jun 2016 01:50:34 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o10sm62412895wjz.37.2016.06.20.01.50.33 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2016 01:50:33 -0700 (PDT) From: Thomas Monjalon To: Tetsuya Mukawa Cc: David Marchand , dev@dpdk.org, "Mcnamara, John" , michalx.k.jastrzebski@intel.com Date: Mon, 20 Jun 2016 10:50:33 +0200 Message-ID: <2683003.3TnX10CuWW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1465961172-28253-1-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 08:50:39 -0000 2016-06-20 11:19, Tetsuya Mukawa: > On 2016/06/17 21:28, David Marchand wrote: > > On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa wrote: > >> This patch fixes resource leak of pci_uio_map_secondary(). > >> If pci_map_resource() succeeds but mapped address is different from an > >> address primary process mapped, this should be error. > >> Then the addresses secondary process mapped should be freed. > >> > >> Signed-off-by: Tetsuya Mukawa > > > > scripts/check-git-log.sh is not happy : > > > > Wrong headline uppercase: > > eal: Fix resource leak while secondary process maps pci devices > > Wrong headline lowercase: > > eal: Fix resource leak while secondary process maps pci devices > > Headline too long: > > eal: Fix resource leak while secondary process maps pci devices > > Missing 'Fixes' tag: > > eal: Fix resource leak while secondary process maps pci devices > > > > > > checkpatch is not happy, but I think we can ignore it. > > > > WARNING:LONG_LINE: line over 80 characters > > #48: FILE: lib/librte_eal/common/eal_common_pci_uio.c:93: > > + (size_t)uio_res->maps[j].size); > > > > > > Anyways, looks good to me, Thomas, can you fix the commit logs of > > those last 3 patches on eal ? > > Thanks. > > > > Hi David, > > I appreciate your checking. > Next time I will check check-git-log.sh before submitting. > > > Hi Thomas, > > Could you please let me know if you need the fixed patches. Applied, thanks