From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 297403230 for ; Thu, 26 Jul 2018 16:12:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0D2DE21EF9; Thu, 26 Jul 2018 10:12:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 10:12:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=lFWEv5o5H9N87wxoFoVs6J5Hq0 +NdjGEcCfNE6Joho0=; b=Y8epDnpEVClrpcS95lXi8KL7ZMNlhmoYnODCOHoQWP Ivjh8kUiAUZl3b3ApFzKYL0yovG1qgHOtuUyN4GqU8p2XN/iyWNSb/U1sdDLkGJq z2m1ow7QO1AV1s2dZ7m5C03rx6t+gAUFl/CxsiR/bIzMVodVX6Xx9p/HgUg9LrqA E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lFWEv5 o5H9N87wxoFoVs6J5Hq0+NdjGEcCfNE6Joho0=; b=WHjRmh9SMNb8XMA+PZzeAB 8Jz0HWCoC3G8Q/nhU3zaCpkVmIsadFvA046Uw+kltPHTRM2jlSxX5ry2z25fYMam OAmWP6HcpGA1tGA7Zgq1lvJdAWw6W2ykGxc4zeGXMFLSIHbAioSMxnHfkBYUG2Lo rzybIDNQfMRBo1CFEH39RNsqbWj/nacmwdglSYF/jCaPi7KdJ+31BG3d0XDXhCc/ TpX2aoZkEj6Au9vxws/Y7DpVGB5NeTPDE6KRmzD/AG7D4mI6CmD4jtkSfvZe7IJO PIlt5VvFmGpBx1E9XIYqdXDRX9JEX1l8iZnWw1ut/SyGEj5WA0BjIQmv9u1ejazA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6279310273; Thu, 26 Jul 2018 10:12:56 -0400 (EDT) From: Thomas Monjalon To: Moti Haimovsky Cc: Aaron Conole , jasvinder.singh@intel.com, dev@dpdk.org, Bala Sankaran , Reshma Pattan , cristian.dumitrescu@intel.com Date: Thu, 26 Jul 2018 16:12:51 +0200 Message-ID: <2684917.syDUeKYqy4@xps> In-Reply-To: References: <1532529621-5171-1-git-send-email-motih@mellanox.com> <1532532609-16216-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: removed softnic CLI modifications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 14:12:59 -0000 25/07/2018 22:27, Aaron Conole: > Moti Haimovsky writes: > > > This patch reverts the testpmd CLI prompt routine modifications done > > in order to support softnic. > > The reason of doing so is due to testpmd abnormal exit observed on > > several setups caused by the softnic modifications to this routine, > > for example: When running testpmd with tap interface > > (/app/testpmd > > -n 4 --vdev=net_tap0,iface=tap0,remote=eth1 -- --burst=64 > > --mbcache=512 -i --nb-cores=7 --rxq=2 --txq=2 --txd=512 > > --rxd=512 --port-topology=chained --forward-mode=rxonly) > > testpmd crashes seconds after presenting its prompt with the following > > error: > > testpmd> PANIC in prompt(): > > CLI poll error (-1) > > > > Thread 1 "testpmd" received signal SIGABRT, Aborted. > > 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6 > > (gdb) bt > > #0 0x00007ffff668e0d0 in raise () from /lib64/libc.so.6 > > #1 0x00007ffff668f6b1 in abort () from /lib64/libc.so.6 > > #2 0x0000000000468027 in __rte_panic () > > #3 0x00000000004876ed in prompt () > > #4 0x000000000046dffc in main () > > > > When running testpmd with bare-metal device > > (app/testpmd -n 4 --socket-mem=1024,1024 -w 04:00.0 -- > > --burst=64 --mbcache=512 -i --nb-cores=7 > > --rxq=64 --txq=4 --txd=16 --rxd=16) > > and pressing CTRL+D right after testpmd prompt is presented then > > the program crashes while presenting the same messages as above. > > > > Needless to say that this behavior is not observed when using the > > previous CLI prompt routine. > > > > Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") > > Cc: stable@dpdk.org Removing stable for this fix. > > Signed-off-by: Moti Haimovsky > > --- > > Thanks for the fix - I was just writing to explain that I observe this > on master but see that folks are busy fixing it up. > > I've applied this patch, and no longer see the panic. > > Acked-by: Aaron Conole Applied, thanks