From: Thomas Monjalon <thomas@monjalon.net>
To: "Kozak, KubaX" <kubax.kozak@intel.com>
Cc: "Yang, Zhiyong" <zhiyong.yang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
dev@dpdk.org, "Jastrzebski,
MichalX K" <michalx.k.jastrzebski@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked return value
Date: Sat, 14 Oct 2017 00:43:32 +0200 [thread overview]
Message-ID: <2686354.ZEoe3kJYJj@xps> (raw)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF2A3D6@BGSMSX101.gar.corp.intel.com>
11/10/2017 09:07, Yang, Zhiyong:
> Hi Kuba,
>
> Just a soft reminder. :)
> Maintainers will make the decision.
>
> Ferruh, Thomas,
>
> Your opinion?
No need to re-send.
More comments:
- do not top reply
- title should start with examples/
- use --in-reply-to when sending a new version
Thanks
> > -----Original Message-----
> > From: Kozak, KubaX
> > Sent: Wednesday, October 11, 2017 2:58 PM
> > To: Yang, Zhiyong <zhiyong.yang@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Jastrzebski, MichalX K
> > <michalx.k.jastrzebski@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> >
> > Thanks Zhiyong,
> >
> > Should I correct this patch and resend to dpdk or is it just a suggestion for future?
> >
> > Regards,
> > Kuba
> >
> > >-----Original Message-----
> > >From: Yang, Zhiyong
> > >Sent: Tuesday, October 10, 2017 08:56
> > >To: Kozak, KubaX <kubax.kozak@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > >Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>; stable@dpdk.org
> > >Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >
> > >Hi，kubax,
> > >
> > >When you form the patch , you should add v2 and changes in v2.
> > >Besides that, please be free to add
> > >Acked-by: zhiyong yang<zhiyong.yang@intel.com>
> > >
> > >Thanks
> > >Zhiyong
> > >
> > >> -----Original Message-----
> > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> > >> Sent: Tuesday, October 3, 2017 7:48 PM
> > >> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > >> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>;
> > stable@dpdk.org
> > >> Subject: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >>
> > >> Add return value check and error handling for fseek call.
> > >>
> > >> Coverity issue: 143435
> > >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
> > >> Cc: konstantin.ananyev@intel.com
> > >> Cc: stable@dpdk.org
> > >>
> > >> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> > >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > >> ---
>
next prev parent reply other threads:[~2017-10-13 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 11:48 [dpdk-dev] " Kuba Kozak
2017-10-10 6:55 ` Yang, Zhiyong
2017-10-11 6:58 ` Kozak, KubaX
2017-10-11 7:07 ` Yang, Zhiyong
2017-10-13 22:43 ` Thomas Monjalon [this message]
2017-10-13 22:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2686354.ZEoe3kJYJj@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=kubax.kozak@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).