From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0AC201B6FF for ; Sat, 14 Oct 2017 00:43:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ABE2A20744; Fri, 13 Oct 2017 18:43:33 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 18:43:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=TYQ3+YEh0yvve1MPxlyFiQUfp6 zCPHIwLU9o8OSkosI=; b=n+41Q3Ooj2gSfvk+holtn76PG4HXqyvFtg/0lBzkp1 HawUJ8nC0fy/hgBzbkDAPXJVv81IGpBNcLAz53T1OqtCuMvOc4QQQnjDQN0br8R6 oy4BPaKOUlMPPfUZm51tAnLGuenoFlGy6nK6ZRbkWf2uTQCC08aImkaxg/sPw9Z8 s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TYQ3+Y Eh0yvve1MPxlyFiQUfp6zCPHIwLU9o8OSkosI=; b=GCJwa2XeIl3Q5NFDOyCnLA YErsktekWK0Cr+pn64OO3gRKrXjH9o5pbWyfVfGIO5afJ+PkMnSFi2UzF+wvGm2f msMbRHLSsghJJ2UhKXm2k+8ya81TFtqnbQz9jy8jm85tbJkLrobSA9wmdF10y05+ p+ni1s7J6kqwoYIossn8ryzCWFyuxMFROeimjLjvX7AVrFEN4AsHYWNKAcKEVYlk Babf9UdKsfMuAwK9ra/mOwPekNJAz2VigNIrBnfgB9Sf+vVS2mkgRHLNUu44Km69 djw0LNwtDyjmKsy/supX5U9076Sm0JHiW7U1iVmz+b9OwSwJUKSKDlOShfxfMBEA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 547CB247A8; Fri, 13 Oct 2017 18:43:33 -0400 (EDT) From: Thomas Monjalon To: "Kozak, KubaX" Cc: "Yang, Zhiyong" , "Ananyev, Konstantin" , dev@dpdk.org, "Jastrzebski, MichalX K" , "Yigit, Ferruh" Date: Sat, 14 Oct 2017 00:43:32 +0200 Message-ID: <2686354.ZEoe3kJYJj@xps> In-Reply-To: References: <1507031282-12469-1-git-send-email-kubax.kozak@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 22:43:34 -0000 11/10/2017 09:07, Yang, Zhiyong: > Hi Kuba, >=20 > Just a soft reminder. :)=20 > Maintainers will make the decision. >=20 > Ferruh, Thomas, >=20 > Your opinion? No need to re-send. More comments: =2D do not top reply =2D title should start with examples/ =2D use --in-reply-to when sending a new version Thanks > > -----Original Message----- > > From: Kozak, KubaX > > Sent: Wednesday, October 11, 2017 2:58 PM > > To: Yang, Zhiyong ; Ananyev, Konstantin > > > > Cc: dev@dpdk.org; stable@dpdk.org; Jastrzebski, MichalX K > > > > Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value > >=20 > > Thanks Zhiyong, > >=20 > > Should I correct this patch and resend to dpdk or is it just a suggesti= on for future? > >=20 > > Regards, > > Kuba > >=20 > > >-----Original Message----- > > >From: Yang, Zhiyong > > >Sent: Tuesday, October 10, 2017 08:56 > > >To: Kozak, KubaX ; Ananyev, Konstantin > > > > >Cc: dev@dpdk.org; Kozak, KubaX ; stable@dpdk.org > > >Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value > > > > > >Hi=EF=BC=8Ckubax, > > > > > >When you form the patch , you should add v2 and changes in v2. > > >Besides that, please be free to add > > >Acked-by: zhiyong yang > > > > > >Thanks > > >Zhiyong > > > > > >> -----Original Message----- > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak > > >> Sent: Tuesday, October 3, 2017 7:48 PM > > >> To: Ananyev, Konstantin > > >> Cc: dev@dpdk.org; Kozak, KubaX ; > > stable@dpdk.org > > >> Subject: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value > > >> > > >> Add return value check and error handling for fseek call. > > >> > > >> Coverity issue: 143435 > > >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") > > >> Cc: konstantin.ananyev@intel.com > > >> Cc: stable@dpdk.org > > >> > > >> Signed-off-by: Kuba Kozak > > >> Acked-by: Konstantin Ananyev > > >> --- >=20