From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C402AA0542; Wed, 15 Jul 2020 19:32:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 303604C8A; Wed, 15 Jul 2020 19:32:42 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 644DB3421 for ; Wed, 15 Jul 2020 19:32:41 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 95C175810F6; Wed, 15 Jul 2020 13:32:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 15 Jul 2020 13:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 25WY+97H3eRTrPPqD5Hl9WQicl5mo0E/m7MkomxjV0I=; b=YEwLOG6u2PgKpCIF RlQFQEwt3ec4KS4ceAsOAuIeyaAhGRQSF+cfMBc9uQX1AsbxeXx4dma94UtwNFby ckjwZn6A/x6wPkneJy4okN1Ht64iATdhE7OPCO22QSymZYBTmObm1pS2h15bKNed Irh7qdX6BR9Q/BajHY37KuCAs1jARVhtqmP+FQOOYziXHhWRdbXQjCTkh3DsKH6H BRMvMJ7mvPh4SVrip7BJTkSVff28MzGZBmew89q3xJV5jbq8xsal6n0BqzETnSMp 6lKto2987as9CfnjZkkVj3qhIFGmayyx4KHgy/E99PKwslMph9mPGSecHBVPJg1h D9WkPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=25WY+97H3eRTrPPqD5Hl9WQicl5mo0E/m7MkomxjV 0I=; b=TwKDChvG2hAett0KhKO0Ek2PTu3trW3wK/h4RNDTAmkfUbw3F4aLC6Wvn UdPTrgaw2O9WVcqGaTcgvvpucDYriHZvka+3U4tLSrHE45rrMiAUhK8AMiKNxBIG 9ply20A+9M8U4MuZU4UV+jzBF4FxTZeuGQAaw7f6Ps5hLKrO6xDNQE7arLVSsUdn qvdmhVq3HUXjLIsHMBx44ULxwIBBLPzBL4PwDpXsvkym7BX/w8l22y5jWj2+pbgE C7IXOCBF6fKXDznyFkJrUNoFWLl5efSE4N3UIoxOACpxNKzoeLYXun2VNovdxld5 sz98dpBW3bw4NS1vPioP9a/JQmkSQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedvgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C315130600A3; Wed, 15 Jul 2020 13:32:31 -0400 (EDT) From: Thomas Monjalon To: Ori Kam Cc: jerinj@marvell.com, xiang.w.wang@intel.com, matan@mellanox.com, viacheslavo@mellanox.com, dev@dpdk.org, guyk@marvell.com, dev@dpdk.org, pbhagavatula@marvell.com, shahafs@mellanox.com, hemant.agrawal@nxp.com, opher@mellanox.com, alexr@mellanox.com, dovrat@marvell.com, pkapoor@marvell.com, nipun.gupta@nxp.com, bruce.richardson@intel.com, yang.a.hong@intel.com, harry.chang@intel.com, gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn, zhangy.yun@chinatelecom.cn, lixingfu@huachentel.com, wushuai@inspur.com, yuyingxia@yxlink.com, fanchenggang@sunyainfo.com, davidfgao@tencent.com, liuzhong1@chinaunicom.cn, zhaoyong11@huawei.com, oc@yunify.com, jim@netgate.com, hongjun.ni@intel.com, deri@ntop.org, fc@napatech.com, arthur.su@lionic.com, rasland@mellanox.com, Yuval Avnery Date: Wed, 15 Jul 2020 19:32:30 +0200 Message-ID: <2687215.1nFKvS3G53@thomas> In-Reply-To: <1594587541-110442-3-git-send-email-orika@mellanox.com> References: <1593941027-86651-1-git-send-email-orika@mellanox.com> <1594587541-110442-1-git-send-email-orika@mellanox.com> <1594587541-110442-3-git-send-email-orika@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 02/20] regex/mlx5: add log utils X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/07/2020 22:58, Ori Kam: > From: Yuval Avnery > > Add the DRV_LOG macro which should be used for error prints. Should be MLX5_REGEX_LOG > +extern int mlx5_regex_logtype; > + > +#define MLX5_REGEX_LOG_PREFIX "regex_mlx5" > +/* Generic printf()-like logging macro with automatic line feed. */ > +#define DRV_LOG(level, ...) \ > + PMD_DRV_LOG_(level, mlx5_regex_logtype, MLX5_REGEX_LOG_PREFIX, \ > + __VA_ARGS__ PMD_DRV_LOG_STRIP PMD_DRV_LOG_OPAREN, \ > + PMD_DRV_LOG_CPAREN) Was it tested? I don't see where the log type is registered. Please use RTE_LOG_REGISTER