From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of link info, and remove an useless function
Date: Fri, 20 Jun 2014 16:28:34 +0200 [thread overview]
Message-ID: <2688891.cpSxDN6sGo@xps13> (raw)
In-Reply-To: <1403244889-21358-7-git-send-email-helin.zhang@intel.com>
2014-06-20 14:14, Helin Zhang:
> Delete the inline function which is not used at this moment.
> Fix the bug of copying wrong size of link info in function of
> i40evf_get_link_status().
There are 2 patches here. Please split.
> static inline int
> -i40evf_dev_atomic_read_link_status(struct rte_eth_dev *dev,
> - struct rte_eth_link *link)
> -{
> - struct rte_eth_link *dst = link;
> - struct rte_eth_link *src = &(dev->data->dev_link);
> -
> - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> - *(uint64_t *)src) == 0)
> - return -1;
> -
> - return 0;
> -}
Not directly related to this patch, but it could be a good idea to start
using rte_eth_dev_atomic_read_link_status() instead of copying this function
in each PMD.
--
Thomas
next prev parent reply other threads:[~2014-06-20 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 6:14 [dpdk-dev] [PATCH 0/7] enhancements for i40e Helin Zhang
2014-06-20 6:14 ` [dpdk-dev] [PATCH 1/7] i40e: fix for getting correct RSS hash result Helin Zhang
2014-06-20 6:14 ` [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping hw offload Helin Zhang
2014-06-20 14:08 ` Thomas Monjalon
2014-06-23 2:29 ` Zhang, Helin
2014-06-20 6:14 ` [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating default filter settings Helin Zhang
2014-06-20 14:16 ` Thomas Monjalon
2014-06-23 2:21 ` Zhang, Helin
2014-06-20 6:14 ` [dpdk-dev] [PATCH 4/7] i40e: fix for updating the hash lookup table of PF RSS Helin Zhang
2014-06-20 6:14 ` [dpdk-dev] [PATCH 5/7] i40e: double vlan should be specifically disabled by default Helin Zhang
2014-06-20 6:14 ` [dpdk-dev] [PATCH 6/7] i40evf: fix for copying wrong size of link info, and remove an useless function Helin Zhang
2014-06-20 14:28 ` Thomas Monjalon [this message]
2014-06-20 6:14 ` [dpdk-dev] [PATCH 7/7] app/testpmd: rework for displaying different size of RX descriptors Helin Zhang
2014-06-20 14:34 ` Thomas Monjalon
2014-06-23 1:38 ` Zhang, Helin
2014-06-20 6:23 ` [dpdk-dev] [PATCH 0/7] enhancements for i40e Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2688891.cpSxDN6sGo@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).