From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 37E852C16 for ; Thu, 3 Aug 2017 23:44:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C83DA20A47; Thu, 3 Aug 2017 17:44:05 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 17:44:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qjUg+2g1fSvWVy0 zSEmfo3DX+2eTBWY9ezm33PMV1oc=; b=Bolbeta8pYTG6rwBaMA6W7eakgNBPt7 60l+Nxih4S4cifd00DhHFF9WfQjuXJ41VbBPloS9nxtBRBiHcaRzEj6T8WYuAr/o eo+gsAuyAKsvvf1ix3TsHY0F2ZhgzNeMw2eY+sXwyxWUCNch1c2z1b5R7EA+IODb u1fQXOeiJMsI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qjUg+2g1fSvWVy0zSEmfo3DX+2eTBWY9ezm33PMV1oc=; b=bzDriloa wgnDk4ivH5ayznxbPD+sSfCvArd1c0bWukYOnh+welNFrh1TPihW8h3LZHn8c9f7 jwVpKPsG4xGOLqd7KD155jfDAY4nQXispLDjdB9sY9qxCpjBWFLU45wm96wvK0Qm B3K2BXPiAOrMjYqXpcYabMPYluTT0V/HH/FHrIgubCItcWRPo50BDJ7oWfoPzITS Cc+8jBsuCgJOskb6fcgsZpeqk0lqZLj1madjmtF/zFgDLOnLbyEa+uoDxtF/xgVm SjhZ8ILUhiQWH4MwJe3jW6EVKoGCm8MFNpUbCUr0ie5+73Y48FSdr0tlCWpu10Nv +UZp/7Y0XbzKGg== X-ME-Sender: X-Sasl-enc: ZgotUn56mREX7I68xMVPSvMt6e3Ugd+eQQPOOoGFGz30 1501796645 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C27A7F356; Thu, 3 Aug 2017 17:44:05 -0400 (EDT) From: Thomas Monjalon To: "Hunt, David" Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Wu, Jingjing" Date: Thu, 03 Aug 2017 23:44:03 +0200 Message-ID: <2692805.uYAMR96KvV@xps> In-Reply-To: References: <1500978472-182803-1-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix Tx first with LSC interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 21:44:06 -0000 > > The lsc_interrupt flag is enabled by default, and when the --tx-first is used > > as a command line parameter, the 32 packets can be sent out before the > > link state is up, resulting in the loss of the packets, and no further > > forwarding will take place. > > > > E.g. ./build/app/testpmd -c f0 -- --tx-first --stats-period 1 > > > > When the --tx-first is used, the lsc_interrupt flag needs to be disabled, > > ensuring the links are up before forwarding traffic. Therefore, during the > > parameter checking at startup, if --tx-first is used, we now warn the user, > > and set lsc_interrupt to 0. > > > > Fixes: 99cabef08855 ("app/testpmd: add parameter to start forwarding Tx > > first") > > Signed-off-by: David Hunt > > Acked-by: Pablo de Lara Applied, thanks