From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 248FEA04E7; Thu, 5 Nov 2020 17:58:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90AD72BF5; Thu, 5 Nov 2020 17:58:50 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A86A12B89 for <dev@dpdk.org>; Thu, 5 Nov 2020 17:58:48 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id EB2005C00EF; Thu, 5 Nov 2020 11:58:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 05 Nov 2020 11:58:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ly9PiqYgmIGwSs+NbUIja+cGfxb+4ZJ/z87nY9pW3z0=; b=sT0sua0gpN5AkdpC Y5UjQXpFL3gf7AB8SAkAfsXO06PNe3CsEILu/2A3hKTIyaguVQma6Ym2RzZncxE1 c0Bf0C7DRz9SgpdaQ3/BWlnloePFFlzz+Ck5CE2LSBTX7UhCMgn2cXAgoY/sltwg B6uoK6HumdTVdCi3IWmsJ+xMXYeUQyCC5Fg5bwKe0WlOYVCo2QB50axgH07ZESP5 D2zuG82p+jvfUzWY5tIIYEvNraoUEwltCYgj1JJZaQQRwH1i4qzPqK2m/LNJb+b2 NeCMHCX74jOwgsV1dp0T6nFU2BAbW32/WlswFiCOjZ0719EWyQf8TckPpOVW2ise ACxgzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ly9PiqYgmIGwSs+NbUIja+cGfxb+4ZJ/z87nY9pW3 z0=; b=hLYCcWeuGhgR3u+qNBnP/YrSu1bgbwN1+MqQiYc9QpeIOVGGOviMEcG4O JQBbj9L6qFpIOwdXiuFZ9px0QvHa9TOV1eU5wpzaxN400ehXOrSg1YyVDjJ1j+er KBbTxwvOULAaBQeF5TPGC8PxmX+zdjLrjHDVFiUHhXY3tnw99zjld9apnGHEeiuL +jGnPWE9CLGm8bKdOL9caSv6VvYMHcwS7u2uDuRQoaEqhtjWjiJHxodqoKEFosjF rKaox4FLjhfSflabsh6y2FDoYMnbR4JJgc47OqiCC/hfBL7RkSKvG884aBZxNRYV V+eqW5LbbPruCqbuYLG8Z94f18WBQ== X-ME-Sender: <xms:Ri-kX5D1rbZaNag9ji8aaAZDoEBGl4JHAdeuGYnIRSa9E6H7Sm90Xw> <xme:Ri-kX3gKZ5sUwiEertGbhY_VenI2dmol9qWGs1BBhO3YVO0geVlHIv7VjmDL3o45A x7pmBGGvmB-rp55ag> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtjedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:Ri-kX0mdR2z6vMt0h8SKrctRI9C7jZG85Sfim2ZfU5jEPBf73Q2gUQ> <xmx:Ri-kXzz6_AN2v4Lu9OVe0SvLdf_pEB6lNjQOnq3p066ycDhvnFr7FA> <xmx:Ri-kX-Q3HO_5ubI2DsJW-6dGGDuvdxmYEmaz15vYyi5gvipJHqvfFw> <xmx:Ri-kX366xaoCUNCBE3bSKgyYXK45WZjP96Hg6z5DL-W4jKTzuXZa1g> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 99FF53280345; Thu, 5 Nov 2020 11:58:45 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com> Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com> Date: Thu, 05 Nov 2020 17:58:44 +0100 Message-ID: <2693408.MRr9Qu1Uht@thomas> In-Reply-To: <20201105133611.GU1898@platinum> References: <20200916081747.124520-2-mb@smartsharesystems.com> <20201026144201.54899-1-mb@smartsharesystems.com> <20201105133611.GU1898@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v4] mbuf: minor cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 05/11/2020 14:36, Olivier Matz: > On Mon, Oct 26, 2020 at 03:42:01PM +0100, Morten Br=F8rup wrote: > > The mbuf header files had some commenting style errors that affected the > > API documentation. > > Also, the RTE_ prefix was missing on a macro and a definition. > >=20 > > Note: This patch does not touch the offload and attachment flags that a= re > > also missing the RTE_ prefix. > >=20 > > Changes only affecting documentation: > > * Removed the MBUF_INVALID_PORT definition from rte_mbuf.h; it is > > already defined in rte_mbuf_core.h. > > This removal also reestablished the description of the > > rte_pktmbuf_reset() function. > > * Corrected the comment related to RTE_MBUF_MAX_NB_SEGS. > > * Corrected the comment related to PKT_TX_QINQ_PKT. > >=20 > > Changes regarding missing RTE_ prefix: > > * Converted the MBUF_RAW_ALLOC_CHECK() macro to an > > __rte_mbuf_raw_sanity_check() inline function. > > Added backwards compatible macro with the original name. > > * Renamed the MBUF_INVALID_PORT definition to RTE_MBUF_PORT_INVALID. > > Added backwards compatible definition with the original name. > >=20 > > v2: > > * Use RTE_MBUF_PORT_INVALID instead of MBUF_INVALID_PORT in rte_mbuf.c. > >=20 > > v3: > > * The functions/macros used in __rte_mbuf_raw_sanity_check() require > > RTE_ENABLE_ASSERT or RTE_LIBRTE_MBUF_DEBUG, or they don't use the mbuf > > parameter, which generates a compiler waning. So mark the mbuf parame= ter > > __rte_unused if none of them are defined. > >=20 > > v4: > > * Removed compile time variants of __rte_mbuf_raw_sanity_check(); keepi= ng > > the one variant where the mbuf parameter is marked __rte_unused. > > * Reflect in the __rte_mbuf_raw_sanity_check() description headline that > > it is for debug mode. > > * Improved the description of RTE_MBUF_PORT_INVALID. > > * Updated sfc driver to use __rte_mbuf_raw_sanity_check() instead of > > MBUF_RAW_ALLOC_CHECK(). > >=20 > > Signed-off-by: Morten Br=F8rup <mb@smartsharesystems.com> >=20 > Acked-by: Olivier Matz <olivier.matz@6wind.com> >=20 > Thanks! Applied, thanks