From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 383321B233 for ; Wed, 10 Jan 2018 21:54:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 12:54:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,342,1511856000"; d="scan'208";a="20587278" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga001.fm.intel.com with ESMTP; 10 Jan 2018 12:54:57 -0800 To: Stephen Hemminger , Thomas Monjalon Cc: dev@dpdk.org References: <20180105173855.25473-1-thomas@monjalon.net> <20180105124707.602256c5@xeon-e3> From: Ferruh Yigit Message-ID: <26941444-afde-3ec6-93f3-48e8d67ad7d5@intel.com> Date: Wed, 10 Jan 2018 20:54:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180105124707.602256c5@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix link autonegotiation value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 20:55:00 -0000 On 1/5/2018 8:47 PM, Stephen Hemminger wrote: > On Fri, 5 Jan 2018 18:38:55 +0100 > Thomas Monjalon wrote: > >> There are 3 kind of link data in ethdev: >> - capabilities (rte_eth_dev_info) >> - configuration (rte_eth_conf) >> - status (rte_eth_link) >> >> A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and >> configuration (rte_eth_conf.link_speeds). >> Bits are defined in ETH_LINK_SPEED_*. >> >> Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values >> are used for the link status (rte_eth_link.*). >> >> There was a mistake in the comment of rte_eth_link.link_autoneg, >> suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1, >> instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0. >> >> The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED]. >> >> Fixes: 82113036e4e5 ("ethdev: redesign link speed config") >> >> Suggested-by: Andrew Rybchenko >> Signed-off-by: Thomas Monjalon > > Thanks for clearing this up. > > Acked-by: Stephen Hemminger Applied to dpdk-next-net/master, thanks.