From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id C02772BD9 for ; Thu, 7 Apr 2016 19:18:23 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id n3so113757364wmn.0 for ; Thu, 07 Apr 2016 10:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=hi/6GQ6zjgMKm5SGzRvNwyELU1FdCNizuOCNwXN5wow=; b=OswKA5YUWNE+BbCrzSfIT39AnzgtRSVfXSy86z7uyeXMuAcQ3xfXzXFQsOZfyfWPCy EMAI2wHAR/Il4VkZCgODFIWeFCQ5tunlwAz1zYqXAcnQqskPRgd8oXAFsXvyv+vk4G2v 1/AffaQZQvG+kM1a6rKhcjIPaup7HJrhCtJnthsz8FcravXHHc67LZGMYsqK16WQ3erB m90enBWe2bEIhUavPiJKA4cye+u1CnUrwhgeN4xhWG14NdCl+98nCfKEIf/cPIr5ABwI sTLNAchTKzC8EivllbuE2zolzD/8AXqmvovw0pYXQFHbCYCzvYU6MKJODJjHqiRwt7mx XuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=hi/6GQ6zjgMKm5SGzRvNwyELU1FdCNizuOCNwXN5wow=; b=mR6av3Y+ktati2aGwzvaa1mjw1P8BtWS5/ILyIdsSDiLUaGcjSNSo07sGFC8TiwUuH vyIRz+X3Bf5j95CLVXVijEy9q/iSvLA+LYKOyvQgwSd8HBdTtBkzjd1MBVSpK6fPshnk tPWtOe+7krxBnt41jdffNKHYTFia7GIIj2pMSZET6HzhE6ov/yirjQSRA19YldQzYT9U 8C1t8pH5lvKiD3PFm57Tl1mpI0arIza7h/oaq5Z/TZDfdMSfdDfgW2YDD3cP7G4ML2JN ajSPa+vQMmMAFh9pkGJz80L8IR/BhpFE3TI7w3Kjh9yc4XOuQiTI0wbNXiVXPNcYS/zq pSZQ== X-Gm-Message-State: AD7BkJIPvOa/3uhs2eoavR4v1hak4jyHOIjWtKX+uzGDTQ7wNEvZj2MM1mRIC2wiobxXd8rv X-Received: by 10.194.92.107 with SMTP id cl11mr5277954wjb.21.1460049503647; Thu, 07 Apr 2016 10:18:23 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id c144sm31060587wmd.0.2016.04.07.10.18.22 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 07 Apr 2016 10:18:22 -0700 (PDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, david.verbeiren@intel.com Date: Thu, 07 Apr 2016 19:18:21 +0200 Message-ID: <2694753.mMpTndY4fj@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1460026800-24159-1-git-send-email-anatoly.burakov@intel.com> References: <1450564772-20000-1-git-send-email-david.verbeiren@intel.com> <1460026800-24159-1-git-send-email-anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ivshmem: avoid infinite loop when concatenating adjacent segments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2016 17:18:23 -0000 > This patch aligns the logic used to check for the presence of > adjacent segments in has_adjacent_segments() with the logic used > in cleanup_segments() when actually deciding to concatenate or > not a pair of segments. Additionally, adjacent segments are > no longer considered overlapping to avoid generating errors for > segments that can happily coexist together. > > This fixes an infinite loop that happened when segments where > adjacent in their physical or virtual addresses but not in their > ioremap addresses: has_adjacent_segments() reported the presence > of adjacent segments while cleanup_segments() was not considering > them for concatenation, resulting in an infinite loop since the > result of has_adjacent_segments() is used in the decision to > continue looping in cleanup_segments(). > > Signed-off-by: David Verbeiren > Signed-off-by: Anatoly Burakov Applied, thanks