From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id D4A839E7
 for <dev@dpdk.org>; Thu,  9 Jul 2015 01:36:56 +0200 (CEST)
Received: by wgov12 with SMTP id v12so24234128wgo.1
 for <dev@dpdk.org>; Wed, 08 Jul 2015 16:36:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=5XJLbSlnOQKElIQuOXNRUgR5FEJr+YNnjXQU4JAr/00=;
 b=nELBn5SAeIt/+KDO5rpFDT+JyWzc9jRaqED/dj9DC5SPiTxG8aOzpYmxUCm6iBpnRd
 eNKZF/WImfNUevpg/oz0HCEgascCYARF0tWIsEIZrVvvomjWPh/O9//HNdVGjhioVAID
 NxQaVdvCeaxdxiZ782cFDjcLaLfuNbHt4HsEstR7Y6UECFSt+28qtlXXUyALSwzJVAQ7
 VafiYuBNVzGZS+rJiIym1bSrLt86+D5kG51mz8zUoOPbDVVmVMkgPtFUzy5esj6UP8rq
 6foNFdkhGewOd87d9prHWUKAbryt1uWkQTSoS4ZKXAPeSPkvDNxoRWgs+xwhH7ku/ygE
 uW0A==
X-Gm-Message-State: ALoCoQktuDOqefzJbgMDAP4sAc6VuF9RqGcEkepALqvOp/K2sgN+46gPdwDs3A85F1bA4eoh9Erm
X-Received: by 10.194.109.167 with SMTP id ht7mr23657453wjb.60.1436398616754; 
 Wed, 08 Jul 2015 16:36:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id q4sm5782839wja.24.2015.07.08.16.36.55
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 08 Jul 2015 16:36:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Takuya ASADA <syuu@cloudius-systems.com>
Date: Thu, 09 Jul 2015 01:35:51 +0200
Message-ID: <2695914.AOYJdCUfZl@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <CAPWdgggjvMZGUpY6_GPjCgqN00UiWkm50M8z3oLa7gU8x1BmbA@mail.gmail.com>
References: <1428346691-14894-1-git-send-email-syuu@cloudius-systems.com>
 <CAPWdgggjvMZGUpY6_GPjCgqN00UiWkm50M8z3oLa7gU8x1BmbA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCHv3 0/7] add OSv support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 23:36:57 -0000

Hi Takuya,

It has been difficult to receive comments on this series during 2.1 cycle.
I see 3 reasons:
- few people know OSv
- the series is mixing C++ support and OSv environment
- you are adding a third system to support while some work is in progress
  to reduce differences between Linux and BSD support.

I suggest to:
- fix doc with John's help
- split C++ and OSv patches
- help to merge Linux and BSD common code
- introduce a common config file for every environments
- re-send OSv support series at the beginning of 2.2 cycle without RFC keyword

Thanks for your work

2015-04-21 03:37, Takuya ASADA:
> Any comments/suggestions?
> 
> On Tue, Apr 7, 2015 at 3:58 AM, Takuya ASADA <syuu@cloudius-systems.com>
> wrote:
> 
> > This is 3rd version of OSv support patchset.
> >
> > Changelist:
> >  - sync with latest master
> >  - updated Capstan build script for OSv v0.19
> >  - rte_eal_version.map fix
> >  - CONFIG_RTE_BUILD_SHARED_LIB=y and CONFIG_RTE_BUILD_COMBINE_LIBS=y by
> > default
> >  - Check OSv NIC driver is loaded for each device, attach PMD only if OSv
> > driver is not loaded
> >  - Use --maxnic on cmdline to skip loading OSv NIC driver
> >  - Don't enable MSI-X on virtio, since it's not enable when OSv NIC driver
> > is not loaded
> >
> > Takuya ASADA (7):
> >   mk: support compiling C++ code
> >   eal: Add extern C on eal_hugepages.h
> >   eal: Add extern C on eal_thread.h
> >   eal: Add extern C on eal_private.h
> >   add OSv support
> >   app/test: support OSv
> >   doc: Add Getting Started Guide for OSv