DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jay Rolette <rolette@infinite.io>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: announce KNI ethtool removal
Date: Fri, 22 Jul 2016 01:15:32 +0200	[thread overview]
Message-ID: <2696944.7TksCpEKlK@xps13> (raw)
In-Reply-To: <CADNuJVoinm5AyQVrpQOoZxxQjWxD=V_QJuPwcynFBJ3fQkYNDw@mail.gmail.com>

2016-07-21 15:54, Jay Rolette:
> On Thu, Jul 21, 2016 at 3:32 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > 2016-07-21 13:20, Jay Rolette:
> > > On Thu, Jul 21, 2016 at 10:33 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> > > wrote:
> > > > KNI ethtool is functional and maintained, and it may have users!
> > > >
> > > > Why just removing it, specially without providing an alternative?
> > > > Is is good time to discuss KCP again?
> > >
> > > Yes, my product uses it.
> >
> > Your product uses what? KCP? KNI? KNI ethtool?
> 
> Sorry, that wasn't very clear. It uses KNI + ifconfig to configure the
> device/interface in Linux. I'm assuming the "ethtool" bits under discussion
> are the same things that make ifconfig work with KNI to the limited extent
> it does.

What are you configuring with ifconfig?

> > Seems like we are back to the same discussion we
> > > had a few months ago about the KNI situation...
> > >
> > > It shouldn't be removed unless there is a replacement, ideally one that
> > > works with the normal Linux tools like every other network device.
> >
> > This ethtool module works only for igb and ixgbe!
> > There is already no replacement for other drivers.
> > Who works on a replacement?
> 
> Ferruh submitted KCP previously, but you guys didn't like the fact that it
> was a kernel module.

No we didn't like having yet another out-of-tree kernel module.
We'd love having KCP in Linux.

> IIRC, one of the gains from that was simplified
> maintenance because you didn't need driver specific support for KNI.
> Assuming he's still willing to beat it into shape, we have something that
> is already most of the way there.
> 
> If people are going to continue to block it because it is a kernel module,
> then IMO, it's better to leave the existing support on igx / ixgbe in place
> instead of stepping backwards to zero support for ethtool.

Maybe that one day you will want to use something else than ixgbe in your
product (and have more than 10 Gb). This day you'll find other solutions
than using KNI ethtool.

> > While the code wasn't ready at the time, it was a definite improvement
> > over what we have with KNI today.

  reply	other threads:[~2016-07-21 23:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 16:07 Thomas Monjalon
2016-07-21 15:33 ` Ferruh Yigit
2016-07-21 15:41   ` Igor Ryzhov
2016-07-21 16:41     ` Thomas Monjalon
2016-07-26 13:23       ` Ferruh Yigit
2016-07-26 13:42         ` Thomas Monjalon
2016-07-21 18:20   ` Jay Rolette
2016-07-21 20:32     ` Thomas Monjalon
2016-07-21 20:54       ` Jay Rolette
2016-07-21 23:15         ` Thomas Monjalon [this message]
2016-07-22 17:20         ` Andriy Berestovskyy
2016-07-26 13:18           ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2696944.7TksCpEKlK@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=rolette@infinite.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).