From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D9523257 for ; Thu, 3 Aug 2017 12:54:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E528820A4B; Thu, 3 Aug 2017 06:54:02 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 06:54:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ErpBNWf70UaTy9e kC1Tj/0Jt/sp793+HT40k7XoWJBw=; b=RYy3NjUzzfLHSOjTWrxieOY6GgFTfYe ms7NRHrg2vxoTzdIdevc53b+HnNEN9o1SS+1T3gY9xN2cNj27Yxy01xNzTQTPGVp PJQJPcVrE52gH+j3G55joe81RXwUhXI6xfP9ac/36t8E0qOFj0w3/7AqSSY6lMJJ tpnZdax3pHgo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ErpBNWf70UaTy9ekC1Tj/0Jt/sp793+HT40k7XoWJBw=; b=AQvJ8NHV 1SoyirEviEosPjds9mAABE1eXSeVXJatv3tkY7QbS7rhh411SDZt94mpvYgD7IRK 9/ijKWc+eGLgcAlMOVmytba5qnzXiuUkcccDX9SS3P2pTb7yRAVfFKNrOGBxDvVv yFgmbRuZc4PQuXz+TnTcEMiHvHox05XOZSr9QWht8VOvUqdfNANSZz2jC66Zs9cs R3+SLuSai4XjMjh3sBkVb/P4tJh4RlfxRfpKMUR6UwXc2Gnx1B04Y8VxKkG8A4po JvJfUmVkMA2ex7IEmG8jSL3KBso4HEsb+1FGKsG+R1YqFCtAtlyqHPzD1m0lcvn6 aXWj3wFC2RW7lA== X-ME-Sender: X-Sasl-enc: xFStNU/XavKHb2dt2bYKoIFWfZh7x8IYIS3TA2X9coFY 1501757642 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 752DB2436A; Thu, 3 Aug 2017 06:54:02 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Thu, 03 Aug 2017 12:54:00 +0200 Message-ID: <2697465.y20SqaHCPg@xps> In-Reply-To: <20170428163420.25785-1-ferruh.yigit@intel.com> References: <20170428163420.25785-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: add script to get maintainers from patch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 10:54:03 -0000 Hi, Sorry for looking at it just now. 28/04/2017 18:34, Ferruh Yigit: > This is a wrapper to Linux kernel get_maintainer.pl file and only > supports parsing MAINTAINERS file (no git fallback etc..) That's the reason the same file format was used in DPDK ;) > Requires DPDK_GETMAINTAINER_PATH devel config option set, please check > devtools/load-devel-config. > > DPDK_GETMAINTAINER_PATH should be full patch to the get_maintainer.pl > script, like: > DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl > > Can be used individually: > ./devtools/get_maintainer.sh > > Or via git send-email, to add maintainers automatically: > git send-email --to-cmd ./devtools/get_maintainer.sh \ > --cc dev@dpdk.org HEAD -4 Please, could you update the contributor's guide? > Currently there is an ugly workaround to be able to use Linux script out > of the kernel tree, later better method can replace it. Yes it is very ugly :/ Could you try to send a patch to Linux to avoid such workaround? If we need to keep this workaround, we should at least make sure the files are always well removed, thanks to a trap invocation. [...] > +workaround > +$DPDK_GETMAINTAINER_PATH $options $@ > +fix_workaround Please check how trap is used in devtools/test-build.sh Thanks