From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9546B1B342 for ; Tue, 7 Nov 2017 21:42:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 12A5620CD0; Tue, 7 Nov 2017 15:42:42 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 07 Nov 2017 15:42:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=GjqlpGCMVmyeD04a2pBp6ONpYH U0/3/i+VEz/KhW/PU=; b=liSUKeTlVON9hOtYdbS2mJxqta9pf1KhL+q0bIWvqf BbT/YXOiJnH/kcNlbahBWv+IIx4qcBNt/1TJNxLuECDv9pfI6juWYKPIOcA2pkJ9 xfWPwLlQ9n5Tg2ymLLAHD9PU8FixXws6cKnJZhYy/umRjRWq+gn7Ln4+GQPlVaFi E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=GjqlpG CMVmyeD04a2pBp6ONpYHU0/3/i+VEz/KhW/PU=; b=jgx3o32hkOZGgnwaw7fx/h XHsNgq50C3K7rJpebJxDW4jyRiNGoGGo3sB8n0JKQD1V3lqVIBN5dYNG0xKwYAmb SU+FK19V+vzT6/puyRatk1Uh2LT6jZ0RWGgMwSobu6py82fsKGAi2kdPAS6J8aAL +25irGQf526uHTG6tpXltimtA8uw3GeA/a5fmc29q4wIwi5dJgrqWwLPjbwxs4xj Ae/kyg6xK8mZDKrIGZ+34OC/1DBeXE028XS6tr65hy5zMn5HvYY39YzyHjF5A3JU ou4J8MlZ3cn9444JNEKfrzqf0iC6V+yKI1zHjKVcGXYIyoiPwrlC6JlEhNEfTRDA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C294E7FA7E; Tue, 7 Nov 2017 15:42:41 -0500 (EST) From: Thomas Monjalon To: Ophir Munk Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Wu, Jingjing" Date: Tue, 07 Nov 2017 21:42:40 +0100 Message-ID: <2698635.jqlqO458xW@xps> In-Reply-To: References: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com> <1510062750-29091-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 20:42:42 -0000 07/11/2017 18:43, De Lara Guarch, Pablo: > From: Ophir Munk > > > > When defining two failsafe devices in testpmd the port numbers of the > > failsafe devices may not be consecutive. > > For example: if failsafe device includes a PCI device and a TAP device then > > failsafe port numbers would be 0 and 3. > > Port 0 - failsafe #1 device > > Port 1 - PCI #1 device > > Port 2 - TAP #1 device > > Port 3 - failsafe #2 device > > Port 4 - PCI #2 device > > Port 5 - TAP #2 device > > > > If forwarding is defined between the failsafe devices including a peer > > address the forwarding should be between peer addresses of ports 0 and 3. > > Instead testpmd establishes forwarding between peer addresses of > > consecutive ports 0 and 1. This commit fixes this bug. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk > > Signed-off-by: Raslan Darawsheh > > Acked-by: Pablo de Lara Applied, thanks