From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 392645587 for ; Mon, 1 Aug 2016 15:26:18 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id f65so370152110wmi.0 for ; Mon, 01 Aug 2016 06:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=32QZFetCh7R3MJZhDjbS0a4bYeO+uAI2QxihJYBG+TE=; b=vzrxcYt9drNcXlIH9/LrQjPq9wpbI2dkvS/JL+utFHkf/90W1AD90HKUOE4sTJKrGP dVGvvOhz9xU0s3+3Z6d5X/sNWmgMcECWDfxh/NhqUbHX+PR45UUw8Xbo3iYaGnGnOaf3 kUcmydUK0br8Wd8XI5peeEPQZUTj3pva6t8JiIqCVmgCk3PKkgNuP5kbDlgoG0A8Rxmb HrnaoevhGQpOVLtv74JDJb0tQ4mnut03YEAe4jC5dPI2vZWoT/6RPztyPbCgahjyINKC tE7EUes2ueF7dXkvbgWjE3MrUs77up/omw6mqKLEUdrtzZIEyR/JuNjL+n4mqYejX2yn zrdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=32QZFetCh7R3MJZhDjbS0a4bYeO+uAI2QxihJYBG+TE=; b=U3ARXPxL/bW56Na/qC0t3jn+8gXkSZR7IJW35zJCOgIQgK27Hyvcx05xpX1lkk7Y4g h0/s55TNqudxz8m1V/14PV+vZNXDgLobjeAzRmmzZm2/OBB90hUEkM1f+ipr1zWkVlkJ wjnqQ8RJ+64BG+Kenk1cnZ7X364+tMjfkEkfNPnscFf1ZSwi0EHx7PJz52q/l4vM2Rmv g8IPowecq9NvEBfEo3/kEB8IsIweqQJH3O4mZVZoTkocKiR3dpbE+BwxS/4PZTmX/Doo xqTeL4J2pVwXJXFohcBw6MUVXfHNY2PkvTooHrCldXjUeycoY5lBb5SLVNvmDOUWV3Fe mtsQ== X-Gm-Message-State: AEkooutDq5kWNlFbucsZT0QFrX6bnp6DOiC186lJLwBEG1YtGLGeIV9pVv9GSHHlF12FBHO/ X-Received: by 10.194.77.174 with SMTP id t14mr55355521wjw.146.1470057976904; Mon, 01 Aug 2016 06:26:16 -0700 (PDT) Received: from xps13.localnet (86.114.118.80.rev.sfr.net. [80.118.114.86]) by smtp.gmail.com with ESMTPSA id qe2sm30613670wjc.28.2016.08.01.06.26.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Aug 2016 06:26:16 -0700 (PDT) From: Thomas Monjalon To: Christian Ehrhardt Cc: dev@dpdk.org Date: Mon, 01 Aug 2016 15:26:15 +0200 Message-ID: <2698928.TdmtWMiOju@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1470054511-31217-1-git-send-email-christian.ehrhardt@canonical.com> <2509298.JEBDPBJoPR@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 13:26:18 -0000 2016-08-01 15:12, Christian Ehrhardt: > On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon > wrote: > > 2016-08-01 14:28, Christian Ehrhardt: > > > Due to regular lintian checks in Debian packaging it surfaced that these > > > two scripts had a space in their #! statement which renders it to be > > > human, but not shell readable. > > [...] > > > -#! /usr/bin/python2 > > > +#!/usr/bin/python2 > > > > I think we can have a space in the shebang (it works with shells I know). > > But maybe lintian do not like it (and it is a sufficient reason to accept > > this trivial patch). > > > > However, a better fix would be to run something else than python2, > > like /usr/bin/env python. > > > > Some other python scripts in tools dir may be fixed. > > I agree on both changes you suggested, but not being the scripts author I > wanted to change as few as possible. > Also thanks for taking it into consideration even if just for lintian :-) > > If acceptable to you I'd ask to accept this as-is and consider the patch a > head-up for all script owners to change their headers. We can remove the space in every scripts, at least. Then we can wait a little for the opinion of the script authors to do more changes. PS: Please avoid top posting.