From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C19EF431E4; Mon, 23 Oct 2023 18:14:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF96240DCB; Mon, 23 Oct 2023 18:14:08 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id ED43B40697 for ; Mon, 23 Oct 2023 18:14:06 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id B9CFD1A30D for ; Mon, 23 Oct 2023 18:14:06 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id ADDDE19E42; Mon, 23 Oct 2023 18:14:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id F2A1F1A38D; Mon, 23 Oct 2023 18:14:05 +0200 (CEST) Message-ID: <26990b8c-298b-43b2-88f6-4d44ff2b9e73@lysator.liu.se> Date: Mon, 23 Oct 2023 18:14:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 08/14] eal: make seqcount and seqlock stable Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= References: <20230809164312.308093-1-stephen@networkplumber.org> <20231020214119.255491-1-stephen@networkplumber.org> <20231020214119.255491-9-stephen@networkplumber.org> From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20231020214119.255491-9-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023-10-20 23:41, Stephen Hemminger wrote: > These were add back in 22.07 release. > > Signed-off-by: Stephen Hemminger > Acked-by: Mattias Rönnblom > --- > lib/eal/include/rte_seqcount.h | 23 ----------------------- > lib/eal/include/rte_seqlock.h | 21 --------------------- > 2 files changed, 44 deletions(-) > > diff --git a/lib/eal/include/rte_seqcount.h b/lib/eal/include/rte_seqcount.h > index 4f9cefb33862..ff8985310377 100644 > --- a/lib/eal/include/rte_seqcount.h > +++ b/lib/eal/include/rte_seqcount.h > @@ -41,15 +41,11 @@ typedef struct { > #define RTE_SEQCOUNT_INITIALIZER { .sn = 0 } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Initialize the sequence counter. > * > * @param seqcount > * A pointer to the sequence counter. > */ > -__rte_experimental > static inline void > rte_seqcount_init(rte_seqcount_t *seqcount) > { > @@ -57,9 +53,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Begin a read-side critical section. > * > * A call to this function marks the beginning of a read-side critical > @@ -101,8 +94,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount) > * > * @see rte_seqcount_read_retry() > */ > - > -__rte_experimental > static inline uint32_t > rte_seqcount_read_begin(const rte_seqcount_t *seqcount) > { > @@ -114,9 +105,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * End a read-side critical section. > * > * A call to this function marks the end of a read-side critical > @@ -146,8 +134,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount) > * > * @see rte_seqcount_read_begin() > */ > - > -__rte_experimental > static inline bool > rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn) > { > @@ -172,9 +158,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Begin a write-side critical section. > * > * A call to this function marks the beginning of a write-side > @@ -196,8 +179,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn) > * > * @see rte_seqcount_write_end() > */ > - > -__rte_experimental > static inline void > rte_seqcount_write_begin(rte_seqcount_t *seqcount) > { > @@ -214,9 +195,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * End a write-side critical section. > * > * A call to this function marks the end of the write-side critical > @@ -228,7 +206,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount) > * > * @see rte_seqcount_write_begin() > */ > -__rte_experimental > static inline void > rte_seqcount_write_end(rte_seqcount_t *seqcount) > { > diff --git a/lib/eal/include/rte_seqlock.h b/lib/eal/include/rte_seqlock.h > index fcbb9c586668..589c98188529 100644 > --- a/lib/eal/include/rte_seqlock.h > +++ b/lib/eal/include/rte_seqlock.h > @@ -114,9 +114,6 @@ typedef struct { > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Initialize the seqlock. > * > * This function initializes the seqlock, and leaves the writer-side > @@ -125,7 +122,6 @@ typedef struct { > * @param seqlock > * A pointer to the seqlock. > */ > -__rte_experimental > static inline void > rte_seqlock_init(rte_seqlock_t *seqlock) > { > @@ -134,9 +130,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Begin a read-side critical section. > * > * See rte_seqcount_read_retry() for details. > @@ -150,8 +143,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock) > * @see rte_seqlock_read_retry() > * @see rte_seqcount_read_retry() > */ > - > -__rte_experimental > static inline uint32_t > rte_seqlock_read_begin(const rte_seqlock_t *seqlock) > { > @@ -159,9 +150,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * End a read-side critical section. > * > * See rte_seqcount_read_retry() for details. > @@ -177,7 +165,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock) > * > * @see rte_seqlock_read_begin() > */ > -__rte_experimental > static inline bool > rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn) > { > @@ -185,9 +172,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * Begin a write-side critical section. > * > * A call to this function acquires the write lock associated @p > @@ -212,7 +196,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn) > * > * @see rte_seqlock_write_unlock() > */ > -__rte_experimental > static inline void > rte_seqlock_write_lock(rte_seqlock_t *seqlock) > __rte_exclusive_lock_function(&seqlock->lock) > @@ -224,9 +207,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock) > } > > /** > - * @warning > - * @b EXPERIMENTAL: this API may change without prior notice. > - * > * End a write-side critical section. > * > * A call to this function marks the end of the write-side critical > @@ -238,7 +218,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock) > * > * @see rte_seqlock_write_lock() > */ > -__rte_experimental > static inline void > rte_seqlock_write_unlock(rte_seqlock_t *seqlock) > __rte_unlock_function(&seqlock->lock) Acked-by: Mattias Rönnblom Thanks!