From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CA17A0564; Tue, 24 Mar 2020 09:37:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DA5E1C0C3; Tue, 24 Mar 2020 09:37:27 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 46CDE1C0C0 for ; Tue, 24 Mar 2020 09:37:26 +0100 (CET) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.144]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id D878120065; Tue, 24 Mar 2020 08:37:25 +0000 (UTC) Received: from us4-mdac16-42.at1.mdlocal (unknown [10.110.48.13]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id D6A48800A4; Tue, 24 Mar 2020 08:37:25 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us5.ppe-hosted.com (unknown [10.110.50.8]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 597854004D; Tue, 24 Mar 2020 08:37:25 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id DF5D44C0061; Tue, 24 Mar 2020 08:37:24 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 24 Mar 2020 08:36:56 +0000 To: "Zhang, Qi Z" , Thomas Monjalon CC: "dev@dpdk.org" , "rahul.lakkireddy@chelsio.com" , "Wang, Xiao W" , "xavier.huwei@huawei.com" , "Xing, Beilei" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" , "Yigit, Ferruh" , "jerinj@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "maxime.coquelin@redhat.com" , "Ye, Xiaolong" References: <20200311230136.63452-1-thomas@monjalon.net> <039ED4275CED7440929022BC67E70611547E53BE@SHSMSX103.ccr.corp.intel.com> <5581955.lOV4Wx5bFT@xps> <039ED4275CED7440929022BC67E70611547E55AD@SHSMSX103.ccr.corp.intel.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <26aaaba9-ac76-c917-a00e-145e3e2d0432@solarflare.com> Date: Tue, 24 Mar 2020 11:36:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E70611547E55AD@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25310.003 X-TM-AS-Result: No-20.740100-8.000000-10 X-TMASE-MatchedRID: I31hiQfYWUPmLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jQd0WOKRkwsh0a+ 4Fduu7BiC2Twy89n2qYuKNNSIEfdJdkofSZrkji4uZBZOg7RfX8s26eskl9o3TP3WYNhkszlvQS /jzORDUG0LMwXr3wYw7Bn8A2CciYoW2/uVVOXnn3J1E/nrJFED1rdKD8oHqzdkY8eITaSJPhNJL ReVzHnVDde18o1cvwhnWQ2dtsTT6zHlF1JghTo/eIfK/Jd5eHmQZpQRfyCdHyw/fZtDtJZ7En0v jeeb/bZ2moNAGVX7mLAIZbGS0BhxMmxEDY0suHeolVO7uyOCDUj56rvFVgJ7FIxScKXZnK0sFmz NLPWp6JfTEimEz46B4N86bMbdBNQU2rba4GvN9iI8hHRrWLqF/fjx7YIT/BiT7zqZowzdpLSUuy kl9IhfDAvPA92YOlb7POegsjHfkfIVeuQnVnkwFhxiWPCm7jEjWP6asaL88Va1yhTwm1zuWJBW1 hFlEpiRnM6ABgfWkPGDLP3UrmlX0vTJCJ3RkYohQwmwdAU7bJ99ekRHlOQkQdcjVKj+329QxGB8 tl9IoFwYoEaywH6MyrIptD3BuobrA3HR0GzWN00OtJVkKBtK2AW2j9VWc0lA5dw5i4XGDy/6/cy CTWmIydB3i1UmNWrJSD/VP58PETbS0m47m6fSi0x8J2DopEN3GzSWPUvyu8HQvT9S3vHUBbjWLZ HubLu8MqJaO20m/xicArG/2fGpU1+zyfzlN7ygxsfzkNRlfJoFT3KzpHqE7mr0dH30ACg2AyqvQ Syt/c7AFczfjr/7KEGa0BLglc4nEcZNKzvjHk08TgiYwylyiA8xToxoGmRaRKmw8R7b4s= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--20.740100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25310.003 X-MDID: 1585039045-FgBrMekxxYyB Subject: Re: [dpdk-dev] [PATCH 0/3] refresh NIC features matrix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/20/20 2:15 PM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Friday, March 20, 2020 6:45 PM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; rahul.lakkireddy@chelsio.com; Wang, Xiao W >> ; xavier.huwei@huawei.com; Xing, Beilei >> ; Lu, Wenzhuo ; Yang, Qiming >> ; Ananyev, Konstantin >> ; Yigit, Ferruh ; >> jerinj@marvell.com; rmody@marvell.com; shshaikh@marvell.com; >> maxime.coquelin@redhat.com; Ye, Xiaolong >> Subject: Re: [PATCH 0/3] refresh NIC features matrix >> >> 20/03/2020 06:35, Zhang, Qi Z: >>> Hi Thomas: >>> >>> From: Thomas Monjalon >>>> >>>> This series aims to clean-up the big table of ethdev features: >>>> http://doc.dpdk.org/guides/nics/overview.html#id1 >>>> >>>> We could reorganize the information in this table, maybe split it or >>>> add/remove some rows. >>>> Before going to such reorganization, we should clean it up. >>>> >>>> The first patch is fixing the look & size of the table with recent sphinx. >>>> >>>> The second and third patches are removing 8 columns which are >>>> clearly >>>> unneeded: >>>> - bnx2x_vf >>>> - bonding >>>> - kni >>>> - nfp_vf >>>> - null >>>> - ring >>>> - softnic >>>> - vdev_netvsc >>>> >>>> More columns can be removed by merging PF/VF and vector datapaths. >>>> If a feature cannot be supported in all cases, it should be marked >>>> as partially supported (P). >>>> If a feature is PF-specific (like flow control), that's OK to mark >>>> it fully supported because it's obviously impossible for VF. >>>> There are also some features which were probably marked in some >>>> columns and missed in its VF or vector counterpart. >>>> Please work to merge and drop these 16 columns: >>>> - cxgbevf >>>> - fm10k_vf >>>> - hns3_vf >>>> - i40e_vec >>>> - i40e_vf >>>> - i40e_vf_vec >>>> - iavf_vec >>>> - ice_vec >>>> - igb_vf >>>> - ixgbe_vec >>>> - ixgbe_vf >>>> - ixgbe_vf_vec >>>> - octeontx2_vec >>>> - octeontx2_vf >>>> - qede_vf >>>> - virtio_vec >>>> >>>> The total gain is to reduce the table size from 71 to 47 columns. >>> >>> I agree to remove all the column with "vec", since vector PMD can be >> regarded as a feature of the a PMD. >>> But I'm not sure if it is a good idea to merge VF and PF into one column. >>> From my view, for intel device, VF driver and PF driver just share the code, >> but they actually are running at two different context. >>> And likely they will support different feature, merge into one column may >> confuse our customer if they want to understand what exactly the PMD >> support. >> >> I understand you have 2 different datapaths. >> My arguments are: >> - it is the same NIC > > Yes, but one device can be polymorphic, ideally i40e and i40evf could be in two different folder, and the common part can be a library in driver/common/i40e. For me, it does not sound like a good idea. Too many folders on the first level does not look nice. Should we go Linux way and group by vendor? Too early? However, it is not directly related to the topic. >> - you cannot summarize everything in a table >> - we have two many columns to make it readable > > I don't think columns number is critical, typically user just need to focus on the first column and the specific driver's column, Too many columns still makes it harder to read/analyze. I think the main goal of the table is too help making NIC choice to be installed in a server and you can't make a choice between PF and VF. Difference between PF and VF capabilities is a separate story and out-of-scope of the table. We have a new driver(s) in each DPDK release and table is already big and will grow more and more. > I guess it may not a big challenge to enable some filter by front end web technique? > >> I think the right solution is mark features as partially available (P), and give >> details in the driver guide documentation. >> >> Can you please, at least, remove the "vec" columns, as a first step? > > Sure, as I said, I agree to remove "vec". > > Thanks > Qi > >> Thanks >> >