From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC42745C50; Sat, 2 Nov 2024 02:02:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA783402B7; Sat, 2 Nov 2024 02:02:38 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2049.outbound.protection.outlook.com [40.107.244.49]) by mails.dpdk.org (Postfix) with ESMTP id CE1C64029A for ; Sat, 2 Nov 2024 02:02:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cB2fMmX5mdxdLyiCWG9mbjk96GNo2NdU3onHMN7J1ahc0mv3WMQ3Fh2JZBE52PKRR/RA9FtTYzT1KUsWVO2QN/Kq6f47zOq8dDvg6svzeMR3TNzr6Xjiv6Uwo6qF6qAaMYIElwnRnNWBjPrNd7HfbfoHEST61005wBsR1OJCevqoheXD+OiwGEkNrT5QHt4yv+JXnIlILv/t0U51040hYrnJTTX34yEBYXE8JFayeZkUvOvF2GFYJVp9NAeAMkGZsiaO3y6+Bj40w0DbSyZlXZm85dCbnNFUWu74pGHXFJbHl1l15hFfnojbfLCajLYa71di4wlKr/CLqmNwhCDThw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zzmjo6JWZV6m4edoUwO1JuOFX1gZ+Kwqgh/keImNjrs=; b=kmPupHmWfMR2IcvLi4y4JS2y94RSqgFkBZBuxpCYrmmPXQtuIHUjt3+qLfIsKmqjT7XvYUOqKQlBsA9VWcNg+7NDqksLSrR3NDdiEo6+qhxFCDYnmZBy0nc6kzfXLld61cZLQYxNFPX6uxWy2DFR4Zg11pQUSbHhazXh3ZPzivxYuC8Kde4as7SQ/QtD6rRKHsCX75G7JzR7ZrW7wt2Y53zaspMZ91lMDAn7aPNHoMdh+22R0IuywOXlRQWpH/N+nCgNqXAM7jzoob3bndsqi2oyz+L56TZLfV8B5gALKEhv7ng7FT67pCPNUbhX1UIM83ZwEnxDywxgadiFdcDnrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zzmjo6JWZV6m4edoUwO1JuOFX1gZ+Kwqgh/keImNjrs=; b=g9uqnVaZgDBxcgH0105V3e/q/3cXByB8isjWSqIgyH4rLmYhVtanlMCXo+rpbkaQ03HjD5DkbPUx2QR0WF/kc+xrMPCWcqGdZbOJwJmDjNZ0pWw56ctOgloNY5YQj2q/pBaVxvQzfOGc9F1BHSlFhCCV/5ncOMD3djdK3JqWOnM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by SA1PR12MB8920.namprd12.prod.outlook.com (2603:10b6:806:38e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.23; Sat, 2 Nov 2024 01:02:34 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8114.015; Sat, 2 Nov 2024 01:02:33 +0000 Message-ID: <26c3ad86-695e-4103-8290-eb813227706d@amd.com> Date: Sat, 2 Nov 2024 01:02:27 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/9] net/zxdh: add logging implementation To: Junlong Wang , dev@dpdk.org Cc: wang.yong19@zte.com.cn References: <20241030090124.2540776-2-wang.junlong1@zte.com.cn> <20241101062156.2637339-1-wang.junlong1@zte.com.cn> <20241101062156.2637339-3-wang.junlong1@zte.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241101062156.2637339-3-wang.junlong1@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0019.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::21) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|SA1PR12MB8920:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c114ad1-117d-4c39-1273-08dcfada0865 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bXJiK3phWFdCUDgxNUszbzRscVZHRzgzOTJhYlBOa0h2MzBGYlUwbU5BUjVk?= =?utf-8?B?NmhyR1Qyd1RJUzQydUVPOEg4L2JWTUdHeWVJaS9kTHZjVHpFd0NqTmVCbjIv?= =?utf-8?B?ZVhnUFFDNWN4S0UrMC83Z090R2p4d2RKbnVXZ3VzRnhGaGZnOEZHRGR1L0pa?= =?utf-8?B?YUp0NHZaU1VxdlQ4RHNSZE5mamttMy9lY3NSdVRMV3JkaXFSQzNhaUcwTFl2?= =?utf-8?B?eWJpdDlnczFZK21HN3lwSW5uMlRaRmdTWS9UUDA4WlBKSUFyRy80VDJEWkV2?= =?utf-8?B?eE56eGNHTkRjWEY1cEhDNWNFdFpnNVVraVIzMTZnRERSWGpXZDljcW9vbjVD?= =?utf-8?B?ZWpVTFByZm5jZDdsaWQyZWlNTDVPVnUwYWN0MmtIYkY1djMyVkxjSi84TU1o?= =?utf-8?B?MEdqYlZwN3pOVFR4dG9CdWdlekF3YzNxRkNUOVZ6OVVJU2tyUW9rTUF6cXl5?= =?utf-8?B?MTI3YThFZEJUYjJKTzlLQ0NPUHg0SWU0SHN6b0hpTS9XZzIyc1RWQms5YzRr?= =?utf-8?B?TmozQ3AvZ2UzdGQ4SmtmK3pHNC9DN3BNb0RwU2w3TUhidk9VbHJwVXV2ando?= =?utf-8?B?T1k5VDQyWUFXS1Z4U0JpdEs4T3ZJN0FYTVJjUnVVMXlqOEY3MXU2R214RXlj?= =?utf-8?B?OUwxQVpMSkdLTmxiMnZtLzJTM1B0Qjk1MFhIeHlLUU1ZS2RmOXZrTWNVNVdT?= =?utf-8?B?Nm5ia09BcEhISUxCR0d4aHV4MDZDMXl1dXFzZjN6YUIxcit1RklzUE5zaXdv?= =?utf-8?B?Y05najlvNlExQStxKzlldmV2QURVMitCSWlDV0lmekZGbzArdENvcDlpaFFa?= =?utf-8?B?MTFOSW1aRFBSTEFPQkJ0M1lTWnV4Ukt0ZG13SC82b3lSVlhQbXMrRUFDSzhK?= =?utf-8?B?YjhzeU1aQTRjdkh6S3RiWGc4c3ZvRzNUM2NObXNqemo3OVdMOEV6QnZuK3VF?= =?utf-8?B?VzBjL29la3kxbGpCQ2JMcDU5SDZXMHRpSi95WG5OVWlwVmlqZTdnNHMrTDhZ?= =?utf-8?B?Vm9jZFp2Mm0xaEZaYWMwSEtMNlJMeXFuS3BydnRtU21tc0RZY3p5bjZTQjQ3?= =?utf-8?B?WHJTL2ZYK0xDTnE0dnVZazl0czQ5bkdmTkhZaXNna01yeHVmdWtjTDVIcWRS?= =?utf-8?B?NU45SnIzS1hyZ1BCTk11M0ZOS2c3TTQxYjR5MzdUOXJQbVFJT1JhRXZoQjdS?= =?utf-8?B?OEZhSDRNcEk5L3NrU3AzdEsvZmd3ZVk0SlgzUS91V3R4TzdmdEM1a2twQWd2?= =?utf-8?B?OUZNYmdTSjFCSGpmQ01VMlNOY1NsVVFTUzZJbFRMWko2UFd0N0RRa0UwbmV3?= =?utf-8?B?MytZay8yZzNscWV0UDlQcFFUQStiby9EL1FyMHVTTmIzUTBtODlxd3hPaGxM?= =?utf-8?B?bytNY0Z6ZW5oUW9jbEp2elNCMXhZTUNjdVEzNUZEdWtDaEtVOGNCK1MyWEd5?= =?utf-8?B?VjRUOG1JSzhKeitnUXZCd056QU1lZ015SUpJekhhTEtTWmVjdDJ0bFhWaS9B?= =?utf-8?B?VUhEOWljNDlUZDNENTRCNFlyVXBvSzJnV2E5dkpHYWNuR2lCdnY5Q2lTK0Mx?= =?utf-8?B?dG5ocncvZkhvbk9HelRrMldsUkhYSjFXRXBkVEpCQVdicVB3OTB5eEY3cm10?= =?utf-8?B?dXAyd2pEdTNRUEF1bUIwUEZRTUZzc1FMMzBhVkRyOGZLcVRMWE1Ma1hleUls?= =?utf-8?B?azVRWnlWaUVLTVRRQytVaG1ycGpWWHZGMFNhTkdRT2FEU29qYVdWRWE3bWdT?= =?utf-8?Q?ezXpdrR74TwelKeijg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWtLSWxMbldUVzJzT3pZOGxoWWFlMnF1UjRPb2dvYTQ5aFV3Q1ZyQmNkdnR5?= =?utf-8?B?OHEyT3FBZld0SjNGaFROM3pOMWZwa2F4STZxOTAzaEVpY05tNzVVeWp4UXgv?= =?utf-8?B?T2Zxb3A3Sm9aTXRyb0IwVHBtNGpTQ1ZZcEpkRUMrdE55OVVTaXAvQmE0bFZl?= =?utf-8?B?WlMwY0J0RU5jQ1c4OEhLQXRTb3c3WkdFcmZMT0FxazlqdHZHb1RYNks4anli?= =?utf-8?B?b25MM1FlV2ZveUVyYW1LUk12MC9za0owY3N5eFZkTEs5eXdlZDVkSi93cXZU?= =?utf-8?B?c1krQ04vUk4vTVhRendpVitIZ2duM09FMWZacDloVkY5RGRXVTNNeU51L1FV?= =?utf-8?B?SjBnMTZCdFZ1NUpDbkRWS0phT1pBNnAzL0dWdGZISzZKMjJtUzJ6b1V1b3pV?= =?utf-8?B?U3YwRytSalNJaHFVQjkrWHFYRjJEZklaQmZXM2tlMWhrQmY4aDY1QkNEdThm?= =?utf-8?B?WnJvcmhsQkx5TFB3QnRDKzlhS0t0NURvQVkycTcwekZ1WjBmU1lIaUYwS0NW?= =?utf-8?B?andwbmdWY0x4UU51eVFIS2hHeHNGTTZPZE5iRHdSWDlqVS9lZGd5OWdWM0kv?= =?utf-8?B?WWdaWkdkOFRxaXF0YkZaclFWcEJlVHA0Wi9sRytWdnp4WCtqYXltTHd0NEF3?= =?utf-8?B?Y3lLMlNCWTc3QmNrbW5XYndsdkJVVWh0dWNaNXNjbEpBVlFJd3JXMm56NWdF?= =?utf-8?B?QU1TeFg5T0JWdHRacU1nWWkydEtxQ291Z0ZtWEVsNkpFMkQxeXZVNXQ0c09y?= =?utf-8?B?TnJCVHRuVWo5emM1L3NiN3JFRUhDTFhzbG5FVVF2c2RvbDJPS3A4ODAyNnJC?= =?utf-8?B?RCtPS2F3U3dreUxzNDNONkxiV1N2L0kvSFN2V3pXcGQwSWIzYlJUUFA5Ykxl?= =?utf-8?B?bml5ZjJwN1grTE4yRUhzVmdmdjdwbDZ5aFhsaFY1WDFoVHkyd2hNUjVNYnFM?= =?utf-8?B?T0o3QmxqUFdtT0lpbHVJZmwzZm5YVkU3R3RiWWtqOVRIcy85aGJMY2I3OFU4?= =?utf-8?B?em9pK2Q0ZE1zazRTcjN4enZYRDlTUWM5aTFTc0lsM0pkM2FYS1pHMTlOeHBY?= =?utf-8?B?eWZpYWwwY2s2bzJmRTN1Zmd4bWNnaFBGcXpjbWxoMjNsRUZ2NDRwZElPdzFq?= =?utf-8?B?TUZDZVFBamEwaEE3TEdqSDhaOU5xMEtFd3N2ZndwRzJMVzRMZ3U4Y1NucmNH?= =?utf-8?B?STlnWUZzQ3FQWUE3Ri9Ba253b3FTUFVrbHVmbTJZZ3dMYjFmdWQ3N1UzdHdh?= =?utf-8?B?aHJ5UnJMN2FuSzlaUTFLdTF3cXNQczVwK1dweXdyOE16bE1aekt1ZkJ1VTZY?= =?utf-8?B?L0pYcTVObFRuR2dqNk5EQUJSQ21XVlI2ZGdVd1BmZWF6dnY3WFhEang0UzJJ?= =?utf-8?B?T0g1Y3FNMEhORVF0MGJEc3NsY2FxcnlDQ0o1ZmhWckJTanhLZm4xNDdzdEZT?= =?utf-8?B?dDduWDRzenVaTTJMRTVNdzBDanQ0bkxjYmY4a0ovM1E3YThFZVdwa21oeUZv?= =?utf-8?B?Tklpb3Nmd3NGT0dTLy9uVldkZTNxY1N0bFRRT1hnSnNNWXZkY0ozZUxEYjNr?= =?utf-8?B?UFozMmUxM1AvOExzTzdSdjRjb0cxWHltbnpPUU5lTHJCMmswWlUxanpQcmlm?= =?utf-8?B?WFBaaWlTS2J3czc3M2NSNlg3djBWZEFVclREQi8vRmVYR3pDVXNJTWpkZ2RE?= =?utf-8?B?dWtZdTFKWDAza0g2WlJqSXdScjBmUnVJcHhhRmV5ZnRjZ0tNNnhVTmE0bW01?= =?utf-8?B?UVAyeDJSYXZiZlRLalhEbkk0aW1tUjVES1JGSXVsa2pRbWp4MnAwajJDT1po?= =?utf-8?B?bnV0T0dxR3FRVFl1S2Job2IwNGxTaVJMOHNKbmswZWFCNTlMN1p5OGhZbHFx?= =?utf-8?B?ZnlnbFRoZGYwNU9icnlrYzNGSU9tWnNOdWhkQTIzWHFzSy8raUViTWJOWDBU?= =?utf-8?B?T2dpQS9Jb2JqWnN4NjZqYXlKZ3Z6NlpFYUVnWWh2Y1pWWVM1MlRISHpOR2ZC?= =?utf-8?B?ZkRKd0lyNThuSXgvaXpJWCthYWU2M093bEJQTm96ZjQ5aG9xSG9lQWtFclov?= =?utf-8?B?WGpYLzV4ZkRXM3dUMEVLRUtGR2tLZW5RSGdsc1V4MUh2NlJBMzRCZ2lnVXV6?= =?utf-8?Q?8PxuzqoZk6475LlbZJgblkDQT?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c114ad1-117d-4c39-1273-08dcfada0865 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2024 01:02:33.2503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5YlqQaA51u6EY/BQA3EGnFPuVaT37KuFPn3rFp2PbkQW/Gs0T4aRCj01D7rwVU8u X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2024 6:21 AM, Junlong Wang wrote: > Add zxdh logging implementation. > > Signed-off-by: Junlong Wang  > <...> > +extern int zxdh_logtype_init; > +#define RTE_LOGTYPE_ZXDH_INIT zxdh_logtype_init > +#define PMD_INIT_LOG(level, ...) \ > +    RTE_LOG_LINE_PREFIX(level, ZXDH_INIT, "offload_zxdh %s(): ", \ > Are you sure you want "offload_zxdh" prefix for each log, instead of shorter 'zxdh' one? > +        __func__, __VA_ARGS__) > + > +extern int zxdh_logtype_driver; > +#define RTE_LOGTYPE_ZXDH_DRIVER zxdh_logtype_driver > +#define PMD_DRV_LOG(level, ...) \ > +    RTE_LOG_LINE_PREFIX(level, ZXDH_DRIVER, "offload_zxdh %s(): ", \ > All log types seems same prefix, which is OK, but just a reminder if you want to distinguish them?