From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E218BA04C8; Fri, 18 Sep 2020 15:36:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBE7D1C1A2; Fri, 18 Sep 2020 15:36:55 +0200 (CEST) Received: from dal3relay72.mxroute.com (dal3relay72.mxroute.com [64.40.27.72]) by dpdk.org (Postfix) with ESMTP id D4B551C139 for ; Fri, 18 Sep 2020 15:36:54 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay72.mxroute.com (ZoneMTA) with ESMTPSA id 174a16e89d60004d87.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 18 Sep 2020 13:36:50 +0000 X-Zone-Loop: eab5a1599bbc4df8f87e014fdd7695afe58960eb547b X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id 11B843EA1C; Fri, 18 Sep 2020 13:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qmJLySHznELXfq47kqGZorfjKgObvFWlp/rDexfpHKA=; b=AB9LN6e4htShPxF09NdVtDiOCG y0/HzfST/07rXFYT3caEGhhcNgtMRdSM04ZqCQA0KIUmWJaehKoU9gxoW1czaUHoFuJ8NACdpzobv 66E00rSlrk3RP2M9Mjcri6onjiH/g7/Ox92zLws4nEIwAO9LMJZrEYudNLYyy/3+X0KRfEiVpmRK7 PTpu34JRSU1hM0ZFmgF7BPdiDItDV5RAIE/IqetB7ai8NC52eST/XKIsgLvBW6dWSMlPd0F7uiCSK SBdvYKGlwoOXzpxte0zPlRPM2DKCJ5zZHuvdx5MiiyIE6FVzw7QbwS1BlAoaQJAHb4HmF2hORfjiI JhkNpZ6w==; To: "Guo, Jia" , David Marchand , "dev@dpdk.org" Cc: "arybchenko@solarflare.com" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" , Jianfeng Tan References: <20200914081727.12215-1-david.marchand@redhat.com> <20200917112823.10534-1-david.marchand@redhat.com> <20200917112823.10534-6-david.marchand@redhat.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <26c96a9c-9074-6caa-ac94-a6c9eb6bbc32@ashroe.eu> Date: Fri, 18 Sep 2020 14:36:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v3 5/6] eal: hide internal device event structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18/09/2020 04:40, Guo, Jia wrote: > Hi, David > >> -----Original Message----- >> From: David Marchand >> Sent: Thursday, September 17, 2020 7:28 PM >> To: dev@dpdk.org >> Cc: arybchenko@solarflare.com; Ray Kinsella ; Neil >> Horman ; Mcnamara, John >> ; Kovacevic, Marko >> ; Jianfeng Tan ; Guo, >> Jia >> Subject: [PATCH v3 5/6] eal: hide internal device event structure >> >> This structure is not used in the public API. >> >> Fixes: a753e53d517b ("eal: add device event monitor framework") >> >> Signed-off-by: David Marchand > > Agree with the patch that the struct involve os platform specific, it is better no public it. > Acked-by: Jeff Guo Acked-by: Ray Kinsella > >> --- >> doc/guides/rel_notes/deprecation.rst | 3 --- >> doc/guides/rel_notes/release_20_11.rst | 3 +++ >> lib/librte_eal/include/rte_dev.h | 6 ------ >> lib/librte_eal/linux/eal_dev.c | 6 ++++++ >> 4 files changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >> b/doc/guides/rel_notes/deprecation.rst >> index 8fca461045..3669d6533b 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -70,9 +70,6 @@ Deprecation Notices >> * eal: The function ``rte_eal_remote_launch`` will return new error codes >> after read or write error on the pipe, instead of calling ``rte_panic``. >> >> -* eal: The ``rte_dev_event`` structure will be made private to the EAL as no >> - public API makes use of it. >> - >> * rte_atomicNN_xxx: These APIs do not take memory order parameter. This >> does >> not allow for writing optimized code for all the CPU architectures supported >> in DPDK. DPDK will adopt C11 atomic operations semantics and provide >> wrappers diff --git a/doc/guides/rel_notes/release_20_11.rst >> b/doc/guides/rel_notes/release_20_11.rst >> index 185eeae731..e87509dfa7 100644 >> --- a/doc/guides/rel_notes/release_20_11.rst >> +++ b/doc/guides/rel_notes/release_20_11.rst >> @@ -87,6 +87,9 @@ API Changes >> * eal: The ``rte_logs`` struct and global symbol was made private >> and is no longer part of the API. >> >> +* eal: Made the ``rte_dev_event`` structure private to the EAL as no >> +public API >> + used it. >> + >> * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and >> replaced with a private enum in the PCI subsystem. >> >> diff --git a/lib/librte_eal/include/rte_dev.h >> b/lib/librte_eal/include/rte_dev.h >> index 53c8bc6fab..81905b3ae3 100644 >> --- a/lib/librte_eal/include/rte_dev.h >> +++ b/lib/librte_eal/include/rte_dev.h >> @@ -33,12 +33,6 @@ enum rte_dev_event_type { >> RTE_DEV_EVENT_MAX /**< max value of this enum */ >> }; >> >> -struct rte_dev_event { >> - enum rte_dev_event_type type; /**< device event type */ >> - int subsystem; /**< subsystem id */ >> - char *devname; /**< device name */ >> -}; >> - >> typedef void (*rte_dev_event_cb_fn)(const char *device_name, >> enum rte_dev_event_type event, >> void *cb_arg); >> diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c >> index 83b6068264..2e15762b56 100644 >> --- a/lib/librte_eal/linux/eal_dev.c >> +++ b/lib/librte_eal/linux/eal_dev.c >> @@ -133,6 +133,12 @@ dev_uev_socket_fd_create(void) >> return ret; >> } >> >> +struct rte_dev_event { >> + enum rte_dev_event_type type; /**< device event type */ >> + int subsystem; /**< subsystem id */ >> + char *devname; /**< device name */ >> +}; >> + >> static int >> dev_uev_parse(const char *buf, struct rte_dev_event *event, int length) { >> -- >> 2.23.0 >