From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74749A0553; Mon, 17 Feb 2020 11:44:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76A8B1DA02; Mon, 17 Feb 2020 11:44:52 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7B6EA1C0DA for ; Mon, 17 Feb 2020 11:44:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Feb 2020 02:44:49 -0800 X-IronPort-AV: E=Sophos;i="5.70,452,1574150400"; d="scan'208";a="228382841" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.237.221.40]) ([10.237.221.40]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 17 Feb 2020 02:44:47 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com References: <20200107091343.22965-1-david.hunt@intel.com> <3090513.CAdn2TfLgq@xps> From: "Hunt, David" Message-ID: <26d21fec-6100-e315-5d16-3efe9ca0628b@intel.com> Date: Mon, 17 Feb 2020 10:44:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <3090513.CAdn2TfLgq@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1] doc: rework vm power manager user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 16/2/2020 11:13 AM, Thomas Monjalon wrote: > 07/01/2020 10:13, David Hunt: >> Review and re-work of vm_power_manager documentation. Hopefully this >> is clearer, easier to follow. >> >> Signed-off-by: David Hunt > checkpatch is reporting a typo done several times: > s/virutal/virtual/ Initially, my checkpatch was clean, I even upgraded to using 5.5.4 kernel, still no hits using checkpatch. It was only when I installed the codespell package that I finally saw the typos. New revision coming soon. >> --- >> .../img/vm_power_mgr_highlevel.svg | 2189 +++++++++++------ > This high-level diagram is nice but I disagree about having text blocks. > I think images should be image-only and the text can be in .rst. > It will be easier to update. > Good suggestion, I have the rework done, will post soon. Thanks, Dave.