From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 46CFAA49 for ; Fri, 14 Sep 2018 18:23:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2018 09:23:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,373,1531810800"; d="scan'208";a="70884639" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.151]) ([10.252.18.151]) by fmsmga008.fm.intel.com with ESMTP; 14 Sep 2018 09:23:20 -0700 To: Andrzej Ostruszka , dev@dpdk.org Cc: mw@semihalf.com, zr@semihalf.com, tdu@semihalf.com, nsamsono@marvell.com References: <1535718368-15803-1-git-send-email-amo@semihalf.com> <1535720386-18775-1-git-send-email-amo@semihalf.com> <1535720386-18775-2-git-send-email-amo@semihalf.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <26dc727f-8386-3261-0712-fb3f20566a20@intel.com> Date: Fri, 14 Sep 2018 17:23:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535720386-18775-2-git-send-email-amo@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/mvneta: add neta PMD skeleton X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 16:23:33 -0000 On 8/31/2018 1:59 PM, Andrzej Ostruszka wrote: > From: Zyta Szpak > > Add neta pmd driver skeleton providing base for the further > development. > > Signed-off-by: Natalie Samsonov > Signed-off-by: Yelena Krivosheev > Signed-off-by: Dmitri Epshtein > Signed-off-by: Zyta Szpak > Signed-off-by: Andrzej Ostruszka <...> > --- /dev/null > +++ b/doc/guides/nics/features/mvneta.ini > @@ -0,0 +1,18 @@ > +; > +; Supported features of the 'mvneta' network poll mode driver. > +; > +; Refer to default.ini for the full list of available PMD features. > +; > +[Features] > +Speed capabilities = Y > +Link status = Y For link status feature "link_update" eth_dev_ops needs to be implemented, please either implement it or remove feature. (I saw this done later, please add this on relevant patch) > +MTU update = Y For mtu update feature "mtu_set" eth_dev_ops needs to be implemented, please either implement it or remove feature. (I saw this done later, please add this on relevant patch) > +Jumbo frame = Y > +Promiscuous mode = Y Promiscuous mode support is not enabled. (I saw this done later, please add this on relevant patch) > +CRC offload = Y > +L3 checksum offload = Y > +L4 checksum offload = Y Claiming L3 & L4 cksum offload also requires data path implementation to take care mbuf.ol_flags flags. (I saw this is done in next patch, please add this line in next patch) Also I can see these are presented as capabilities but shouldn't this information passed to musdk somehow? Are they always enabled? > +Packet type parsing = Y Similar to above, dev_supported_ptypes_get() is implemented but this also requires data path implementation that fills mbuf->packet_type. (I saw this is done in next patch, please add this line in next patch) > +Basic stats = Y Basic stats collection is not implemented in this patch. (I saw this done later, please add this on relevant patch) <...> > +Usage example > +^^^^^^^^^^^^^ > + > +.. code-block:: console > + > + ./testpmd --vdev=eth_mvneta,iface=eth0,iface=eth1 \ There is a limit to number of "iface" in code, does it make sense to document it? <...> > +#define MVNETA_RX_OFFLOADS (DEV_RX_OFFLOAD_JUMBO_FRAME | \ > + DEV_RX_OFFLOAD_CRC_STRIP | \ CRC_STRIP flag removed in next-net <...> > + > + if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_CRC_STRIP)) { > + MVNETA_LOG(INFO, > + "L2 CRC stripping is always enabled in hw"); > + dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_CRC_STRIP; > + } DEV_RX_OFFLOAD_CRC_STRIP is removed from next-net, you can remove it from capabilities and remove above block. <...> > + > + eth_dev->data->kdrv = RTE_KDRV_NONE; > + eth_dev->data->dev_private = priv; > + eth_dev->device = &vdev->device; > +; eth_dev->dev_ops = &mvneta_ops; extra ";" at the beginning of the line <...> > +RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv); > +RTE_PMD_REGISTER_ALIAS(net_mvneta, eth_mvneta); No need to provide alias for new PMDs