DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>, <stephen@networkplumber.org>
Subject: Re: [PATCH] net/fm10k: fix build with GCC 16
Date: Tue, 4 Nov 2025 14:52:37 +0000	[thread overview]
Message-ID: <26e240e0-9d0f-47dd-a94e-c13599f0368c@intel.com> (raw)
In-Reply-To: <20251104111515.1728873-1-bruce.richardson@intel.com>

Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

On 11/4/2025 11:15 AM, Bruce Richardson wrote:
> Build error reported with GCC 16, due to a set but unused variable. Fix
> the issue by removing the setting of the var and marking it as unused.
>
> ../drivers/net/intel/fm10k/base/fm10k_common.c: In function 'fm10k_unbind_hw_stats_q':
> ../drivers/net/intel/fm10k/base/fm10k_common.c:480:62: warning:
> parameter 'idx' set but not used [-Wunused-but-set-parameter=]
>    480 | void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
>
> Bugzilla ID: 1822
> Fixes: 7223d200c227 ("fm10k: add base driver")
> Cc: stable@dpdk.org
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   drivers/net/intel/fm10k/base/fm10k_common.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/fm10k/base/fm10k_common.c b/drivers/net/intel/fm10k/base/fm10k_common.c
> index b78d4b575b..677ef87608 100644
> --- a/drivers/net/intel/fm10k/base/fm10k_common.c
> +++ b/drivers/net/intel/fm10k/base/fm10k_common.c
> @@ -477,11 +477,11 @@ void fm10k_update_hw_stats_q(struct fm10k_hw *hw, struct fm10k_hw_stats_q *q,
>    *  Function invalidates the index values for the queues so any updates that
>    *  may have happened are ignored and the base for the queue stats is reset.
>    **/
> -void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
> +void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx __rte_unused, u32 count)
>   {
>   	u32 i;
>   
> -	for (i = 0; i < count; i++, idx++, q++) {
> +	for (i = 0; i < count; i++, q++) {
>   		q->rx_stats_idx = 0;
>   		q->tx_stats_idx = 0;
>   	}

-- 
Regards,
Vladimir


  reply	other threads:[~2025-11-04 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04  5:18 [DPDK/ethdev Bug 1822] net/intel/fm10k: warning with gcc-16 bugzilla
2025-11-04 11:15 ` [PATCH] net/fm10k: fix build with GCC 16 Bruce Richardson
2025-11-04 14:52   ` Medvedkin, Vladimir [this message]
2025-11-05 10:43     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26e240e0-9d0f-47dd-a94e-c13599f0368c@intel.com \
    --to=vladimir.medvedkin@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).