From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6E9EA00C2; Tue, 25 Jan 2022 13:58:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53988429B7; Tue, 25 Jan 2022 13:58:24 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id CB660426E4 for ; Tue, 25 Jan 2022 13:58:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643115502; x=1674651502; h=message-id:date:from:to:cc:references:subject: in-reply-to:content-transfer-encoding:mime-version; bh=VPGdVDgd16p0/+7Lp8EBkDiJljj0Yea5uwIAzDZABfI=; b=Dvf73qr11YTJs2tGTreZZ21kIFqdrCQnaOH899f7FIwfMdvmPwHc7jZ0 wZ8Y0WcdvvVXhEAFRpcYtMzwrSoulbr69Ez311wLHhu3RYrqstQFGBLrU oRbFICO6NGHKT+PXGqmBd7IMPA4NUZ+u08RA5ZNTw1ZujaAmRgqSOBuqw +38SIBnI9qvryLsnYM2tSHQOf8GpUdWDhK6o1DvC9lzP5r1b5CCcXq/2d /W0h/tAMo09DHFY5zC0MJ6uQX19trwgXeQgY9uVhmX5PWc6oRr9NZJUo6 8RgZCAuzuDL8LdxAWu0EIIRoQwvoMDC2BK98+5UsZuH1XFpybMOtbtw/6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="229866655" X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="229866655" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 04:58:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,315,1635231600"; d="scan'208";a="534714161" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 25 Jan 2022 04:58:20 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 04:58:20 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 04:58:19 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 04:58:19 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 04:58:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LdL0gjAoUi0penfzPh2LG9Ea3vXLlcJvzWpEu5/YEjCVzc+/gC/vHteDp7css3PUGtt2y5pMBexoGrYlyiSG9hhrgLBSgXhw15EVTrNKXpfjaqgoCVfMJZwxC82K4uWidIkYqQ2swW3NTIEpoDlZYUCH/1hXb56LItI7zF+Cqx+Fae4Njk8gck+9LbnwNe4w+mJrFleTy8JZ2p9vZnBYrI8vJcaoiY0iB6yJiarOmH67Bv1ctVijWEwGW2jvGeWtrFSCleQ73ONSZIWdFEp3GjK8vOfUrVShBrlUDbS9oxDVaIpPdRjC+wg9w5xuxQQLbAo+bV7rAjBFbndAAKQG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5GAIH8PmMNhuWkJZeBqXFegCUKtYya6hq7jXp4n57aw=; b=Nr/RyKCaW9aUpQx0LVc0ad16DnrTzsedpJ34YSPsYy7nG4s1tWTg9mdGsvD5xHpNV1IUvy5WVgj/HgssQtmuNuWbsFZz5sX5GYzQIZe9c9NKVfNhDZneO5z0dXjVTO5Jnilj0v767qMMajuBq3LyNpcuYsEEduGsz3cJs2BaKfm5YDA3irB1LMlgX9uIBJYcsEm/xRUSiVrA4ipVeDBZ806VVWaCj4g3M6koxk3ypE+RuhB+C1yAoPCyEz+WaZ2v65B5k3u5XaAqjX9rEsLQVCJNUtcC3oyXrLkrHHGKqAgXqUwDEJ2dahxQfRX3Sxr24yD2qF2vCh5yz/V6edREtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by SN6PR11MB2896.namprd11.prod.outlook.com (2603:10b6:805:d9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Tue, 25 Jan 2022 12:58:18 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5097:78f8:816f:f243%6]) with mapi id 15.20.4930.015; Tue, 25 Jan 2022 12:58:17 +0000 Message-ID: <26ee0578-d8b5-8280-9f22-2d539acdde51@intel.com> Date: Tue, 25 Jan 2022 12:58:11 +0000 Content-Language: en-US From: Ferruh Yigit To: Ajit Khaparde , Ray Kinsella CC: "Min Hu (Connor)" , dpdk-dev , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Thomas Monjalon , Andrew Rybchenko , "Loftus, Ciara" , Ciara Power References: <20220111115437.32855-1-humin29@huawei.com> <20220112111424.20594-1-humin29@huawei.com> <87h7a9p3a0.fsf@mdr78.vserver.site> <553e64fe-fc14-31fe-cdc4-efa1785e6930@intel.com> Subject: Re: [RFC v3] ethdev: introduce ethdev dump API X-User: ferruhy In-Reply-To: <553e64fe-fc14-31fe-cdc4-efa1785e6930@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0156.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::17) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e9d26c5-5dc0-4334-b6b8-08d9e0025b4f X-MS-TrafficTypeDiagnostic: SN6PR11MB2896:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w6oDFMvsHyZkJk07GXlG2nO70dOQUTNV6fxcLaoNcAnJPmaLvopLrSWaTVMWhc6lk3zGU9F2DFJ5zWOGXsnaa6GcmshkpY1wOjStAfGUT2pkdzpkKP1KRJW0JA1gO3TycIxcotBczRZWZS1cHZH4Obkv5O+Wb39yOHoTLyixtqnfpCb0P2P2DIgKoeadOiZgnGKeyESlnLQYNBPUwrntJBgoinlc5ldvdQHGo1dJGkfpOHpujAutsYTpLCel4MMDBnV+M1k6KB4eiHEhfJNlxIZ92GPYw333Tr9PtQjtTpvFy0YwryUt3SrSEFvO6WLjWdhtrvqipVqyrNTdMKRkM9xKSuB4qPOwxPnChrET56jS2WSxa2qqlZwgbNpVfAYNrLF8S6+3cz51orS74H5O4lTY4WWSAdYfcrISrg37cgh02a0SAH2is/vbZ4ZJROWwvcHOdBbP7Wc+C/9J8d1R1kdY3LfcD+152/YIFOqTstIANYuXF8TdXs0ZZtB9OdjLc8abyWA02YaYHPzUY2ClMK1qTL3WVgrAIDfIhEQ9NswvbDauK9sAH13a/C4qrMy53UooNHXB/7JE/F2kBJFtVWfDpekk87PjgEzxdImRMIdTCutw1E20uQPQT4vMhG+V6unl+RbNUoNaa3Ls9ux1iEG64tfeHcWC0FLaTzHDZ6eia6RznxMi7IGt3Mo6kfCiWebit4LofwQNAhCBe/pKqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(36756003)(6512007)(8936002)(54906003)(44832011)(316002)(4326008)(107886003)(26005)(6506007)(508600001)(186003)(110136005)(31696002)(8676002)(6486002)(86362001)(2906002)(38100700002)(6666004)(66946007)(5660300002)(66476007)(53546011)(66556008)(31686004)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlU3eTFBcjlFb25SQ3ZNbWg1VlYxeDNxVVVONm5IOTduTGIrMlN6RGNFQ21j?= =?utf-8?B?YlFVVWJHM1dYakt3TmFoV0xhODlKV0JxQk9KclZEK2pla2lBam4rbGNhSE1q?= =?utf-8?B?MUJ1N0VGTVRUZ1d1dWtzK0hOTGo0RzF0QjBHbjkwV2xXZ2E0T1c2bEk2MDgy?= =?utf-8?B?ZmNlTDBlaDBRV0ZwMENwUW1IeXRYaFlWTmE2UExNNEtQdmpwWCs4Mm56dDdi?= =?utf-8?B?cUtWRFdGd1Y1SzdKeWUzV2gvSlJybFpIVURPN0RpVlprYVVPcUR6azJwY29j?= =?utf-8?B?cDZuUjlvUkVrT2Q5L1lSMVB0MXRsbURSc1YzaC9KdGdjYnpoeCtNcnNJNHJU?= =?utf-8?B?OTM3c21zUERySXRNQ3oxSUZIWmpMWDIzdEtWbldDNlVya0lNZ2lXVUZRc1Rv?= =?utf-8?B?dXBZZWtiMFFOL1AvMU1Ydjhya0tjakhINlgxZFdYOTc1UEFTdlcxWW4zVjkz?= =?utf-8?B?ZEt6dkZZdktQM0orenRyZ3RuLyt5bFgyM29UL09qOWM4akdtWS9HSWYxOWhp?= =?utf-8?B?NndIN0lyQ3lJRGRoK3VaeWpzWnhqMnNicnhpUWRUUVhYaytGSytlbVo4ekpq?= =?utf-8?B?Q1dCR0lTU1pBRUw1UHVEcUhUMFFBcXdnQjRNVDRDTmZjRDgrcEZoNStjZXZq?= =?utf-8?B?MFMvLy85eEl5cit0WnFuSHZiUWluWWFBOUd5akYwTjhOL05xSnZWaGVhRzNl?= =?utf-8?B?SVRFS2V4RXY1T2ZUVHl2dGovdFdiR0pJbmZuZFQ5Mm83S1NGNTE4VzQxTTY2?= =?utf-8?B?TmNEc0o3Vy9obE5mU2NlNDVQWGpsM0RDbHQ5OXFTNDZDeVJFZ1FqeGZ0K1BZ?= =?utf-8?B?clgvdmtHMzBpKzg2a3BTOFQxL0s3c0w4VGZjQVJoS2hCT0hrdStzWTU2bnll?= =?utf-8?B?eC8zdFNvYWk1K2ViSlNuc0tId1pQZno0c2pMVDdhaGJ3aHl0R000aThObFRU?= =?utf-8?B?M21JT3Eva1YrSjkzcFZTZHB1VzVXZGRuSERXOGRiZ3JPdTd6b2I0L21RWHBy?= =?utf-8?B?Y3BzSGhwdWVYUkNTb2xIMitPS3hnZUNWMk95QkdpVWpBQlozQ2luM2o5ejFq?= =?utf-8?B?UVlhWlhjbnBsbTAvdjFSUFlrSlVpSnRyVUdCckpXcS9BVWtmZ1RrNW5QWXI1?= =?utf-8?B?MExRZXZYRmFLNkowZGt2MHNQRHZzakdia2c0dkJDdUVNckZoaE5rZHM3MFJ6?= =?utf-8?B?TFR6TzNlTzk4djBQNTRCeDh5cWR6WmJtWmtaL0VOb201TUh0aUliZU9md2gx?= =?utf-8?B?UFFRM1ZwdUR3TFJ6aVZ3aFVBV05wWkp4aGU1WDJpZlc3ODhlVkt1NitCSlpJ?= =?utf-8?B?TWw2aEl4dVVtR3BsQXVoVVF4ZUwycVdFTzV0K3ZITG5wV2JHek9ZcHg3dTlp?= =?utf-8?B?a0swT05jcHkveDZLVFFFd2xyUkw2aE41OFRNNmVweXRJbDdEcjF5eWs3Zmww?= =?utf-8?B?NGRkVnVVOHZycUdJOE1vd2JtWDRVclo5VWxZd0d2T1Z3ZldIbnZ4eGZVZjZM?= =?utf-8?B?cDU5MkR4dXZidmFhTCt4Mk84VE12Mi9WREdEdXR5NmlFNGNmU0hqUjRPSTJR?= =?utf-8?B?U3FvamZNVHFRVUFzNUNIQ0lMODduTHhoeG16aXRjck5zZHNRSmxzcGFDUU1U?= =?utf-8?B?aFRqWE45alRHcmY2czRaVzhXNVhYZzJFSUFTWDhzTGFxb3E4bmtsRUNrSFcx?= =?utf-8?B?VTBBc3VaWXUwNHAzSmNwTEV1c3VQVzdja01pQUNQNFk4MzBCaHdjRGdFSkpY?= =?utf-8?B?SGJ0M1dQemZPdjJIRW52ZFBIZTBibG9iK3Z6dzVwYUtid3FEN0xsWVFEWkxU?= =?utf-8?B?cDZ6by9xbWNtOERsVHZGOUduaFFhSDBKbjJDQzZCWlV1dUYzY2xpTXlmSTQz?= =?utf-8?B?SVc0bWJjT3JjaE1JVDZ6VWNyS251ckg4dXE5TE9tMFltSStYTFpjTXJsZjJ5?= =?utf-8?B?cWFCWThYMGN5Qlc2NkFKT3YrMkFkU2lLZm5uUnJDQk1lS01BdTRKYkVVakx1?= =?utf-8?B?Nk40YkFRNDJDWWZKR082ZVNVZWc4Z2NLdzdKblIrZ3pDbHpMR0NrT0dRd1A5?= =?utf-8?B?MkE1UTErYi9sU21mWWxoWmZOZGJnODc3ZUw2bUtJaEF4bmk3WTBXb0xtM3Rw?= =?utf-8?B?WmNBcDgvV3hYenlVMEY0UTZTVUJ3ZmdVWWRWWnl2bVFQTmY1cnFGcjNTelR6?= =?utf-8?Q?uqdDKZ6JBiePDhTTh2L00MM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5e9d26c5-5dc0-4334-b6b8-08d9e0025b4f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 12:58:17.8642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UQWFSZl7iLlrNIcfW+hMX8+wTauV/h/XEB0As8bVzF8tqYbJ1L5gPZPmVfdANnwUalm3SCpgoER924w+Nirbbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2896 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/25/2022 12:56 PM, Ferruh Yigit wrote: > On 1/18/2022 3:34 PM, Ajit Khaparde wrote: >> On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: >>> >>> >>> Min Hu (Connor) writes: >>> >>>> Added the ethdev dump API which provides functions for query private info >>>> from device. There exists many private properties in different PMD drivers, >>>> such as adapter state, Rx/Tx func algorithm in hns3 PMD. The information of >>>> these properties is important for debug. As the information is private, >>>> the new API is introduced. >>>> >>>> Signed-off-by: Min Hu (Connor) >>>> Acked-by: Morten BrÞrup >>>> --- >>>> v3: >>>> * fix comment. >>>> * add rte_eth_dev_priv_dump to version.map file. >>>> >>>> v2: >>>> * fix dump API name >>>> * adjust description in doc. >>>> --- >>>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++ >>>>   lib/ethdev/ethdev_driver.h             | 17 +++++++++++++++++ >>>>   lib/ethdev/rte_ethdev.c                | 15 +++++++++++++++ >>>>   lib/ethdev/rte_ethdev.h                | 16 ++++++++++++++++ >>>>   lib/ethdev/version.map                 |  3 +++ >>>>   5 files changed, 58 insertions(+) >>>> >>> >>> Acked-by: Ray Kinsella >> Acked-by: Ajit Khaparde > > > I have a concern and this "private info", it can be useful for debug > but still it will lead to a PMD specific applications, I wonder if some > common information can be provided. Is there any list in your mind what > can be part of this private info? > > Also why not use existing xstats or telemetry to get more data from the > drivers? > As synced with Ciara (cc'ed), she mentioned more information can be get > via registering callbacks to ethdev. Opps, Ciara (Power) cc'ed now.