From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 435261B113 for ; Tue, 12 Feb 2019 15:47:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7B1A23695; Tue, 12 Feb 2019 09:47:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 12 Feb 2019 09:47:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=7w1Y6A+djh+pIH6VKxBlnIxL9E62J4w9JJIcT7DP0I8=; b=JPa0A3PdR1KM vy6rb5kjtKAzdlK00RGI6wOScONRQJ3hxCk582137qf4/DLalukmvavX7jIRFdq1 ZRdpl/iJv4BEHsNspb71uWF/0407UxUUkjWMkUo27+Kx/DqEA0lZ73j1VLXrR6c/ 9/vqVZwHB9Djfcwn5IX40fw2fCEz8WE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7w1Y6A+djh+pIH6VKxBlnIxL9E62J4w9JJIcT7DP0 I8=; b=fgWGVSu/Xde7/lpgUrOUrgfcg8hQCwBwdzjYt0+WYhbxQKe2w2gjxbXjQ OBcDozxfpYiJ0c6z0aNl7l/Nw/4MrxcWYawjIFYyWY+e9/F7Se6pYBvVAL2Q/5d+ /iSKqWULBL61Jaf1f8gdjeBQo2PhP1B45c4HzWBJ09Qs4roTh9NAL96FpprC0ccP is/peD8x9uR41ERqaXnxK7W6ogskaBnEu62vf972f+wQhdHokVXEOezLWdt9+WPn CiJ3YAYzM0cpfUmZSOyEm4xqoakr4HRkIK0O/5HjGDY2S5PGeo+o4elYLb4B8iyT dakKu7Hvxt8nYsv684OOwcBjrAq9Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtuddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5A9A10310; Tue, 12 Feb 2019 09:47:57 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson , Luca Boccassi Cc: dev@dpdk.org Date: Tue, 12 Feb 2019 15:47:56 +0100 Message-ID: <2701171.9Cy1FB2YhE@xps> In-Reply-To: <20190212114319.GB517812@bricha3-MOBL.ger.corp.intel.com> References: <20190103175725.5836-1-bluca@debian.org> <3010506.HFqD7W5Z4o@xps> <20190212114319.GB517812@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 2/5] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 14:47:59 -0000 12/02/2019 12:43, Bruce Richardson: > On Tue, Feb 12, 2019 at 12:36:17PM +0100, Thomas Monjalon wrote: > > 12/02/2019 12:31, Bruce Richardson: > > > On Tue, Feb 12, 2019 at 12:15:43PM +0100, Thomas Monjalon wrote: > > > > 06/02/2019 18:08, Luca Boccassi: > > > > > Whenever possible (if the library ships a pkg-config file) use meson's > > > > > dependency() function to look for it, as it will automatically add it > > > > > to the Requires.private list if needed, to allow for static builds to > > > > > succeed for reverse dependencies of DPDK. Otherwise the recursive > > > > > dependencies are not parsed, and users doing static builds have to > > > > > resolve them manually by themselves. > > > > > When using this API avoid additional checks that are superfluous and > > > > > take extra time, and avoid adding the linker flag manually which causes > > > > > it to be duplicated. > > > > > > > > > > Signed-off-by: Luca Boccassi > > > > > Acked-by: Bruce Richardson > > > > > > > > This patch breaks compilation on my machine with a lot of strange errors: > > > > > > > > from drivers/net/pcap/rte_eth_pcap.c > > > > > > > > /usr/include/stdint.h:109: error: "__INT64_C" redefined > > > > /usr/include/bits/stdlib-bsearch.h:32:13: error: cast discards 'const' qualifier from pointer target type > > > > /usr/include/pthread.h:682:6: error: 'regparm' attribute directive ignored > > > > etc > > > > > > > Is this on Arch linux again? I just reverified these first two patches and > > > they work fine for me on Fedora (I assume Luca probably tested them already on > > > Debian) > > > > > > Anything unusual about your setup? > > > > Nothing unusual. Just using the best environment ever ;) > > I will try to debug it. > > > It may be something pcap-specific, since pcap has to have it's own special > query mechanims outside the normal pkg-config one. If you remove the > pcap-driver changes, does the rest of the patch work for you? Yes, the issue happens only with pcap on Arm. Reverting the pcap related changes, it builds fine. More infos about my setup: meson-0.49.1 aarch64-linux-gnu-gcc-8.2.0 libpcap-1.9.0 (32 and 64-bit) for x86 I think there is a mix between libcap for x86 and Arm compilation. Probably a meson bug?