From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA89D45DF2; Tue, 3 Dec 2024 09:51:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0D9040264; Tue, 3 Dec 2024 09:51:23 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 4F50F40261 for ; Tue, 3 Dec 2024 09:51:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733215882; x=1764751882; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=8nnK9Bru7IMNa31SrXKqnEnaj5G14pBpW1GwPXmp2vQ=; b=XeEr+2daY7v0I3pdAi4ibuhrNEBmAfUgAIDQWVSJs4uEE7qpMUD8r2UU s1hXG7CS+NCRMRMR5bVfF5x191Ju3UdPiEYc0eaPcbPS09lMT5MKpylSE wD8nF/TxazgKt3g3kN63BaD/U/YWMeuBi24KWpMGNOJHlP7Dhre0pDua3 V6lzSlbK7E60MiP+5kYK41/jpgbcsyRNPepoXtf/ZN/MLz8wuQwXSI4rb JCkA/LkeDIwo4pYjlmNwUSUIJLY3+hHd4thQ98AUZ8zcHY00EpGAZsGFj tBxx7SxKpWZX8HfaL+FAykp8NndI3LQ5FicdCcBwKx7+9hEwe0hPEr40g Q==; X-CSE-ConnectionGUID: lXvEHWCSRkmRf28j88qGLg== X-CSE-MsgGUID: JJI4cBs/Sg2O3ykFZgHQdg== X-IronPort-AV: E=McAfee;i="6700,10204,11274"; a="44444803" X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="44444803" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2024 00:51:21 -0800 X-CSE-ConnectionGUID: D/PAoPEiSu2FcGDCiCvRMg== X-CSE-MsgGUID: DiUuHJ7PTaqle/7+dBGbqw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,204,1728975600"; d="scan'208";a="98371661" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Dec 2024 00:51:18 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Dec 2024 00:51:18 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 3 Dec 2024 00:51:18 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 3 Dec 2024 00:51:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fHR9g3PH7iuZuo8lXhLKumq/+vqdeT5H/LTxaJvUxeP5fFKhRXDoYZ8ZYZF/vtsCrkGFaxvfukosmFsl4zHrnV5BoWKpqJB+rf47O8E5bweVkPX/zYx1B4ctU0asimPNahAlHmNLtmBjBlZfEEw8GbZpUhvgZgLSO4lP7kHPm9oPHrszS6490YEEv6T5Fyzu4fXw8aEfJXhe3knTAtjsCJC/0VtsdQRcLLm/tME5unTKX/BgwIdIDep08SNOIeqCOl5XcFdXwnUxuf/9jDOqUUmt73arU9bpHd3hESK1OFXGAE4tvYzk4HmUGzFk0S7qVfhNtyY1UekeiIlMvn0DKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qw6uHnk5NCMbXCcmMtKiZjFcElGyY5wAVlsoH2WuUNM=; b=vibkTy0mmSswG+vXM4vuTgqbp6N9Bh46lVYycmL9qXSzKGb81C1DoAkP2FVNWt9P70wcAYaQIaOateTJ6YsCk+LB6BSZK1DxDHrH4MKBmxGgGS+r3rEWnmS/2jpIW/4+pO9QXvbVqx0/f7djlcl6IkdkQM2DnVdazwZlouIOX4Icxmyj7EpQWcjYZoKpCtgAmj3i4z6hkXaxPCb95qWcPu9Zb/k8IcPk9HNsLnEveI1iGHyiVJy8U05V/qA6Fo3jZp9MIeB6GfApTQjxHOA/hDaZ1HcjYhjctEFy2UNEloAwKCueCTJ8UOSbwPVrRdb95LLPXJPw3IeH/M5jO6X3rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH3PR11MB8362.namprd11.prod.outlook.com (2603:10b6:610:175::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.18; Tue, 3 Dec 2024 08:51:15 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%3]) with mapi id 15.20.8207.017; Tue, 3 Dec 2024 08:51:15 +0000 Message-ID: <270499dc-3b6b-48d3-8f6c-010cfbe51b5a@intel.com> Date: Tue, 3 Dec 2024 09:51:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/1] Rewrite devbind To: Bruce Richardson CC: References: Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0016.eurprd04.prod.outlook.com (2603:10a6:10:3b::21) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH3PR11MB8362:EE_ X-MS-Office365-Filtering-Correlation-Id: 8dcb5e50-54e9-4dba-5bcd-08dd1377a56d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Zkh4dXZPMGxBbHpGd2lyMGRzd1VRbU5KdE9sQjBDWlNxVE5RM0pGcFMxRnpX?= =?utf-8?B?QTVESi9maEcyYlBtcklaeUhqSVcrZVBVT3h6d1J6cFI5MS9kZTBDVFZoN0da?= =?utf-8?B?ZXdLemRxZDJEajVaYUozWEZzNGtEbmhOYk1xL2pPNUFmV0hzSEIzeGNQN1Ja?= =?utf-8?B?TkwybitvaVBsSW9MVGJsWnFUUjRFNlFwRGkyWWMyMnlDSXVXYmhWVFBZbXdl?= =?utf-8?B?TW1WQS9IN0t0RURUMFhxMDkzMVhVcEJYUDkwelN0QWt0WGlhSnVRRnJOMDN0?= =?utf-8?B?dTZReTFwUEV4T3ZNNGJvZU04c2ROMUUrajFyM21FdGR1a0ZrcXdQOHFPQ3Nj?= =?utf-8?B?dUdid2FrQXdLMkdWUnVYWU9wYy90b3E1SVl1WWIwUGJWeGo1dUJtQzVDTUZS?= =?utf-8?B?VFhZK002bnp5SFNWM3VIb3ZPekRFWlRqcjJOVUtOeHhUL05TOUNPMHpxMjBM?= =?utf-8?B?K2dWTDAvaWo3dUpja1dyTWk0WUZ3dFZmZFBkcGs1YnFzT3k3YzdCSHNBM0U0?= =?utf-8?B?UGpyamFvQkdZa0Q0dERXWDZ2WkordTBGU09NejdaOXpCUm53WmM3akEyNmdM?= =?utf-8?B?YUNkM252TWM5ZlZKdUgxd3RGZFN5U1hhN2sxcmtnSDZicko2RVhvQUtnYWo4?= =?utf-8?B?dEMzcVMwL1djajRKRVQvbGFEd0wrbmpLdDJ0bkpvWHRqVmI3WDdHckptYm01?= =?utf-8?B?ZTlmdFNCUlY4YmlFaGlyTllpL2dxNFNOMHA2b0IyR28vWE1BYkN6dGR1OXE0?= =?utf-8?B?UUtYd2x6OVAzSnZJeDloYS92N2xyd0xWU3FrdU5FODRxaXBlNjVvQml0TUla?= =?utf-8?B?TFQ0eW1YT3NPb2hWalJvODVHWGl1ZEY2NkJLWjkwQTQ1cjBxN1p4MW43QklI?= =?utf-8?B?VmRiUzVwZlRjT2FmVGlhQzc3cWFJM0UwK2o5WGRnTW9pTlJIMWNKa2FNU1Jo?= =?utf-8?B?OVJ2OHlPbFlOSkVncDNXZXRiTEZiMkRTeTdQSnpQV041OVU5aHh1TXZxejRy?= =?utf-8?B?VXJYWDJ5aklTaFZCQnVENTN5NDZOc0lvazdpTXIvWkxsWnVCL0hsWGpXSWFp?= =?utf-8?B?eVZ5eDA4c0xaMkRSb0dTejYwdWtmV0pNTUhWaHV0Q0FPK0tXRjI0bnByaXV3?= =?utf-8?B?Ykl0eEJqZ0E1eGxVRG52elBUeWJ6UFgxaW40cDVBS2Y2NGduV1RmNWJ0YTJm?= =?utf-8?B?Z2t5ZDFkNjBIeDE3amZaSG9iU1Y2NWFNcEIwQy9XTGJrN0ZINnNoYWlmdHVG?= =?utf-8?B?c2ZTeTNjTFpPQlRqQjcwZCtsaGh1NGc3VDJtRW5RcGl6aDhSNzM5N0VIeXJC?= =?utf-8?B?S0lXZThSV0tXS1B6NDFUdHM2KzBnbEhCY3NZaXZQK29MaXNndWFIcUltd2dD?= =?utf-8?B?WHZSUjZlWWxDMGx3YWtlVGFTTzVxcys1bkl3Qk5qMWdHRFllS3FuSE5SNU1D?= =?utf-8?B?N0xidlhocTlSL3ZKeTBTOVdYSE1xNEVKSFQzZmxPa2k0R2YxQUhyUWpwamlB?= =?utf-8?B?cGNlajlPMW11Wnl6RWJUQTNMSk1ITEpnd2RaTWRDWWlzNW9JQXdaSk5pOVdP?= =?utf-8?B?UklxOFZrNmp4SjlTT0h4T2g4MHJHeFRHWjE3VHdISDZNZDA4azVya2VGTkh3?= =?utf-8?B?QXR1WjlUZjdTTEh2ZG1Ka1dKSS9vOEI2RTd1bm5sTEpYMDJESHZ0a1NqcW5z?= =?utf-8?B?aVkySzRYa3BNOGNVajRNcURxOVJyTGcwTHlnbDZ4bjRPQUxDd2VwRUdkL1hy?= =?utf-8?B?TDRZSUEyakc2Wk80UkhEdlQ1czAwS1didDcwK1pRak9lbklUa1F2WUNOeGNk?= =?utf-8?Q?ETAllUdNfU6NmZdCDL1F68rhq6AFqfn0Z3uiQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckhwT0kxOWJwaFprZmtmQjBKZGdkRnNvaUNWaTFxdWZEQkFoQ2RlQjJUakNB?= =?utf-8?B?N1dTUVlRTGFkMFFjVW84UlVqNjhWeDdUUkE3amNnSjAxVlUxRGh0eUY0UG9K?= =?utf-8?B?TTBoUStTVy9sd2svcmVZQ0Izd0QxRS8ra0hjeERvSjUvdEJZcG1ZUzI0UXZp?= =?utf-8?B?NS9qc1hUTG10VlBoVkpNNFVKc09Help3NlF1WmxnZHhZR0IxaVA5cUdSWEc1?= =?utf-8?B?VDBMWnB6Qy8yVWJ3bmRxcEZzdlYvOTl5MnFma2w2Rk1nSVdSbkFxU3NRSWZz?= =?utf-8?B?b2hhZ2RpRE1JUXJJTTVjZXRHaGtWaGN4QTdUNGdZeW4veXVOcFB2UkppbVFh?= =?utf-8?B?M3pGbG1qbkhVWlZ4aXFHZGRlTWtZcUFERnFPZGxOUjFPTUdSWVI3ZFBKNldY?= =?utf-8?B?VGVpMGZrNHEyOW83d096dlJwNDY4NllnQjd4ZnUrdVpKS1dMWEJFM28raGZC?= =?utf-8?B?aWtTeUJ5MVczT1EvVnFhdTBVNi80cGtFUW1lRmdyU0paOElnZzJGdFYrckVj?= =?utf-8?B?dTJtWFBTZlhncWVuQ0hPNWlycVNPd0xrUWNSeDJPbWc3VUJrM3RlVGVRTEE3?= =?utf-8?B?UWt3ZW1RcTRwMmRTNTUvRE82M0grTzZtRitML3VURzllaGRLcXpvVW1Yc1FD?= =?utf-8?B?RGw5R2dFb3Q0WUwrWk40YkdNQ1F6UGZ0anZlMXcrM3l5NlV5SHBrMS84Mmho?= =?utf-8?B?MlEwNlllanlRUXBrTCtyZWFFa2Zxc1MvWTFoalgzVHN2TElhQlNHU0RsM2ZD?= =?utf-8?B?eTAwYnFmMXlGbFYrWWhXeGNNUnVxRnZ0WEtrUFlIak9kM1ZmSDJva2lnUnNL?= =?utf-8?B?emxpTjQ4eGh4QU9scEpuVjR1L0tvbS9DeEFSU2lZZE03U2xHR01CSndwRURQ?= =?utf-8?B?b1EyK1Jody9XWlhPdjJINytZN0U0UyswcStVbHV1Q1ViWXd2UlVxVXU3bHU2?= =?utf-8?B?R1A2Vi8yczFyOXh5SlFiR28zNTNKV2pRMkU2TG5ueXB1Yi9qTEptQ2xQZjFC?= =?utf-8?B?Y1FZMkxheUt1WW9zRE5CbHhCczkyZTV1RTFhNnpsWUZKQVpYb1Vnc2JtaVFk?= =?utf-8?B?NEVQdmRFL2pyVkZRM0gzSVh2MG1uaTFQRXNtRVMxeStNaEo2Q3VqWjZtRi85?= =?utf-8?B?QzgvQVd6Wk1WUE02WDFxTE9ZVXdxVFRpSEI1bjFUS01NVXZGTE8vK0J4dzFM?= =?utf-8?B?cjZnRkxZU1J4eERzRHM0aW5ia2d0UkxyM1M4OWNROUIvbE1KcDR3ZGNta1F4?= =?utf-8?B?YUFuRlBzeW5EWWhMNmlBQW5zcW1FcWxuY0UyY0lTaDVCOGQrWVJvSlpKTWEv?= =?utf-8?B?TUM3VW0xU2hZWkdreHNyaFBZaTM3UndMb3I5cGlNSERSbUltZXFQWUd2aWpW?= =?utf-8?B?NUFoN1hBTnB6SWdMNExsS1Zvd1NIV09EbUprMGFvbzVFb0tSV3pCZ3RXZDd1?= =?utf-8?B?bklQMGN5UGVXeDZrcWFwWXg2amljZXdPSnU3WE1LZlpYRE5oaTVkKzFxd21s?= =?utf-8?B?QWxSQ1N2akE3K1JHWnI3M2FYaG9kWVNwUllhbCttdHZ3TnJXRUU4SmcxajJr?= =?utf-8?B?REIyLzVJclNiVGJOWnROeUhESE5JU0k3U3JhcHNYRElENTZpYm5aNGpKZkpI?= =?utf-8?B?TUNNZDVEQVh0UFNEWlZjZXlqd1VWY3MxOFd3MkhXZEdzTUFUMkhGYVMwSzNu?= =?utf-8?B?TzRkNDF1OFdIR25tTjlRY2o4SmNsM09NMXNCY2tYVEx3UjdqeUZoZS9Wb25W?= =?utf-8?B?Uit2T0J3QmZQR0FHaFB6Tlp4WHNOLzJucElVVTFzTGtzd29KUWRpQXVKblcr?= =?utf-8?B?aFA1ODZ2Zk9ybHNyL2UrL2hUS0ZXUTRIcjVzRFBud1FkZDdhdE82RDlZQngx?= =?utf-8?B?UGF1WFdiMHM0cGpEUnAxc3lvWDlKWkRjTEtCS1JaaXRHZzVnUFFlZytXTU55?= =?utf-8?B?cno4aGZ0THVpZXUwelFlVzJmWEY1K3VtYWhRa1M3ZlB6b1gzN1kzUUZ0SE41?= =?utf-8?B?a3ROeW9FbjNxd2d0MHc2WDlLcmVubUV4UGY5dlVTYTkrZlpEeU5VZFpLWlEv?= =?utf-8?B?bmI3T21uOVBzUHZCaU5CTzNPK1B2d1daZDRYcnZIMEtrNDBQdEg3Nm9wYVBI?= =?utf-8?B?eEFPWFhaaHdjUFFoeXBBa3VqdEFtWjFTQ1JVTnA0cGd0eUxTeWR4UmZ3WWdl?= =?utf-8?B?a0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8dcb5e50-54e9-4dba-5bcd-08dd1377a56d X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2024 08:51:15.6363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LyanmPUoLIzDGiFGO+HNPbUtnvhWgWVV1ACwoNWWkIdms9buVNHC3DM/lLK3pDxm+v4Y78ytMVD+0S/UfuFLvbRJ2KBBHSR4/BGXSAhqj0c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8362 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/2/2024 5:14 PM, Bruce Richardson wrote: > On Mon, Dec 02, 2024 at 03:09:33PM +0000, Anatoly Burakov wrote: >> It has been suggested [1] that a major cleanup/rewrite of devbind would be >> beneficial in terms of long term maintainability of the code. I was in a >> coding mood over the weekend, and so I've went ahead and rewritten devbind. >> >> Note that this is one giant patch, rather than a series of patches adjusting >> existing code. Making it a patch series is possible, however the internal >> code architecture diverges quite significantly from the original devbind >> script due to its copious usage of string operations/pattern matching and >> global variables, so it is unclear whether subdividing this patch would be >> worth the effort. >> > One suggestion here which might help reviewing. Since it is essentially a > rewrite, is it worth making this a two-patch set, where: > > Patch 1: introduces a new script called e.g. dpdk-devbind-new.py, which > contains just the rewrite without any of old code. This then can be > reviewed in isolation > Patch 2: moves dpdk-devbind-new.py to overwrite dpdk-devbind.py > > WDYT? > > Regards, > /Bruce I think it's a good idea, provided it gets squashed on apply. -- Thanks, Anatoly