* [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
@ 2021-03-27 7:36 Min Hu (Connor)
2021-04-10 9:11 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-03-27 7:36 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, kirill.rybalchenko
This patch deletes the comments which are wrong and unnecessary.
Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
examples/ptpclient/ptpclient.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
index 33b297e..878d1a0 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -606,10 +606,6 @@ lcore_main(void)
unsigned nb_rx;
struct rte_mbuf *m;
- /*
- * Check that the port is on the same NUMA node as the polling thread
- * for best performance.
- */
printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
rte_lcore_id());
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
2021-03-27 7:36 [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments Min Hu (Connor)
@ 2021-04-10 9:11 ` Min Hu (Connor)
2021-04-12 8:04 ` Ferruh Yigit
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-10 9:11 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, kirill.rybalchenko
Hi, Ferruh, kirill and all,
Any comments about this patch?
在 2021/3/27 15:36, Min Hu (Connor) 写道:
> This patch deletes the comments which are wrong and unnecessary.
>
> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> examples/ptpclient/ptpclient.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
> index 33b297e..878d1a0 100644
> --- a/examples/ptpclient/ptpclient.c
> +++ b/examples/ptpclient/ptpclient.c
> @@ -606,10 +606,6 @@ lcore_main(void)
> unsigned nb_rx;
> struct rte_mbuf *m;
>
> - /*
> - * Check that the port is on the same NUMA node as the polling thread
> - * for best performance.
> - */
> printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
> rte_lcore_id());
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
2021-04-10 9:11 ` Min Hu (Connor)
@ 2021-04-12 8:04 ` Ferruh Yigit
2021-04-19 7:42 ` Min Hu (Connor)
2021-04-20 1:02 ` Thomas Monjalon
0 siblings, 2 replies; 5+ messages in thread
From: Ferruh Yigit @ 2021-04-12 8:04 UTC (permalink / raw)
To: Min Hu (Connor), dev; +Cc: kirill.rybalchenko
On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> Hi, Ferruh, kirill and all,
> Any comments about this patch?
>
> 在 2021/3/27 15:36, Min Hu (Connor) 写道:
>> This patch deletes the comments which are wrong and unnecessary.
>>
>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> examples/ptpclient/ptpclient.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
>> index 33b297e..878d1a0 100644
>> --- a/examples/ptpclient/ptpclient.c
>> +++ b/examples/ptpclient/ptpclient.c
>> @@ -606,10 +606,6 @@ lcore_main(void)
>> unsigned nb_rx;
>> struct rte_mbuf *m;
>> - /*
>> - * Check that the port is on the same NUMA node as the polling thread
>> - * for best performance.
>> - */
>> printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>> rte_lcore_id());
>>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
The comment seems left over from the example this example cloned from..
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
2021-04-12 8:04 ` Ferruh Yigit
@ 2021-04-19 7:42 ` Min Hu (Connor)
2021-04-20 1:02 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-19 7:42 UTC (permalink / raw)
To: Ferruh Yigit, dev; +Cc: kirill.rybalchenko
Hi, Ferruh and all,
If no other comments, could your please merge it into the
branch？
Thanks.
在 2021/4/12 16:04, Ferruh Yigit 写道:
> On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
>> Hi, Ferruh, kirill and all,
>> Any comments about this patch?
>>
>> 在 2021/3/27 15:36, Min Hu (Connor) 写道:
>>> This patch deletes the comments which are wrong and unnecessary.
>>>
>>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>> ---
>>> examples/ptpclient/ptpclient.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git a/examples/ptpclient/ptpclient.c
>>> b/examples/ptpclient/ptpclient.c
>>> index 33b297e..878d1a0 100644
>>> --- a/examples/ptpclient/ptpclient.c
>>> +++ b/examples/ptpclient/ptpclient.c
>>> @@ -606,10 +606,6 @@ lcore_main(void)
>>> unsigned nb_rx;
>>> struct rte_mbuf *m;
>>> - /*
>>> - * Check that the port is on the same NUMA node as the polling
>>> thread
>>> - * for best performance.
>>> - */
>>> printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>>> rte_lcore_id());
>>>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> The comment seems left over from the example this example cloned from..
> .
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
2021-04-12 8:04 ` Ferruh Yigit
2021-04-19 7:42 ` Min Hu (Connor)
@ 2021-04-20 1:02 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-04-20 1:02 UTC (permalink / raw)
To: Min Hu (Connor); +Cc: dev, kirill.rybalchenko, Ferruh Yigit
12/04/2021 10:04, Ferruh Yigit:
> On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> >> This patch deletes the comments which are wrong and unnecessary.
> >>
> >> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> >> ---
> >> --- a/examples/ptpclient/ptpclient.c
> >> +++ b/examples/ptpclient/ptpclient.c
> >> - /*
> >> - * Check that the port is on the same NUMA node as the polling thread
> >> - * for best performance.
> >> - */
> >> printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
> >> rte_lcore_id());
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> The comment seems left over from the example this example cloned from..
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-20 1:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27 7:36 [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments Min Hu (Connor)
2021-04-10 9:11 ` Min Hu (Connor)
2021-04-12 8:04 ` Ferruh Yigit
2021-04-19 7:42 ` Min Hu (Connor)
2021-04-20 1:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).