From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BACC45D37; Mon, 18 Nov 2024 15:58:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1653440684; Mon, 18 Nov 2024 15:58:53 +0100 (CET) Received: from fout-a2-smtp.messagingengine.com (fout-a2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id 2CBCC40676 for ; Mon, 18 Nov 2024 15:58:51 +0100 (CET) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 8B1D8138063E; Mon, 18 Nov 2024 09:58:50 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 18 Nov 2024 09:58:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731941930; x=1732028330; bh=hi56t6SdD8yLup8DBlXnIcV8kUzCeU/dyXASy6snY90=; b= UGHGh3r8pb3kmgY7MjQ94CJVHdL9DiP0LKGFZpyksUHlCNQsq7WjRCf/Q49AdoSz cC26TeFnWZEAo7P965Zjk6Jsv4+pWYKPrWUB87F8QT/RmqrqChYrv+nuwDjFkqmX 1UojkAOsbH22IXfBFsehLzxBG5w1mOKNjaHPZhOOtTjvgLKMNvvjmNTQ7GQI7K+E bCclgdErE5rfNIMuMqgERS/6UvCeMpDEqPMbYoC7L+hGCBC7wbBUT0CLtnIEfr9r STzu7+DEbVqszhyjiklJV8TaZSgLExxyHNjZqKX5DUbQxD1uwDE36K6WGq+7+URV vQISHI0njKgGUR+Onoxfdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731941930; x= 1732028330; bh=hi56t6SdD8yLup8DBlXnIcV8kUzCeU/dyXASy6snY90=; b=S HlHFgsUANYgAu+YVOkwNgDK0eGKxk1VLdeTw5sjRXEDMJaodeT4BZEzfCBHudzje g71RhfpiOWUuownYIdggZHRINt1kC1todW9e8jugydHozDRKEFZiu5gliY3Ucl1B 24QJI/EKtVVIw2tTWCDXM3qcgx0VesNPfCpUBZMvDFUfQXIEgdFRrE9Ba6mgVTDV wxHNoMUF/Ts4TEZyrRKz7PWJvYGmBa/kAO7vG4LvmvhNkJkSLx8qFV1KpncC6Gas X5hTkVP50Vxk/jb679/coMj2hT+jimxU/uNexSEBZQGlIpESyDjnn4pYy6dcC1Up RS8VL543sRh7+RMgt5ykw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfedtgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeu veejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdpnhgs pghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepphhrohgpnh hitggpughpughksehrvggrlhhtvghkrdgtohhmpdhrtghpthhtohephhhofigrrhgupgif rghnghesrhgvrghlshhilhdrtghomhdrtghnpdhrtghpthhtohepuggvvhesughpughkrd horhhgpdhrtghpthhtohepfhgvrhhruhhhrdihihhgihhtsegrmhgurdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Nov 2024 09:58:48 -0500 (EST) From: Thomas Monjalon To: pro_nic_dpdk@realtek.com, Howard Wang Cc: dev@dpdk.org, Ferruh Yigit Subject: Re: [PATCH v8 12/17] net/r8169: implement Tx path Date: Mon, 18 Nov 2024 15:58:46 +0100 Message-ID: <2706952.BddDVKsqQX@thomas> In-Reply-To: <20241113092854.91445-13-howard_wang@realsil.com.cn> References: <20241113092854.91445-1-howard_wang@realsil.com.cn> <20241113092854.91445-13-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, 13/11/2024 10:28, Howard Wang: > +static u32 > +rtl_get_opts1(struct rtl_tx_desc *txd) > +{ > + rte_smp_rmb(); > + > + return rte_le_to_cpu_32(txd->opts1); > +} We should avoid using such heavy memory barrier. Is it possible to use a lighter fence or atomic API?