From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B414314EC for ; Wed, 10 May 2017 18:17:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4B03E20A8A; Wed, 10 May 2017 12:17:32 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 May 2017 12:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=p9/ckqYsZUzEEEu FWv7ZZuCL1hGln88MM/c0BHZp/do=; b=a0dpH0BCyC1yVSSn/+AxuuRzYXfYWW5 staLEBdEPJKo3dqmRyrgClSsVs0JzBJ66EZfWsTL7TCK8jgHI8/3UDVvHKjNqGXO w6i9q9uOp6DFikFkMUGSbhgM5yRdIdezx8QtyA1Gfnu0YdYEpUrVu/YXpow9qHpT SqO1dBjF/uKI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=p9/ckqYsZUzEEEuFWv7ZZuCL1hGln88MM/c0BHZp/do=; b=gIjN0vhf OWvTRVqtZZ4N3JmcJl1oqtjnNy9RO6lJGWR0P3LHDf8fcSMndNQZXpC/o/09q2q4 BVPztuI7vy5o8LpZUWcZkq6df6hjjdMhdvt6+qCEo+q3VQaIv8n73p8QMWKsFRdP N8KEFd+mBLCB74pkPhltbcxGHdtiObfiW6byyOpwLlO7DYEgHzzeShdis2fjNAZd DA1SGe+TxqhuSVxgJt2GncNn8YwOfKkSEjn6QbQDQQMa4AlceD+zSVTHY6ByQ9rI SpkP0zzA9F8KHy6uUmRXd/2cB1qaQri6Eq7TkPU2WC5/KzW5l0p1VHUw3sh9vHS5 ENdlzG/+qSBHIA== X-ME-Sender: X-Sasl-enc: h5QxRQ+OIuMzPJCOs2GB6AvSN3Ft6PA2eBVBc1D8iIAW 1494433052 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 129CA249D2; Wed, 10 May 2017 12:17:32 -0400 (EDT) From: Thomas Monjalon To: gregory@weka.io Cc: dev@dpdk.org, Olivier Matz Date: Wed, 10 May 2017 18:17:31 +0200 Message-ID: <2707890.iNWbliFgfp@xps> In-Reply-To: <20170510151310.20505-1-olivier.matz@6wind.com> References: <1802735.EECn92tGJO@polaris> <20170510151310.20505-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mbuf: fix bulk allocation when debug enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 16:17:33 -0000 10/05/2017 17:13, Olivier Matz: > From: Gregory Etelson > > The debug assertions when allocating a raw mbuf are not correct since > commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), > which triggers a panic when using this function in debug mode > > Change the expected number of segments to 1 instead of 0, and > factorize these sanity checks. > > Fixes: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > > Signed-off-by: Gregory Etelson > Signed-off-by: Olivier Matz Applied, thanks