From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id C3AF9316B
 for <dev@dpdk.org>; Thu, 23 Feb 2017 15:29:45 +0100 (CET)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 23 Feb 2017 06:29:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,198,1484035200"; d="scan'208";a="68734598"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137])
 ([10.237.220.137])
 by fmsmga005.fm.intel.com with ESMTP; 23 Feb 2017 06:29:43 -0800
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org
References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com>
 <1487669225-30091-7-git-send-email-shijith.thotton@caviumnetworks.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Derek Chickles <derek.chickles@caviumnetworks.com>,
 Venkat Koppula <venkat.koppula@caviumnetworks.com>,
 Mallesham Jatharakonda <mjatharakonda@oneconvergence.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <2709e18a-110e-ec60-e3f5-c9ad0de36f68@intel.com>
Date: Thu, 23 Feb 2017 14:29:42 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <1487669225-30091-7-git-send-email-shijith.thotton@caviumnetworks.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 06/50] net/liquidio: liquidio VF PMD Driver
 registration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Feb 2017 14:29:46 -0000

On 2/21/2017 9:26 AM, Shijith Thotton wrote:
> Register LiquidIO PMD (net_liovf) and define APIs to init and
> uninit.
> 
> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Signed-off-by: Derek Chickles <derek.chickles@caviumnetworks.com>
> Signed-off-by: Venkat Koppula <venkat.koppula@caviumnetworks.com>
> Signed-off-by: Mallesham Jatharakonda <mjatharakonda@oneconvergence.com>
<...>

> +
> +	mac_addr_size = ETHER_ADDR_LEN;
> +
> +	eth_dev->data->mac_addrs = rte_zmalloc("lio", mac_addr_size, 0);

"mac_addr_size" only used here, your call but it is possible to remove
variable and use ETHER_ADDR_LEN here directly.