From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 9AB84569F for ; Fri, 23 Sep 2016 11:30:39 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id w84so19983480wmg.1 for ; Fri, 23 Sep 2016 02:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=qWncH3qpar+5kTs0uOPZ7bTnVpjfmjnf6hehOYJfoIs=; b=Dl1vbjkKaGmuqYKew9ZxpmRbH3vDnCSZLNNSvhPQJ9Bew5cTsU8SOaw6TSaSpaWZou VxSjQ2kreYfktOdMND0k/K1K9NYqrUa33mW2LW+ZoVNgLfw55qW2kFuBMY4UgnUXj6Wy FNU18afKNsCUTmu01Pew13QcqanBa1NAIdWs77ASoelMGdSU9bH8hmHCCBt2tRIBmmdf 6IZSKf96iEL98seaTITA/EssetSOatT/Kqcl2CPeYz0TYVi2CwTUFwatHYm9Rxowug/C S+L8vPvzpk1/mzJfQmgZ+ikv6wz5IbJvEaPox1uDBp8uDKw3C4N6iON+tu/YORH7YYLC PlJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=qWncH3qpar+5kTs0uOPZ7bTnVpjfmjnf6hehOYJfoIs=; b=HQCznS+ZhP4jOjloCs24ApYe4saVoCtkCaCVr70bXIOkEuvpk97c0wYcXXcaziDQ+s Dw07e9mqxvYHYNaxm3XkV7OQlem9T/uMIB8U1H5I9WFmWBQ3D3sUcjYWE8AGqIB9qymF 7X5ajH8O7fiIxBaKyhEkHkSLKwQVTMvGjGsdY+POCMJHsX4HxhKdYRTFgA8weShOUtee mrr3cPvXjigMto6wxB2eyG/PMNeLuEJu4PXN/TnEgqFw55/XfO2W60Yi2iW3g+ezyidu RbqEfT6pO3mHb/tuyY7JcIOYnGVmrtisRJWaAJ/pJBJmrSK9OorRCweOjKA2pI6CCQQe DGqQ== X-Gm-Message-State: AA6/9RniCM/nnNB34LFV9AV7R9iYSBVDA31FsKDONEG0AAkfACNWWmNW4YkKeVG4R1ObKcD7 X-Received: by 10.28.216.211 with SMTP id p202mr1699900wmg.85.1474623039435; Fri, 23 Sep 2016 02:30:39 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id ir9sm6294076wjb.16.2016.09.23.02.30.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Sep 2016 02:30:38 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Fri, 23 Sep 2016 11:30:36 +0200 Message-ID: <2710503.PVzG3DrFxT@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <6873211.QDWnoOkD9j@xps13> <1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix verbosity zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 09:30:39 -0000 2016-09-23 10:06, Ferruh Yigit: > On 9/23/2016 12:42 AM, Thomas Monjalon wrote: > > Verbosity is considered enabled when $V is not empty. > > So V=0 and V=1 are equivalent. > > It is fixed by unsetting V when it is 0. > > > > A side effect is to fix kernel module compilation verbosity > > which is set to 0 when V is empty. > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Thomas Monjalon [...] > > --- a/mk/rte.sdkroot.mk > > +++ b/mk/rte.sdkroot.mk > > @@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory > > # define Q to '@' or not. $(Q) is used to prefix all shell commands to > > # be executed silently. > > Q=@ > > +ifeq '$V' '0' > > +override V= > > +endif > > ifdef V > > Why not simply: > -ifdef V > +ifeq ($(V),1) Because: - V could have a higher value - $(if $V) construct is used in several places in the makefiles See git grep '$(if $(*V'