From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECFFAA052A; Mon, 25 Jan 2021 11:51:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6758E140ED1; Mon, 25 Jan 2021 11:51:36 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id ACB74140EC9; Mon, 25 Jan 2021 11:51:33 +0100 (CET) IronPort-SDR: j1T10bOsewPiIf8SnP9CCR4Xh7+cQ/RYe9Qmo8c8Q6bRRkyTQKCq2V0Xp5hDezHYW7oB9M4wyw Evf6tOZHA8LQ== X-IronPort-AV: E=McAfee;i="6000,8403,9874"; a="241240070" X-IronPort-AV: E=Sophos;i="5.79,373,1602572400"; d="scan'208";a="241240070" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2021 02:51:32 -0800 IronPort-SDR: JwNpOLlRVgMs+hcjfuRtbICkR9rblz0KEtydte8+f8AK300uhl0JAUkq3HCUjxdmcwVLZDg8k+ 6E+oSc7Y0IVw== X-IronPort-AV: E=Sophos;i="5.79,373,1602572400"; d="scan'208";a="361434395" Received: from kmcallix-mobl.ger.corp.intel.com (HELO [10.213.196.59]) ([10.213.196.59]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2021 02:51:30 -0800 To: Thomas Monjalon , dev@dpdk.org Cc: stable@dpdk.org, Ferruh Yigit , Andrew Rybchenko , Liron Himi , Stephen Hemminger References: <20210122175804.772207-1-thomas@monjalon.net> From: "Burakov, Anatoly" Message-ID: <2711f5fa-341d-8a39-b02b-51cbfe0aced1@intel.com> Date: Mon, 25 Jan 2021 10:51:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210122175804.772207-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/1] ethdev: fix handling of close failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-Jan-21 5:58 PM, Thomas Monjalon wrote: > If a failure happens when closing a port, > it was unnecessarily failing again in the function eth_err(), > because of a check against HW removal cause. > Indeed there is a big chance the port is released at this point. > Given the port is in the middle (or at the end) of a close process, > checking the error cause by accessing the port is a non-sense. > The error check is replaced by a simple return in the close function. > > Bugzilla ID: 624 > Fixes: 8a5a0aad5d3e ("ethdev: allow close function to return an error") > Cc: stable@dpdk.org > > Reported-by: Anatoly Burakov > Signed-off-by: Thomas Monjalon > --- Tested-by: Anatoly Burakov -- Thanks, Anatoly