Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

[Thomas Monjalon <thomas@monjalon.net>]

03/04/2018 12:57, Bruce Richardson:
> On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote:
> > 03/04/2018 11:28, Ferruh Yigit:
> > > Library folder name and output library name are same except a few flaws
> > > including librte_ether.
> > > 
> > > This library is network device abstraction layer, the name "ethdev" fits
> > > better than "ether", and library & header files already named as ethdev.
> > > 
> > > Also there is a rte_ether.h in the net library which can cause confusion.
> > > 
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> > > Not sure if the we are ready for this change J
> > > 
> > > This is one the issues that the hassle of the change doesn't worth the
> > > benefit and you may prefer to live with the flaw.
> > > 
> > > Also a concern is this breaks the git history.
> > 
> > Yes it breaks the git history.
> > I am a big user of gitk. Do you know how to follow the history after rename
> > with gitk?
> > 
> > I think it is a good change but I would like to be sure it will not
> > bother us every day.
> > 
> For those of use with even slight OCD, having it the way it is bothers us
> every day! :-)
> I view this as something that we really should do some day - it's just
> broken the way the way it is right now - and so the sooner we take the hit
> and fix it, the better.

Yes

> If you do need to find the history of the file, would git blame work well
> enough for you?

No, blame is not enough, but it does not matter.

When should we do this rename? 18.05-rc1?