From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5080343D14;
Thu, 21 Mar 2024 10:55:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1FC534029F;
Thu, 21 Mar 2024 10:55:15 +0100 (CET)
Received: from wfhigh5-smtp.messagingengine.com
(wfhigh5-smtp.messagingengine.com [64.147.123.156])
by mails.dpdk.org (Postfix) with ESMTP id E88CF40261;
Thu, 21 Mar 2024 10:55:12 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
by mailfhigh.west.internal (Postfix) with ESMTP id 453F418000CF;
Thu, 21 Mar 2024 05:55:08 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute5.internal (MEProxy); Thu, 21 Mar 2024 05:55:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to; s=fm2; t=1711014907;
x=1711101307; bh=110nDV63ALZl7Bie5oML17lLJdyrctdnCakCmq8Jq0Q=; b=
G15Fq1ob1yXQiidyHMA2uD1BWbOizfeAil6WdDw5+fTmeAn1cwv02W/zHEu46ADS
wz1BavLmkg83ELZfFGFxrAiVq0lcrW/4NI1a6A1cycs2X9SqdaJe3fpBkw4fT5k3
ZLIq51KFSxiDnAfH8v8cqTeUNSymusEuYv7Wph/uePHLtjUjlh3mUlh6XhC9SEFA
pyhExMO6qWScj7IFy5fchmJtK/saJt596LbvSv/MsRLS3JQxo2KNAD9VmqsU5iob
rnbNGOS6qCLdhTpcq+ASnZ/THE9s6CkjMmb5iJV93HzmLFzL8jxohoSDUz6KDNYW
BT0usfBAoSi/NWTSh9YY0w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711014907; x=
1711101307; bh=110nDV63ALZl7Bie5oML17lLJdyrctdnCakCmq8Jq0Q=; b=Q
WmiPZMz4zV7NFeRw8cP4RSoYdU2fKSurIA0OCJNIQYF8qWVqUFdCkqzNy2RPNz3Y
XlVa+LxEEjS0wH7L7Mr8ybxuM1lf8kOUOeYUhqXI9YDFmuzLAg/CnDwW8duskotU
YIrIBzzRu9BudKBpEJZqqIBDJVtNDlXYHMr1YyHC5ElB8MxTshCh0mAL0xwfXMMR
GZ+SXZZiysFtpOSIvaOCNfxh6KLdgt78iaeavPtnjZ6BtDEOyI8GsyKDVDWlhUfE
6zQALFzoEYsfvQ9O6jhjL+s45GpcBdPy6cpHrb7MapZpzhfgsfwel4+402lUOpLm
hYtMxzuWQ2DhWdXEDymUA==
X-ME-Sender: <xms:-gP8Zej2_AkiPgkANuPc38jDkvIUI2gizA2FD07wEOEa2eSMTn0xxQ>
<xme:-gP8ZfCsX5yLj1dgBALjajOe8mmkOrfBimUYcKcNnEKg6zrW5xZdh79uDyaRaXBGv
IRUb0T_oTjlRR2ABw>
X-ME-Received: <xmr:-gP8ZWGavA4ZsXFjKNYR-1EwxtfIbXbeIrE6YNtS0PJjBZh0vVm26g2M18dzv8dpmH-_IQAb0isnH5fpCquLDzHzmg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleeigddutdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu
vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:-gP8ZXRNUG0F2e6iXEUB34BAG57WEvXJnF5qHbzilZ84eIqQ-E2j4g>
<xmx:-gP8Zbz2-uuz8ffuExHD1SDZBc_g3hVCvKCQgsEzthgNoDcxm7hGSQ>
<xmx:-gP8ZV6SvvGyNQd5g02iEymoW0Qf7jBPVnP0KRy2dMeRQAMVe_x7eQ>
<xmx:-gP8ZYxX6goK6hudYyDyFdObDo3_mJKDs7ZMsZp8PyVqgaXhLYsTMg>
<xmx:-wP8ZbAYe6Nd63EzXjVQnW6nQmSAJYbWFfcnhpzteLhki0cqIhYpGuu9cL8>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
21 Mar 2024 05:55:04 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Cc: david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com,
radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com,
ferruh.yigit@amd.com, konstantin.ananyev@huawei.com,
stephen@networkplumber.org, david.marchand@redhat.com, dev@dpdk.org,
stable@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction
Date: Thu, 21 Mar 2024 10:55:02 +0100
Message-ID: <2714554.uZKlY2gecq@thomas>
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F2FC@smartserver.smartshare.dk>
References: <20240116182332.95537-1-sivaprasad.tummala@amd.com>
<20240318173146.24303-2-sivaprasad.tummala@amd.com>
<98CBD80474FA8B44BF855DF32C47DC35E9F2FC@smartserver.smartshare.dk>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
19/03/2024 08:24, Morten Br=C3=B8rup:
> > From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> > Sent: Monday, 18 March 2024 18.32
> >=20
> > Currently the config option allows lcore IDs up to 255,
> > irrespective of RTE_MAX_LCORES and needs to be fixed.
> >=20
> > The patch allows config options based on DPDK config.
> >=20
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >=20
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > ---
>=20
> I suggest you update the description of the individual patches too, like =
you did for patch 0/6.
>=20
> E.g. this patch not only fixes the lcore_id, but also the queue_id type s=
ize.
>=20
>=20
> For the series,
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>
I would recommend a separate patch for queue id as it is a separate issue.
However, there is no need to split per directory.
You can have patches changing all examples at once.