[dpdk-dev] [PATCH v1] sched: update profile oversubscribe config file

[dpdk-dev] [PATCH v1] sched: update profile oversubscribe config file

[Savinay Dharmappa]

update the profile_ov config file to support dynamic
update of subport rate.

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
---
 examples/qos_sched/profile_ov.cfg | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index ab509d28d7..14c89ae340 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -11,6 +11,9 @@ number of subports per port = 1
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+subport 0-8 = 0
+
+[subport profile 0]
 tb rate = 8400000           ; Bytes per second
 tb size = 100000            ; Bytes
 
-- 
2.17.1

[dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[Savinay Dharmappa]

update the profile_ov config file to support dynamic
update of subport rate.

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
---
v2: renamed the commit subject.
---
 examples/qos_sched/profile_ov.cfg | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index ab509d28d7..14c89ae340 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -11,6 +11,9 @@ number of subports per port = 1
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+subport 0-8 = 0
+
+[subport profile 0]
 tb rate = 8400000           ; Bytes per second
 tb size = 100000            ; Bytes
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, October 27, 2020 9:22 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe
> config file
> 
> update the profile_ov config file to support dynamic
> update of subport rate.
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: renamed the commit subject.
> ---
>  examples/qos_sched/profile_ov.cfg | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/qos_sched/profile_ov.cfg
> b/examples/qos_sched/profile_ov.cfg
> index ab509d28d7..14c89ae340 100644
> --- a/examples/qos_sched/profile_ov.cfg
> +++ b/examples/qos_sched/profile_ov.cfg
> @@ -11,6 +11,9 @@ number of subports per port = 1
>  number of pipes per subport = 32
>  queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
> 
> +subport 0-8 = 0
> +
> +[subport profile 0]
>  tb rate = 8400000           ; Bytes per second
>  tb size = 100000            ; Bytes
> 
> --
> 2.17.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[Dharmappa, Savinay]

-----Original Message-----
From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> 
Sent: Tuesday, October 27, 2020 3:16 PM
To: Dharmappa, Savinay <savinay.dharmappa@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
Subject: RE: [PATCH v2] examples/qos_sched: update profile oversubscribe config file



> -----Original Message-----
> From: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Sent: Tuesday, October 27, 2020 9:22 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, 
> Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com>
> Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe 
> config file
> 
> update the profile_ov config file to support dynamic update of subport 
> rate.
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> ---
> v2: renamed the commit subject.
> ---
>  examples/qos_sched/profile_ov.cfg | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/examples/qos_sched/profile_ov.cfg
> b/examples/qos_sched/profile_ov.cfg
> index ab509d28d7..14c89ae340 100644
> --- a/examples/qos_sched/profile_ov.cfg
> +++ b/examples/qos_sched/profile_ov.cfg
> @@ -11,6 +11,9 @@ number of subports per port = 1  number of pipes per 
> subport = 32  queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
> 
> +subport 0-8 = 0
> +
> +[subport profile 0]
>  tb rate = 8400000           ; Bytes per second
>  tb size = 100000            ; Bytes
> 
> --
> 2.17.1

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Hi Thomas,
>> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[Thomas Monjalon]

05/11/2020 10:39, Dharmappa, Savinay:
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Hi Thomas,
> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know

-rc2 was very busy, and examples were low priority.
Will look into examples for -rc3.

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[David Marchand]

On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay
<savinay.dharmappa@intel.com> wrote:
> Hi Thomas,
> >> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know

Please, pay attention when editing replies, this mail of yours added
Cristian token again in patchwork.

The commitlog is vague and gives no context.

I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file
and documentations.

If so, please submit one patch fixing the qos_sched example (both
config and doc) and another patch for fixing the ip_pipeline (doc).
In both of them, describe with a Fixes: tag which commits are being fixed.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[Dharmappa, Savinay]

-----Original Message-----
From: David Marchand <david.marchand@redhat.com> 
Sent: Friday, November 13, 2020 7:28 PM
To: Dharmappa, Savinay <savinay.dharmappa@intel.com>
Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay <savinay.dharmappa@intel.com> wrote:
> Hi Thomas,
> >> I see that this patch is not applied on rc2. When can this will be 
> >> applied ? will it be part of rc3 ?. Please let me know

Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork.

The commitlog is vague and gives no context.

I looked through patchwork and found:
https://patchwork.dpdk.org/patch/81666/
So, iiuc, you forgot to update those two examples configuration file and documentations.

If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc).
In both of them, describe with a Fixes: tag which commits are being fixed.

>>  Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/  patch to have only ip_pipeline (doc). Please let me know.
--
David Marchand

Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file

[David Marchand]

On Tue, Nov 17, 2020 at 8:05 AM Dharmappa, Savinay
<savinay.dharmappa@intel.com> wrote:
> If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc).
> In both of them, describe with a Fixes: tag which commits are being fixed.
>
> >>  Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/  patch to have only ip_pipeline (doc). Please let me know.

Yes, one patch for qos_shed and one patch for ip_pipeline.

-- 
David Marchand

[dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file

[Savinay Dharmappa]

update the qos_sched user guide and profile config file
with default subport profile.

Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically")

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
v3: addressed the review comments of patch v2
---
 doc/guides/sample_app_ug/qos_scheduler.rst | 4 ++++
 examples/qos_sched/profile_ov.cfg          | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst
index 3fb50d3654..e50f3cd536 100644
--- a/doc/guides/sample_app_ug/qos_scheduler.rst
+++ b/doc/guides/sample_app_ug/qos_scheduler.rst
@@ -135,6 +135,10 @@ The profile file has the following format:
     [subport 0]
     number of pipes per subport = 4096
     queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
+
+    subport 0-8 = 0     ; These subports are configured with subport profile 0
+
+    [subport profile 0]
     tb rate = 1250000000; Bytes per second
     tb size = 1000000; Bytes
     tc 0 rate = 1250000000;     Bytes per second
diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index ab509d28d7..14c89ae340 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -11,6 +11,9 @@ number of subports per port = 1
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+subport 0-8 = 0
+
+[subport profile 0]
 tb rate = 8400000           ; Bytes per second
 tb size = 100000            ; Bytes
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file

[David Marchand]

On Tue, Nov 17, 2020 at 11:06 AM Savinay Dharmappa
<savinay.dharmappa@intel.com> wrote:
>
> update the qos_sched user guide and profile config file
> with default subport profile.
>
> Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically")
>
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks.


-- 
David Marchand